feat(patch-detail): don't mention revision in events if its sole

Signed-off-by: Konstantinos Maninakis <[email protected]>

Author: maninak

CHANGELOG.md

@@ -35,6 +35,7 @@
   - the aforementioned coupled with the pre-existing feature of optimally auto-aligning the form as it resizes should seamlessly provide a smooth authoring experience
   - adjust the hover text of all form buttons to advertise their respective keyboard shortcut (if any)
   - **patch-detail:** preselect the merged revision, if any, in the revision selector instead of always the latest
+  - **patch-detail:** don't mention the revision and its identifier in events in the Activity section if there's only one revision
   - **patch-detail:** align the UX for every revision identifier shown in the patch-major-events section (top of the view) with the behaviour of those in the Activity section, i.e. showing the revision description on hover, and when clicked scrolling to the Revision section wherin more info about it is shown
   - **patch-detail:** don't mention the related commit in the patch-major-events section (~~"Last updated by W with revision X at commit Y Z time ago"~~). This information is still available in the Revision section.
   - **patch-detail:** keep the labels of the main buttons (top-right of the view) as a single line of text, even if the viewport is narrow enough to compress them

src/webviews/src/components/PatchDetailActivity.vue

@@ -260,13 +260,16 @@ function discardPatchCommentForm() {
             {{ `${event.review.verdict}ing` }}
           </span>
           <template v-else>with <span class="font-mono">no verdict</span> for</template>
-          revision
-          <span
-            @click="$emit('showRevision', event.revision)"
-            :title="getRevisionHoverTitle(event.revision.description)"
-            class="font-mono hover:cursor-pointer"
-            >{{ shortenHash(event.revision.id) }}</span
-          >
+          <template v-if="patch.revisions.length > 1">
+            revision
+            <span
+              @click="$emit('showRevision', event.revision)"
+              :title="getRevisionHoverTitle(event.revision.description)"
+              class="font-mono hover:cursor-pointer"
+              >{{ shortenHash(event.revision.id) }}</span
+            >
+          </template>
+          <template v-else> patch</template>
           posted
           <span v-if="event.review.inline?.length">with code-inlined comments</span>
           by
@@ -302,13 +305,16 @@ function discardPatchCommentForm() {
           <span v-if="!event.discussion.resolved"
             >(<span class="font-mono">unresolved</span>)</span
           >
-          posted on revision
-          <span
-            @click="$emit('showRevision', event.revision)"
-            :title="getRevisionHoverTitle(event.revision.description)"
-            class="font-mono hover:cursor-pointer"
-            >{{ shortenHash(event.revision.id) }}</span
-          >
+          posted
+          <template v-if="patch.revisions.length > 1">
+            on revision
+            <span
+              @click="$emit('showRevision', event.revision)"
+              :title="getRevisionHoverTitle(event.revision.description)"
+              class="font-mono hover:cursor-pointer"
+              >{{ shortenHash(event.revision.id) }}</span
+            >
+          </template>
           by
           <span :title="event.discussion.author.id" class="font-mono">{{
             getIdentityAliasOrId(event.discussion.author)
@@ -346,15 +352,17 @@ function discardPatchCommentForm() {
           <span :title="event.merge.author.id" class="font-mono">{{
             getIdentityAliasOrId(event.merge.author)
           }}</span>
-          using revision
-          <span
-            v-if="event.revision"
-            @click="$emit('showRevision', event.revision)"
-            :title="getRevisionHoverTitle(event.revision.description)"
-            class="font-mono hover:cursor-pointer"
-            >{{ shortenHash(event.revision.id) }}</span
-          >
-          <span v-else class="font-mono">{{ shortenHash(event.merge.revision) }}</span>
+          <template v-if="patch.revisions.length > 1">
+            using revision
+            <span
+              v-if="event.revision"
+              @click="$emit('showRevision', event.revision)"
+              :title="getRevisionHoverTitle(event.revision.description)"
+              class="font-mono hover:cursor-pointer"
+              >{{ shortenHash(event.revision.id) }}</span
+            >
+            <span v-else class="font-mono">{{ shortenHash(event.merge.revision) }}</span>
+          </template>
         </EventItem>
       </template>
     </EventList>