Skip to content

Commit 0a4fdfe

Browse files
committed
Gpu param for command line, tests.
1 parent b462da6 commit 0a4fdfe

File tree

14 files changed

+75
-43
lines changed

14 files changed

+75
-43
lines changed

deepprofiler/__main__.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
type=click.Path("r"))
2323
@click.option("--config", default=None,
2424
help="Path to existing config file",
25-
type=click.Path("r"))
25+
type=click.STRING)
2626
@click.option("--cores", default=0,
2727
help="Number of CPU cores for parallel processing (all=0)",
2828
type=click.INT)
@@ -52,13 +52,11 @@ def cli(context, root, config, exp, cores, gpu):
5252
"summaries": root+"/outputs/" + exp + "/summaries/",
5353
"features": root+"/outputs/" + exp + "/features/"
5454
}
55-
if config is not None:
56-
context.obj["config"] = {}
57-
context.obj["config"]["paths"] = {}
58-
context.obj["config"]["paths"]["config"] = config
59-
dirs["config"] = os.path.dirname(os.path.abspath(config))
60-
else:
61-
config = dirs["config"] + "/config.json"
55+
56+
context.obj["config"] = {}
57+
context.obj["config"]["paths"] = {}
58+
context.obj["config"]["paths"]["config"] = root+"/inputs/config/" + config
59+
6260
context.obj["cores"] = cores
6361
context.obj["gpu"] = gpu
6462

plugins/models/autoencoder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,6 @@ def define_model(config, dset):
6666

6767

6868
class ModelClass(DeepProfilerModel):
69-
def __init__(self, config, dset, generator, val_generator):
70-
super(ModelClass, self).__init__(config, dset, generator, val_generator)
69+
def __init__(self, config, dset, gpu, generator, val_generator):
70+
super(ModelClass, self).__init__(config, dset, gpu, generator, val_generator)
7171
self.feature_model, self.encoder, self.decoder, self.optimizer, self.loss = define_model(config, dset)

plugins/models/cnn.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,6 @@ def define_model(config, dset):
5252

5353

5454
class ModelClass(DeepProfilerModel):
55-
def __init__(self, config, dset, generator, val_generator):
56-
super(ModelClass, self).__init__(config, dset, generator, val_generator)
55+
def __init__(self, config, dset, gpu, generator, val_generator):
56+
super(ModelClass, self).__init__(config, dset, gpu, generator, val_generator)
5757
self.feature_model, self.optimizer, self.loss = define_model(config, dset)

plugins/models/densenet.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def define_model(config, dset):
4747
return model, optimizer, loss_func
4848

4949
class ModelClass(DeepProfilerModel):
50-
def __init__(self, config, dset, generator, val_generator):
51-
super(ModelClass, self).__init__(config, dset, generator, val_generator)
50+
def __init__(self, config, dset, gpu, generator, val_generator):
51+
super(ModelClass, self).__init__(config, dset, gpu, generator, val_generator)
5252
self.feature_model, self.optimizer, self.loss = define_model(config, dset)
5353

plugins/models/gan.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,8 @@ def train(self, epochs, steps_per_epoch, init_epoch):
140140

141141

142142
class ModelClass(DeepProfilerModel):
143-
def __init__(self, config, dset, generator, val_generator):
144-
super(ModelClass, self).__init__(config, dset, generator, val_generator)
143+
def __init__(self, config, dset, gpu, generator, val_generator):
144+
super(ModelClass, self).__init__(config, dset, gpu, generator, val_generator)
145145
self.gan = GAN(config, self.train_crop_generator, self.val_crop_generator)
146146
self.feature_model = self.gan.discriminator
147147

plugins/models/vae.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,6 @@ def vae_loss(x, x_decoded_mean):
8888

8989

9090
class ModelClass(DeepProfilerModel):
91-
def __init__(self, config, dset, generator, val_generator):
92-
super(ModelClass, self).__init__(config, dset, generator, val_generator)
91+
def __init__(self, config, dset, gpu, generator, val_generator):
92+
super(ModelClass, self).__init__(config, dset, gpu, generator, val_generator)
9393
self.feature_model, self.encoder, self.generator, self.optimizer, self.loss = define_model(config, dset)

tests/deepprofiler/learning/test_model.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,19 +111,22 @@ def val_crop_generator(config):
111111
generator = module.SingleImageGeneratorClass
112112
return generator
113113

114+
@pytest.fixture(scope="function")
115+
def gpu():
116+
return '0'
114117

115118
@pytest.fixture(scope="function")
116-
def model(config, dataset, crop_generator, val_crop_generator):
119+
def model(config, dataset, gpu, crop_generator, val_crop_generator):
117120
def create():
118121
module = importlib.import_module("plugins.models.{}".format(config["train"]["model"]["name"]))
119122
importlib.invalidate_caches()
120-
dpmodel = module.ModelClass(config, dataset, crop_generator, val_crop_generator)
123+
dpmodel = module.ModelClass(config, dataset, gpu, crop_generator, val_crop_generator)
121124
return dpmodel
122125
return create
123126

124127

125-
def test_init(config, dataset, crop_generator, val_crop_generator):
126-
dpmodel = DeepProfilerModel(config, dataset, crop_generator, val_crop_generator)
128+
def test_init(config, dataset, gpu, crop_generator, val_crop_generator):
129+
dpmodel = DeepProfilerModel(config, dataset, gpu, crop_generator, val_crop_generator)
127130
assert dpmodel.feature_model is None
128131
assert dpmodel.config == config
129132
assert dpmodel.dset == dataset

tests/deepprofiler/learning/test_profiling.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,12 @@ def locations(out_dir, metadata, config, make_struct):
9898
})
9999
locs.to_csv(path, index=False)
100100

101+
102+
@pytest.fixture(scope="function")
103+
def gpu():
104+
return '0'
105+
106+
101107
@pytest.fixture(scope="function")
102108
def checkpoint(config, dataset):
103109
crop_generator = importlib.import_module(
@@ -107,20 +113,20 @@ def checkpoint(config, dataset):
107113
"plugins.crop_generators.{}".format(config["train"]["model"]["crop_generator"])) \
108114
.SingleImageGeneratorClass
109115
dpmodel = importlib.import_module("plugins.models.{}".format(config["train"]["model"]["name"])) \
110-
.ModelClass(config, dataset, crop_generator, profile_crop_generator)
116+
.ModelClass(config, dataset, gpu, crop_generator, profile_crop_generator)
111117
dpmodel.feature_model.compile(dpmodel.optimizer, dpmodel.loss)
112118
filename = os.path.join(config["paths"]["checkpoints"], config["profile"]["checkpoint"])
113119
dpmodel.feature_model.save_weights(filename)
114120
return filename
115121

116122

117123
@pytest.fixture(scope="function")
118-
def profile(config, dataset):
119-
return deepprofiler.learning.profiling.Profile(config, dataset)
124+
def profile(config, dataset, gpu):
125+
return deepprofiler.learning.profiling.Profile(config, dataset, gpu)
120126

121127

122-
def test_init(config, dataset):
123-
prof = deepprofiler.learning.profiling.Profile(config, dataset)
128+
def test_init(config, dataset, gpu):
129+
prof = deepprofiler.learning.profiling.Profile(config, dataset, gpu)
124130
test_num_channels = len(config["dataset"]["images"]["channels"])
125131
assert prof.config == config
126132
assert prof.dset == dataset
@@ -152,8 +158,8 @@ def test_extract_features(profile, metadata, locations, checkpoint):
152158
assert os.path.isfile(output_file)
153159

154160

155-
def test_profile(config, dataset, data, locations, checkpoint):
156-
deepprofiler.learning.profiling.profile(config, dataset)
161+
def test_profile(config, dataset, data, locations, checkpoint, gpu):
162+
deepprofiler.learning.profiling.profile(config, dataset, gpu)
157163
for index, row in dataset.meta.data.iterrows():
158164
output_file = config["paths"]["features"] + "/{}_{}_{}.npz" \
159165
.format(row["Metadata_Plate"], row["Metadata_Well"], row["Metadata_Site"])

tests/deepprofiler/learning/test_training.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,13 +98,14 @@ def locations(out_dir, metadata, config, make_struct):
9898
def test_learn_model(config, dataset, data, locations, out_dir, make_struct):
9999
epoch = 1
100100
verbose = 1
101-
deepprofiler.learning.training.learn_model(config, dataset, epoch, verbose=verbose)
101+
gpu = '0'
102+
deepprofiler.learning.training.learn_model(config, dataset, gpu, epoch, verbose=verbose)
102103
assert os.path.exists(os.path.join(config["paths"]["checkpoints"], "checkpoint_0001.hdf5"))
103104
assert os.path.exists(os.path.join(config["paths"]["checkpoints"], "checkpoint_0002.hdf5"))
104105
assert os.path.exists(os.path.join(config["paths"]["logs"], "log.csv"))
105106
epoch = 3
106107
config["train"]["model"]["epochs"] = 4
107-
deepprofiler.learning.training.learn_model(config, dataset, epoch, verbose=verbose)
108+
deepprofiler.learning.training.learn_model(config, dataset, gpu, epoch, verbose=verbose)
108109
assert os.path.exists(os.path.join(config["paths"]["checkpoints"], "checkpoint_0003.hdf5"))
109110
assert os.path.exists(os.path.join(config["paths"]["checkpoints"], "checkpoint_0004.hdf5"))
110111
assert os.path.exists(os.path.join(config["paths"]["logs"], "log.csv"))

tests/plugins/models/test_autoencoder.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,10 @@ def val_generator():
8282
return deepprofiler.imaging.cropping.SingleImageCropGenerator
8383

8484

85+
@pytest.fixture(scope="function")
86+
def gpu():
87+
return '0'
88+
8589
def test_define_model(config, dataset):
8690
autoencoder, encoder, decoder, optimizer, loss = plugins.models.autoencoder.define_model(config, dataset)
8791
assert isinstance(autoencoder, keras.Model)
@@ -91,8 +95,8 @@ def test_define_model(config, dataset):
9195
assert isinstance(loss, str) or callable(loss)
9296

9397

94-
def test_init(config, dataset, generator, val_generator):
95-
dpmodel = plugins.models.autoencoder.ModelClass(config, dataset, generator, val_generator)
98+
def test_init(config, dataset, gpu, generator, val_generator):
99+
dpmodel = plugins.models.autoencoder.ModelClass(config, dataset, gpu, generator, val_generator)
96100
autoencoder, encoder, decoder, optimizer, loss = plugins.models.autoencoder.define_model(config, dataset)
97101
assert dpmodel.feature_model.__eq__(autoencoder)
98102
assert dpmodel.encoder.__eq__(encoder)

0 commit comments

Comments
 (0)