enhance: allow # character in branch name (sourcegit-scm#271)

love-linger · love-linger · commit 9f09b8e3261b · 2024-07-21T17:44:38.000+08:00
diff --git a/src/ViewModels/CreateBranch.cs b/src/ViewModels/CreateBranch.cs
@@ -6,7 +6,7 @@ namespace SourceGit.ViewModels
     public class CreateBranch : Popup
     {
         [Required(ErrorMessage = "Branch name is required!")]
-        [RegularExpression(@"^[\w\-/\.]+$", ErrorMessage = "Bad branch name format!")]
+        [RegularExpression(@"^[\w\-/\.#]+$", ErrorMessage = "Bad branch name format!")]
         [CustomValidation(typeof(CreateBranch), nameof(ValidateBranchName))]
         public string Name
         {
diff --git a/src/ViewModels/GitFlowStart.cs b/src/ViewModels/GitFlowStart.cs
@@ -6,7 +6,7 @@ namespace SourceGit.ViewModels
     public class GitFlowStart : Popup
     {
         [Required(ErrorMessage = "Name is required!!!")]
-        [RegularExpression(@"^[\w\-/\.]+$", ErrorMessage = "Bad branch name format!")]
+        [RegularExpression(@"^[\w\-/\.#]+$", ErrorMessage = "Bad branch name format!")]
         [CustomValidation(typeof(GitFlowStart), nameof(ValidateBranchName))]
         public string Name
         {
diff --git a/src/ViewModels/RenameBranch.cs b/src/ViewModels/RenameBranch.cs
@@ -12,7 +12,7 @@ public Models.Branch Target
         }
 
         [Required(ErrorMessage = "Branch name is required!!!")]
-        [RegularExpression(@"^[\w\-/\.]+$", ErrorMessage = "Bad branch name format!")]
+        [RegularExpression(@"^[\w\-/\.#]+$", ErrorMessage = "Bad branch name format!")]
         [CustomValidation(typeof(RenameBranch), nameof(ValidateBranchName))]
         public string Name
         {

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace SourceGit.ViewModels`
`6`	`6`	`public class CreateBranch : Popup`
`7`	`7`	`{`
`8`	`8`	`[Required(ErrorMessage = "Branch name is required!")]`
`9`		`- [RegularExpression(@"^[\w\-/\.]+$", ErrorMessage = "Bad branch name format!")]`
	`9`	`+ [RegularExpression(@"^[\w\-/\.#]+$", ErrorMessage = "Bad branch name format!")]`
`10`	`10`	`[CustomValidation(typeof(CreateBranch), nameof(ValidateBranchName))]`
`11`	`11`	`public string Name`
`12`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace SourceGit.ViewModels`
`6`	`6`	`public class GitFlowStart : Popup`
`7`	`7`	`{`
`8`	`8`	`[Required(ErrorMessage = "Name is required!!!")]`
`9`		`- [RegularExpression(@"^[\w\-/\.]+$", ErrorMessage = "Bad branch name format!")]`
	`9`	`+ [RegularExpression(@"^[\w\-/\.#]+$", ErrorMessage = "Bad branch name format!")]`
`10`	`10`	`[CustomValidation(typeof(GitFlowStart), nameof(ValidateBranchName))]`
`11`	`11`	`public string Name`
`12`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ public Models.Branch Target`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`[Required(ErrorMessage = "Branch name is required!!!")]`
`15`		`- [RegularExpression(@"^[\w\-/\.]+$", ErrorMessage = "Bad branch name format!")]`
	`15`	`+ [RegularExpression(@"^[\w\-/\.#]+$", ErrorMessage = "Bad branch name format!")]`
`16`	`16`	`[CustomValidation(typeof(RenameBranch), nameof(ValidateBranchName))]`
`17`	`17`	`public string Name`
`18`	`18`	`{`