(S12) IMPORTANT - LOOK AT README INSTALL INSTRUCTIONS - Added script to sign DLL so that D4LF will work again (#639)

Author: chrisoro

.pre-commit-config.yaml

@@ -1,48 +1,74 @@
 default_install_hook_types: [pre-push]
 default_language_version:
   python: python3.14
-minimum_prek_version: '0.2.3'
+minimum_prek_version: '0.3.0'
 repos:
   - repo: https://github.com/astral-sh/uv-pre-commit
-    rev: 0.9.21
+    rev: 0.10.9
     hooks:
       - id: uv-lock
+        priority: &group1 4294967294
   - repo: https://github.com/executablebooks/mdformat
     rev: 1.0.0
     hooks:
       - id: mdformat
+        priority: *group1
         additional_dependencies:
           - mdformat-gfm
   - repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks
-    rev: v2.15.0
+    rev: v2.16.0
     hooks:
       - id: pretty-format-toml
+        priority: *group1
         args: [--autofix, --indent, "4"]
       - id: pretty-format-yaml
+        priority: *group1
         args: [--autofix, --preserve-quotes, --offset, "2"]
   - repo: https://github.com/pre-commit/mirrors-clang-format
-    rev: v21.1.8
+    rev: v22.1.0
     hooks:
       - id: clang-format
+        priority: *group1
         files: \.(cpp|h)$
-  - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v6.0.0
+  - repo: builtin
     hooks:
-      - id: check-ast
+      - id: check-added-large-files
+        priority: &read-only 4294967295
       - id: check-case-conflict
+        priority: *read-only
       - id: check-executables-have-shebangs
+        priority: *read-only
       - id: check-json
+        priority: *read-only
       - id: check-toml
-      - id: check-xml
+        priority: *read-only
       - id: check-yaml
+        priority: *read-only
       - id: end-of-file-fixer
       - id: fix-byte-order-marker
+      - id: trailing-whitespace
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v6.0.0
+    hooks:
+      - id: check-ast
+        priority: *read-only
       - id: pretty-format-json
         args: [--autofix, --indent=4, --no-ensure-ascii]
+        priority: *group1
       - id: trailing-whitespace
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.14.10
+    rev: v0.15.5
     hooks:
       - id: ruff-format
+        priority: *group1
       - id: ruff-check
+        priority: &group2 4294967293
         args: [--fix]
+  - repo: https://github.com/thetestlabs/py-psscriptanalyzer
+    rev: v0.3.1
+    hooks:
+      - id: py-psscriptanalyzer
+        priority: *read-only
+        args: ['--severity', 'Error']
+      - id: py-psscriptanalyzer-format
+        priority: *group1

README.md

@@ -20,22 +20,18 @@ feature request or issue reports join the [discord](https://discord.gg/YyzaPhAN6
 
 ## How to Setup
 
-### Game Settings
-
-- Game Language must be English
-- IMPORTANT: Advanced Tooltip Information must be enabled in Options > Gameplay > Gameplay. If you don't do this then item parsing will be very inconsistent and you will receive no warning something is wrong.
-- Font scale in Graphics settings must be small or medium
-- HDR makes the screen too bright and D4LF is unable to read the state of some items on screen. It must be disabled.
-- Use Screen Reader must be enabled in Options > Accessibility
-- 3rd Party Screen Reader must be enabled in Options > Accessibility (The voice will go away when DLL is installed, see quick start guide below)
-
-### Installation and quick start guide
+### Installation and quick start guide (New instructions for season 12 that must be followed!)
 
 - Download and extract the latest version (.zip) from the releases: https://github.com/d4lfteam/d4lf/releases
 - Copy `saapi64.dll` from the downloaded folder to your "Diablo IV" directory
   - To find your D4 directory:
     - In Battle.net, click the gear icon next to the Play button and select "Open in Explorer"
     - In Steam, right click the game, select Manage > Browse local files
+- **New for Season 12** The saapi64.dll must be locally signed for D4 to pick it up. We have written a script to do this for you. It is a one-time process per computer.
+  - Navigate to your d4lf directory
+  - Right click and choose "Open in Terminal"
+  - Type the following: `.\sign_dll.ps1`
+  - When prompted for d4_path, paste in the D4 directory you located previously
 - Generate a profile of what you want to filter for. To do so you have a few options:
   - Run d4lf.exe and import a profile using the import window by pasting a build page from popular planner websites
   - Create one yourself by looking at the [examples](#how-to-filter--profiles) below
@@ -48,6 +44,15 @@ feature request or issue reports join the [discord](https://discord.gg/YyzaPhAN6
 - Use the hotkeys listed in d4lf.exe to run filtering. By default, F11 will run the loot filter and filter your items.
 - For most common issues, if something is wrong, you will see an error or warning when you start d4lf.exe. Join our [discord](https://discord.gg/YyzaPhAN6T) for more help.
 
+### Game Settings
+
+- Game Language must be English
+- IMPORTANT: Advanced Tooltip Information must be enabled in Options > Gameplay > Gameplay. If you don't do this then item parsing will be very inconsistent and you will receive no warning something is wrong.
+- Font scale in Graphics settings must be small or medium
+- HDR makes the screen too bright and D4LF is unable to read the state of some items on screen. It must be disabled.
+- Use Screen Reader must be enabled in Options > Accessibility
+- 3rd Party Screen Reader must be enabled in Options > Accessibility (The voice will go away when DLL is installed, see quick start guide below)
+
 ### Common problems
 
 - The GUI crashes immediately upon opening, with no error message given
@@ -700,7 +705,13 @@ If you receive an error about missing Visual Studio code, follow the link it pro
 
 ### Formatting & Linting
 
-Just use prek. If it's your first setup, run:
+Just use prek. If it's your first setup, you will need to install the NuGet package provider. Open Windows Powershell and run::
+
+```
+Install-PackageProvider -Name NuGet -MinimumVersion 2.8.5.201 -Force -Scope CurrentUser
+```
+
+Then run:
 
 ```bash
 prek install

assets/lang/enUS/affixes.json

@@ -429,6 +429,13 @@
     "familiar_explosion_size": "familiar explosion size",
     "familiar_lucky_hit_chance": "familiar lucky hit chance",
     "fanaticism_aura_potency": "fanaticism aura potency",
+    "feast_every_kills_chains_hook_nearby_enemies": "feast every kills, chains hook nearby enemies",
+    "feast_every_kills_gain_berserking_for_seconds": "feast every kills, gain berserking for seconds",
+    "feast_every_kills_release_a_bloodspolsion_for_damage": "feast every kills, release a bloodspolsion for damage",
+    "feast_every_kills_reset_random_cooldowns": "feast every kills, reset random cooldowns",
+    "feast_every_kills_restore_of_your_maximum_primary_resource": "feast every kills, restore of your maximum primary resource",
+    "feast_every_kills_savagely_bite_times_for_damage_and_apply_vulnerable": "feast every kills, savagely bite times for damage and apply vulnerable",
+    "feast_every_kills_your_next_core_skill_cast_deals_additional_damage": "feast every kills, your next core skill cast deals additional damage",
     "ferocity_potency": "ferocity potency",
     "fire_and_cold_damage": "fire and cold damage",
     "fire_damage": "fire damage",
@@ -476,6 +483,19 @@
     "hewed_flesh_grants_maximum_life_as_barrier_for_seconds": "hewed flesh grants maximum life as barrier for seconds",
     "holy_bolt_resource_generation": "holy bolt resource generation",
     "holy_light_aura_potency": "holy light aura potency",
+    "hunger_after_you_cast_a_basic_skill_chance_for_kill_to_your_kill_streak": "hunger after you cast a basic skill, chance for kill to your kill streak",
+    "hunger_after_you_cast_a_cooldown_kill_to_your_kill_streak": "hunger after you cast a cooldown, kill to your kill streak",
+    "hunger_after_you_kill_an_enemy_chance_for_kill_to_your_kill_streak": "hunger after you kill an enemy, chance for kill to your kill streak",
+    "hunger_every_resource_chance_for_kill_to_your_kill_streak": "hunger every resource, chance for kill to your kill streak",
+    "hunger_increased_chance_for_additional_gold_during_kill_streaks": "hunger increased chance for additional gold during kill streaks",
+    "hunger_increased_chance_for_additional_salvage_materials_during_your_kill_streaks": "hunger increased chance for additional salvage materials during your kill streaks",
+    "hunger_increased_chance_for_feast_items_during_your_kill_streaks": "hunger increased chance for feast items during your kill streaks",
+    "hunger_increased_chance_for_hunger_items_during_kill_streaks": "hunger increased chance for hunger items during kill streaks",
+    "hunger_increased_chance_for_rampage_items_during_kill_streaks": "hunger increased chance for rampage items during kill streaks",
+    "hunger_increased_chance_for_runes_during_your_kill_streaks": "hunger increased chance for runes during your kill streaks",
+    "hunger_increased_experience_from_kill_streaks": "hunger increased experience from kill streaks",
+    "hunger_increased_reputation_from_kill_streaks": "hunger increased reputation from kill streaks",
+    "hunger_lucky_hit_up_to_a_chance_for_kill_to_your_kill_streak": "hunger lucky hit up to a chance for kill to your kill streak",
     "hurricane_cooldown_reduction": "hurricane cooldown reduction",
     "hurricane_damage": "hurricane damage",
     "hurricane_duration": "hurricane duration",
@@ -657,6 +677,14 @@
     "rain_of_arrows_skill_cooldown_reduction": "rain of arrows skill cooldown reduction",
     "rake_size": "rake size",
     "rally_duration": "rally duration",
+    "rampage_attack_speed_per_kill_streak_tier": "rampage attack speed per kill streak tier",
+    "rampage_cooldown_reduction_per_kill_streak_tier": "rampage cooldown reduction per kill streak tier",
+    "rampage_critical_strike_chance_per_kill_streak_tier": "rampage critical strike chance per kill streak tier",
+    "rampage_life_on_hit_per_kill_streak_tier": "rampage life on hit per kill streak tier",
+    "rampage_lucky_hit_chance_per_kill_streak_tier": "rampage lucky hit chance per kill streak tier",
+    "rampage_maximum_life_per_kill_streak_tier": "rampage maximum life per kill streak tier",
+    "rampage_movement_speed_per_kill_streak_tier": "rampage movement speed per kill streak tier",
+    "rampage_resource_cost_reduction_per_kill_streak_tier": "rampage resource cost reduction per kill streak tier",
     "rank_of_all_agility_skills": "rank of all agility skills",
     "ranks_of_the_aggressive_resistance_passive": "ranks of the aggressive resistance passive",
     "ranks_of_the_concussive_passive": "ranks of the concussive passive",

assets/lang/enUS/uniques.json

@@ -83,9 +83,18 @@
     "chainscourged_mail": {
         "num_inherents": 0
     },
+    "cluckeye": {
+        "num_inherents": 1
+    },
+    "cluckonomicon": {
+        "num_inherents": 0
+    },
     "condemnation": {
         "num_inherents": 1
     },
+    "coop_de_grâce": {
+        "num_inherents": 1
+    },
     "cowl_of_the_nameless": {
         "num_inherents": 0
     },
@@ -128,6 +137,12 @@
     "ebonpiercer": {
         "num_inherents": 0
     },
+    "eggcecutioner": {
+        "num_inherents": 1
+    },
+    "eggis": {
+        "num_inherents": 3
+    },
     "endurant_faith": {
         "num_inherents": 0
     },

build.py

@@ -26,6 +26,7 @@ def copy_additional_resources(release_dir: Path):
     shutil.copy("README.md", release_dir)
     shutil.copy("tts/saapi64.dll", release_dir)
     shutil.copytree("assets", release_dir / "assets")
+    shutil.copy("tts/sign_dll.ps1", release_dir)
 
 
 def create_batch_for_consoleonly(release_dir: Path, exe_name: str):

pyproject.toml

@@ -4,14 +4,14 @@ requires = ["hatchling"]
 
 [dependency-groups]
 dev = [
+    "prek",
     "pyinstaller",
+    "pytest",
     "pytest-env",
     "pytest-mock",
     "pytest-pythonpath",
     "pytest-xdist",
-    "pytest",
-    "typing-extensions",
-    "prek"
+    "typing-extensions"
 ]
 
 [project]
@@ -142,6 +142,7 @@ ignore = [
     "RUF043",  # fix more in the future
     "RUF045",  # fix more in the future
     "RUF059",  # fix more in the future
+    "RUF067",  # fix more in the future
     "S101",  # fix more in the future
     "S311",  # fix more in the future
     "S404",
@@ -158,7 +159,8 @@ ignore = [
     "TRY002",  # fix more in the future
     "TRY003",  # fix more in the future
     "TRY004",  # fix more in the future
-    "TRY400"  # fix more in the future
+    "TRY400",  # fix more in the future
+    "UP047"  # fix more in the future
 ]
 select = ["ALL"]
 

src/__init__.py

@@ -2,4 +2,4 @@
 
 TP = concurrent.futures.ThreadPoolExecutor()
 
-__version__ = "8.1.2"
+__version__ = "8.2.0"

src/scripts/vision_mode_fast.py

@@ -132,9 +132,8 @@ def on_tts(self, _):
                 return self.request_draw("Unknown item", "#ce7e00")
 
             res = Filter().should_keep(item_descr)
-            match = res.keep
 
-            if match:
+            if res.keep:
                 color = get_filter_colors().matched
                 if not res.matched:
                     if item_descr.rarity == ItemRarity.Unique:

src/tools/gen_data.py

@@ -78,6 +78,7 @@ def is_placeholder_or_test_name(name) -> bool:
             "_test_",
             "(not_used",
             "(dns)",
+            "(crucible)",
         ]
     ):
         return True

tts/sign_dll.ps1

@@ -0,0 +1,78 @@
+param(
+    [Parameter(Mandatory = $true)]
+    [string]$d4_path
+)
+
+# ── 1. Create self-signed code-signing certificate (10-year validity) ──────────
+$cert = Get-ChildItem -Path "Cert:\CurrentUser\My" |
+    Where-Object { $_.Subject -eq "CN=Cert for D4LF" -and $_.HasPrivateKey } |
+    Select-Object -First 1
+
+if ($cert) {
+    Write-Output "Certificate already exists: $($cert.Thumbprint) — skipping creation."
+}
+else {
+    Write-Output "Creating self-signed code-signing certificate..."
+    $cert = New-SelfSignedCertificate `
+        -Type CodeSigningCert `
+        -Subject "CN=Cert for D4LF" `
+        -CertStoreLocation "Cert:\CurrentUser\My" `
+        -NotAfter (Get-Date).AddYears(10)
+    Write-Output "Certificate created: $($cert.Thumbprint)"
+}
+
+# ── 2. Copy cert to Trusted Root Certification Authorities ────────────────────
+$rootStore = New-Object System.Security.Cryptography.X509Certificates.X509Store(
+    [System.Security.Cryptography.X509Certificates.StoreName]::Root,
+    [System.Security.Cryptography.X509Certificates.StoreLocation]::CurrentUser
+)
+$rootStore.Open([System.Security.Cryptography.X509Certificates.OpenFlags]::ReadWrite)
+
+$alreadyTrusted = $rootStore.Certificates | Where-Object { $_.Thumbprint -eq $cert.Thumbprint }
+if ($alreadyTrusted) {
+    Write-Output "Certificate already in Trusted Root — skipping."
+}
+else {
+    $rootStore.Add($cert)
+    Write-Output "Certificate copied to Trusted Root."
+}
+$rootStore.Close()
+
+# ── 3. Locate signtool.exe under Windows Kits (prefer x64) ───────────────────
+Write-Output "Searching for signtool.exe..."
+$allSigntools = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits\10\bin\" `
+    -Recurse -Filter "signtool.exe" -ErrorAction SilentlyContinue
+
+# Prefer x64, then x86, then anything else
+$signtool = $allSigntools | Where-Object { $_.DirectoryName -match "\\x64$" } | Select-Object -First 1
+if (-not $signtool) { $signtool = $allSigntools | Where-Object { $_.DirectoryName -match "\\x86$" } | Select-Object -First 1 }
+if (-not $signtool) { $signtool = $allSigntools | Select-Object -First 1 }
+
+if (-not $signtool) {
+    Write-Error "signtool.exe not found under 'C:\Program Files (x86)\Windows Kits\10\bin\'."
+    exit 1
+}
+$signtool = $signtool.FullName
+Write-Output "Found signtool: $signtool"
+
+# ── 4. Sign the DLL ───────────────────────────────────────────────────────────
+$dllPath = Join-Path $d4_path "saapi64.dll"
+
+if (-not (Test-Path $dllPath)) {
+    Write-Error "DLL not found at: $dllPath"
+    exit 1
+}
+
+$sig = Get-AuthenticodeSignature -FilePath $dllPath
+if ($sig.Status -eq "Valid") {
+    Write-Output "DLL is already signed (status: $($sig.Status)) — skipping."
+    exit 0
+}
+
+Write-Output "Signing $dllPath ..."
+& $signtool sign /fd SHA256 /n "Cert for D4LF" $dllPath
+
+if ($LASTEXITCODE -ne 0) {
+    Write-Error "signtool exited with code $LASTEXITCODE"
+    exit $LASTEXITCODE
+}