Revert "IDE-suggested drive-by: extract comparator creation"

This reverts commit c25a037 due to
erroneous push.

Author: greenc-FNAL

modules/dcache/src/main/java/org/dcache/pool/classic/IoQueueManager.java

@@ -32,7 +32,6 @@
 import org.dcache.pool.FaultEvent;
 import org.dcache.pool.FaultListener;
 import org.dcache.pool.classic.MoverRequestScheduler.Order;
-import org.dcache.pool.classic.MoverRequestScheduler.PrioritizedRequest;
 import org.dcache.util.IoPriority;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -444,7 +443,24 @@ public Serializable call() throws CommandException {
                       .toArray(IoJobInfo[]::new);
             } else {
 
-                Comparator<PrioritizedRequest> comparator = getPrioritizedRequestComparator();
+                Comparator<MoverRequestScheduler.PrioritizedRequest> comparator;
+                if (sortBySize) {
+                    comparator = (b, a) -> Long.compare(
+                          a.getMover().getBytesTransferred(), b.getMover().getBytesTransferred()
+                    );
+                } else if (sortByTime) {
+                    comparator = (b, a) -> Long.compare(
+                          a.getMover().getLastTransferred(), b.getMover().getLastTransferred()
+                    );
+                } else {
+                    comparator = (b, a) -> Integer.compare(
+                          a.getId(), b.getId()
+                    );
+                }
+
+                if (reverseSort) {
+                    comparator = comparator.reversed();
+                }
 
                 StringBuilder sb = new StringBuilder();
                 if (groupByQueue) {
@@ -462,28 +478,6 @@ public Serializable call() throws CommandException {
                 return sb.toString();
             }
         }
-
-        private Comparator<PrioritizedRequest> getPrioritizedRequestComparator() {
-            Comparator<PrioritizedRequest> comparator;
-            if (sortBySize) {
-                comparator = (b, a) -> Long.compare(
-                      a.getMover().getBytesTransferred(), b.getMover().getBytesTransferred()
-                );
-            } else if (sortByTime) {
-                comparator = (b, a) -> Long.compare(
-                      a.getMover().getLastTransferred(), b.getMover().getLastTransferred()
-                );
-            } else {
-                comparator = (b, a) -> Integer.compare(
-                      a.getId(), b.getId()
-                );
-            }
-
-            if (reverseSort) {
-                comparator = comparator.reversed();
-            }
-            return comparator;
-        }
     }
 
     @Command(name = "p2p ls", hint = "list pool to pool source movers",