code coverage: centralize JaCoCo version

Motivation:

    To improve maintainability and ensure consistency across the JaCoCo toolchain.
    This change centralizes the JaCoCo version and removes hardcoded values from scripts and CI jobs.

Modifications:

    CI:
        Updated .gitlab-ci.yml to use a global JACOCO_VERSION variable, removing hardcoded versions from get_jacoco_cli and generate_jacoco_report jobs.
    Scripts:
        Modified get-jacoco.sh and generate-jacoco-report.sh to use the JACOCO_VERSION environment variable with a fallback value for failproof execution.
    Cleanup: Removed redundant version declarations.

Results:

    The JaCoCo version is now defined once in .gitlab-ci.yml, and once in parent pom.xml.

Testing:

    Confirmed CI jobs use the correct version and generate reports as expected.

Acked-by: Tigran Mkrtchyan
Target: master
Require-book: no
Require-notes: no

Author: chubnastia

.gitlab-ci.yml

@@ -53,7 +53,7 @@ variables:
   AUTOCA_URL: https://ci.dcache.org/ca
   DCACHE_HELM_REPO: https://gitlab.desy.de/api/v4/projects/7648/packages/helm/test
   DCACHE_COMPATIBILITY_VERSION: 9.2.20
-
+  JACOCO_VERSION: 0.8.14 #must match maven plugin version
 
 # let's debug nodes where job is running
 before_script:
@@ -94,6 +94,7 @@ default:
     name: dtzar/helm-kubectl:latest
     entrypoint: ['']
 
+
 #
 # default cache konfiguration for maven build jobs
 # Cache downloaded dependencies and plugins between builds.
@@ -707,15 +708,12 @@ Run OIDC test:
 get_jacoco_cli:
   stage: build
   image: eclipse-temurin:17-jre
-  variables:
-    JACOCO_VERSION: "0.8.14"
   script:
     - ./get-jacoco.sh
   cache:
     key: "jacoco-cli-${JACOCO_VERSION}"  #cache per version
     paths:
       - "jacoco-${JACOCO_VERSION}/"      #cache the entire JaCoCo directory
-    policy: pull
   artifacts:
     paths:
       - "jacoco-${JACOCO_VERSION}/lib/jacococli.jar"
@@ -725,8 +723,6 @@ get_jacoco_cli:
 generate_jacoco_report:
   stage: build
   image: eclipse-temurin:17-jre
-  variables:
-    JACOCO_VERSION: "0.8.14"
   needs:
     - job: run_ut_with_coverage
       artifacts: true

generate-jacoco-report.sh

@@ -2,7 +2,7 @@
 
 # Define paths
 PROJECT_ROOT="${PROJECT_ROOT:-$(pwd)}"
-JACOCO_VERSION=0.8.14
+JACOCO_VERSION="${JACOCO_VERSION:-0.8.14}"  # Use env var or fallback
 JACOCO_DIR="${PROJECT_ROOT}/jacoco-$JACOCO_VERSION"
 JACOCO_CLI_JAR="$JACOCO_DIR/lib/jacococli.jar"
 MERGED_EXEC="$PROJECT_ROOT/target/coverage-reports/merged.exec"

get-jacoco.sh

@@ -3,7 +3,7 @@
 apt-get update && apt-get install -y wget unzip
 # Define paths
 PROJECT_ROOT="${PROJECT_ROOT:-$(pwd)}"
-JACOCO_VERSION=0.8.14
+JACOCO_VERSION="${JACOCO_VERSION:-0.8.14}"  # Use env var or fallback
 JACOCO_DIR="${PROJECT_ROOT}/jacoco-$JACOCO_VERSION"
 JACOCO_CLI_JAR="$JACOCO_DIR/lib/jacococli.jar"
 

pom.xml

@@ -101,6 +101,7 @@
         <datanucleus.plugin.version>6.0.0-release</datanucleus.plugin.version>
         <asm.version>9.5</asm.version>
         <asm-tools.version>5.0.3</asm-tools.version>
+        <jacoco.version>0.8.14</jacoco.version>
     </properties>
 
     <scm>
@@ -1242,7 +1243,7 @@
                 <plugin>
                     <groupId>org.jacoco</groupId>
                     <artifactId>jacoco-maven-plugin</artifactId>
-                    <version>0.8.14</version>
+                    <version>${jacoco.version}</version>
                 </plugin>
                 <plugin>
                     <groupId>com.ruleoftech</groupId>