pool: extract comparator creation to function in IoQueueManager

Motivation:

As suggested by IntelliJ IDEA, extract the creation of the comparator to its own function for clarity and encapsulation.

Modification:

Move the logic creating a comparator from a conditional to its own function, `getPrioritizedRequestComparator()`

Also fix a minor typo in a comment.

Result:

Code is clearer and less susceptible to unwanted fragmentation during update or refactoring.

Target: master
Patch: https://rb.dcache.org/r/14525/
Requires-notes: NO
Requires-book: NO
Acked-By: Tigran Mkrtchyan

Author: greenc-FNAL

modules/dcache/src/main/java/org/dcache/pool/classic/IoQueueManager.java

@@ -32,6 +32,7 @@
 import org.dcache.pool.FaultEvent;
 import org.dcache.pool.FaultListener;
 import org.dcache.pool.classic.MoverRequestScheduler.Order;
+import org.dcache.pool.classic.MoverRequestScheduler.PrioritizedRequest;
 import org.dcache.util.IoPriority;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -438,29 +439,12 @@ public Serializable call() throws CommandException {
             }
 
             if (isBinary) {
-                // ignore sortin and grouping by queue name if binnary
+                // ignore sorting and grouping by queue name if binary
                 return queues.stream().flatMap(s -> s.getJobInfos().stream())
                       .toArray(IoJobInfo[]::new);
             } else {
 
-                Comparator<MoverRequestScheduler.PrioritizedRequest> comparator;
-                if (sortBySize) {
-                    comparator = (b, a) -> Long.compare(
-                          a.getMover().getBytesTransferred(), b.getMover().getBytesTransferred()
-                    );
-                } else if (sortByTime) {
-                    comparator = (b, a) -> Long.compare(
-                          a.getMover().getLastTransferred(), b.getMover().getLastTransferred()
-                    );
-                } else {
-                    comparator = (b, a) -> Integer.compare(
-                          a.getId(), b.getId()
-                    );
-                }
-
-                if (reverseSort) {
-                    comparator = comparator.reversed();
-                }
+                Comparator<PrioritizedRequest> comparator = getPrioritizedRequestComparator();
 
                 StringBuilder sb = new StringBuilder();
                 if (groupByQueue) {
@@ -478,6 +462,28 @@ public Serializable call() throws CommandException {
                 return sb.toString();
             }
         }
+
+        private Comparator<PrioritizedRequest> getPrioritizedRequestComparator() {
+            Comparator<PrioritizedRequest> comparator;
+            if (sortBySize) {
+                comparator = (b, a) -> Long.compare(
+                      a.getMover().getBytesTransferred(), b.getMover().getBytesTransferred()
+                );
+            } else if (sortByTime) {
+                comparator = (b, a) -> Long.compare(
+                      a.getMover().getLastTransferred(), b.getMover().getLastTransferred()
+                );
+            } else {
+                comparator = (b, a) -> Integer.compare(
+                      a.getId(), b.getId()
+                );
+            }
+
+            if (reverseSort) {
+                comparator = comparator.reversed();
+            }
+            return comparator;
+        }
     }
 
     @Command(name = "p2p ls", hint = "list pool to pool source movers",