code coverage: implement JaCoCo report generation in CI (rev2)

Author: chubnastia

generate-jacoco-report.sh

@@ -17,26 +17,19 @@ fi
 # Ensure the report directory exists
 mkdir -p "$REPORT_DIR"
 
-# Find all jacoco-ut.exec files dynamically
-EXEC_FILES=($(find "$PROJECT_ROOT" -name "jacoco-ut.exec" -type f))
+# Issue 1: Simplified find command (avoiding array initialization)
+EXEC_FILES=$(find "$PROJECT_ROOT" -name "jacoco-ut.exec" -type f)
 
-# Check if any execution data files were found
-if [ ${#EXEC_FILES[@]} -eq 0 ]; then
+# Issue 2: Simplified check for empty results using -z
+if [ -z "$EXEC_FILES" ]; then
     echo "Error: No jacoco-ut.exec files found in $PROJECT_ROOT"
     exit 1
 fi
 
-# Check if all execution data files exist
-for exec_file in "${EXEC_FILES[@]}"; do
-    if [ ! -f "$exec_file" ]; then
-        echo "Error: Execution data file not found at $exec_file"
-        exit 1
-    fi
-done
-
 # Merge execution data files
 echo "Merging execution data files..."
-java -jar "$JACOCO_CLI_JAR" merge "${EXEC_FILES[@]}" --destfile "$MERGED_EXEC"
+# Issue 4: Passing the string directly
+java -jar "$JACOCO_CLI_JAR" merge ${EXEC_FILES} --destfile "$MERGED_EXEC"
 
 if [ $? -ne 0 ]; then
     echo "Error: Failed to merge execution data files"
@@ -50,10 +43,11 @@ echo "Generating coverage report..."
 CLASSFILES_ARGS=()
 SOURCEFILES_ARGS=()
 
-for exec_file in "${EXEC_FILES[@]}"; do
+# Issue 5: Iterating over the string list instead of an array
+for exec_file in ${EXEC_FILES}; do
     # Extract module path (e.g., core, dlm, rquota) from the exec file path
     module_path=$(dirname "$(dirname "$(dirname "$exec_file")")")
-    module_name=$(basename "$module_path")
+
     # Add classfiles and sourcefiles arguments
     CLASSFILES_ARGS+=("--classfiles" "$module_path/target/classes")
     SOURCEFILES_ARGS+=("--sourcefiles" "$module_path/src/main/java")