pnfs: drop IO mode check on layout commit

Motivation:
As pNFS device manager is responsible for issuing layouts
the nfs server can't match layout state ids to
layouts, thus cant check the IO modes.

Modification:
Drop layout IO mode tests from the generic layoutcommit operation.

Result:
more responsibility on pNFS device manager

Acked-by: Marina Sahakyan
Target: master

Author: kofemann

core/src/main/java/org/dcache/nfs/v4/OperationLAYOUTCOMMIT.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2009 - 2019 Deutsches Elektronen-Synchroton,
+ * Copyright (c) 2009 - 2025 Deutsches Elektronen-Synchroton,
  * Member of the Helmholtz Association, (DESY), HAMBURG, GERMANY
  *
  * This library is free software; you can redistribute it and/or modify
@@ -29,11 +29,8 @@
 import org.dcache.nfs.v4.xdr.LAYOUTCOMMIT4resok;
 import org.dcache.nfs.v4.xdr.LAYOUTCOMMIT4res;
 import org.dcache.nfs.ChimeraNFSException;
-import org.dcache.nfs.status.BadLayoutException;
 import org.dcache.nfs.status.NotSuppException;
-import org.dcache.nfs.v4.xdr.nfs4_prot;
 import org.dcache.nfs.v4.xdr.nfs_resop4;
-import org.dcache.nfs.v4.xdr.stateid4;
 import org.dcache.nfs.vfs.Inode;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -56,20 +53,6 @@ public void process(CompoundContext context, nfs_resop4 result) throws ChimeraNF
                 .orElseThrow(() -> new NotSuppException("pNFS device manager not configured"));
 
         Inode inode = context.currentInode();
-        NFS4Client client = context.getSession().getClient();
-        stateid4 stateid = Stateids.getCurrentStateidIfNeeded(context, _args.oplayoutcommit.loca_stateid);
-
-        // will throw BAD_STATEID
-        NFS4State state = client.state(stateid);
-
-        // changing file size requires open for writing
-        int shareAccess = context.getStateHandler()
-                .getFileTracker()
-                .getShareAccess(client, inode, state.getOpenState().stateid());
-
-        if ((shareAccess & nfs4_prot.OPEN4_SHARE_ACCESS_WRITE) == 0) {
-            throw new BadLayoutException("Invalid open mode");
-        }
 
         _log.debug("LAYOUTCOMMIT: inode={} length={} offset={} loca_last_write_offset={}",
                 inode, _args.oplayoutcommit.loca_length.value,

core/src/test/java/org/dcache/nfs/v4/OperationLAYOUTCOMMITTest.java

@@ -7,6 +7,7 @@
 import org.dcache.nfs.v4.xdr.nfs_fh4;
 import org.dcache.nfs.vfs.Inode;
 import org.junit.Before;
+import org.junit.Ignore;
 import org.junit.Test;
 
 import org.dcache.nfs.v4.xdr.COMPOUND4args;
@@ -54,6 +55,7 @@ public void setUp() throws Exception {
     }
 
     @Test(expected = BadLayoutException.class)
+    @Ignore
     public void testCommitOnReadLayout() throws Exception {
 
         StateOwner stateOwner = client.getOrCreateOwner("client1".getBytes(StandardCharsets.UTF_8), new seqid4(0));