code coverage: jacoco script divided into: get & generate

Motivation:

	To also include pynfs tests to the code coverage we needed to separate the generate-jacoco-report.sh script functionality into two separate ones.
	To be able to set JaCoCo CLI first and then run pynfs tests.

Modifications:

	Added get-jacoco.sh, which checks existing cache for JaCoCo CLI and downloads it if not found.
	Deleted cache and download management of JaCoCo CLI from generate-jacoco-report.sh.
	Added a new job "Get JaCoCo CLI" to build.yml to run our new script get-jacoco.sh.
	Moved "Generate JaCoCo Report" and "Upload JaCoCo Report" jobs after pynfs tests in build.yml

Results:

	Pynfs test results are also included in the merged code coverage report.

Testing:

	Validated reports locally and in CI.

Acked-by:
Target: master
Require-book: no
Require-notes: no
Committed:

Author: chubnastia

.github/workflows/build.yml

@@ -30,16 +30,10 @@ jobs:
       - name: Build with Maven
         run: mvn --batch-mode --update-snapshots package
 
-      - name: Generate JaCoCo Report
+      - name: Get JaCoCo CLI
         run: |
-         chmod +x ./generate-jacoco-report.sh
-         ./generate-jacoco-report.sh
-
-      - name: Upload JaCoCo Report
-        uses: actions/upload-artifact@v4
-        with:
-            name: JaCoCo Coverage Report
-            path: target/coverage-reports/site
+         chmod +x ./get-jacoco.sh
+         ./get-jacoco.sh
 
       - name: JUnit test report
         uses: mikepenz/action-junit-report@v5
@@ -58,3 +52,14 @@ jobs:
         with:
           check_name: pynfs protocol compatibility test
           report_paths: "report/*.xml"
+
+      - name: Generate JaCoCo Report
+        run: |
+            chmod +x ./generate-jacoco-report.sh
+            ./generate-jacoco-report.sh
+
+      - name: Upload JaCoCo Report
+        uses: actions/upload-artifact@v4
+        with:
+          name: JaCoCo Coverage Report
+          path: target/coverage-reports/site

generate-jacoco-report.sh

@@ -11,29 +11,6 @@ REPORT_DIR="$PROJECT_ROOT/target/coverage-reports/site"
 # Ensure the report directory exists
 mkdir -p "$REPORT_DIR"
 
-# Debug: Print paths
-echo "DEBUG: JACOCO_CLI_JAR: $JACOCO_CLI_JAR"
-echo "DEBUG: Checking if $JACOCO_CLI_JAR exists..."
-
-# Check if JaCoCo CLI JAR exists in the cache directory
-if [ ! -f "$JACOCO_CLI_JAR" ]; then
-    echo "JaCoCo CLI JAR not found in cache directory. Downloading..."
-    mkdir -p "$JACOCO_DIR"
-    wget -q "https://github.com/jacoco/jacoco/releases/download/v$JACOCO_VERSION/jacoco-$JACOCO_VERSION.zip" -O "/tmp/jacoco-$JACOCO_VERSION.zip"
-    unzip -q "/tmp/jacoco-$JACOCO_VERSION.zip" -d "$JACOCO_DIR"
-    rm -f "/tmp/jacoco-$JACOCO_VERSION.zip"
-    echo "DEBUG: Downloaded JaCoCo CLI to $JACOCO_DIR"
-    ls -la "$JACOCO_DIR"
-else
-    echo "DEBUG: JaCoCo CLI JAR found at $JACOCO_CLI_JAR"
-fi
-
-# Check if JaCoCo CLI JAR exists after download
-if [ ! -f "$JACOCO_CLI_JAR" ]; then
-    echo "Error: JaCoCo CLI JAR not found at $JACOCO_CLI_JAR"
-    exit 1
-fi
-
 # Find all jacoco-ut.exec files dynamically
 EXEC_FILES=($(find "$PROJECT_ROOT" -name "jacoco-ut.exec" -type f))
 
@@ -71,7 +48,6 @@ for exec_file in "${EXEC_FILES[@]}"; do
     # Extract module path (e.g., core, dlm, rquota) from the exec file path
     module_path=$(dirname "$(dirname "$(dirname "$exec_file")")")
     module_name=$(basename "$module_path")
-
     # Add classfiles and sourcefiles arguments
     CLASSFILES_ARGS+=("--classfiles" "$module_path/target/classes")
     SOURCEFILES_ARGS+=("--sourcefiles" "$module_path/src/main/java")

get-jacoco.sh

@@ -0,0 +1,32 @@
+#!/bin/bash
+
+# Define paths
+PROJECT_ROOT="${PROJECT_ROOT:-$(pwd)}"
+JACOCO_VERSION="0.8.14"
+JACOCO_DIR="${PROJECT_ROOT}/jacoco-$JACOCO_VERSION"
+JACOCO_CLI_JAR="$JACOCO_DIR/lib/jacococli.jar"
+
+# Debug: Print paths
+echo "DEBUG: JACOCO_CLI_JAR: $JACOCO_CLI_JAR"
+echo "DEBUG: Checking if $JACOCO_CLI_JAR exists..."
+
+# Check if JaCoCo CLI JAR exists in the cache directory
+if [ ! -f "$JACOCO_CLI_JAR" ]; then
+    echo "JaCoCo CLI JAR not found in cache directory. Downloading..."
+    mkdir -p "$JACOCO_DIR"
+    wget -q "https://github.com/jacoco/jacoco/releases/download/v$JACOCO_VERSION/jacoco-$JACOCO_VERSION.zip" -O "/tmp/jacoco-$JACOCO_VERSION.zip"
+    unzip -q "/tmp/jacoco-$JACOCO_VERSION.zip" -d "$JACOCO_DIR"
+    rm -f "/tmp/jacoco-$JACOCO_VERSION.zip"
+    echo "DEBUG: Downloaded JaCoCo CLI to $JACOCO_DIR"
+    ls -la "$JACOCO_DIR"
+else
+    echo "DEBUG: JaCoCo CLI JAR found at $JACOCO_CLI_JAR"
+fi
+
+# Check if JaCoCo CLI JAR exists after download
+if [ ! -f "$JACOCO_CLI_JAR" ]; then
+    echo "Error: JaCoCo CLI JAR not found at $JACOCO_CLI_JAR"
+    exit 1
+fi
+
+export JACOCO_CLI_JAR