core: Opaque: remove deprecated methods

This make Opaque completely immutable.

Related: #149
Signed-off-by: Christian Kohlschütter <[email protected]>

Author: kohlschuetter

core/src/main/java/org/dcache/nfs/util/Opaque.java

@@ -39,16 +39,10 @@ public static Opaque forBytes(byte[] bytes) {
         return new Opaque(bytes.clone());
     }
 
-    @Deprecated(forRemoval = true)
-    public Opaque(byte[] opaque) {
+    private Opaque(byte[] opaque) {
         _opaque = opaque;
     }
 
-    @Deprecated(forRemoval = true)
-    public byte[] getOpaque() {
-        return _opaque;
-    }
-
     public byte[] asBytes() {
         return _opaque.clone();
     }

core/src/main/java/org/dcache/nfs/v4/FileTracker.java

@@ -565,7 +565,7 @@ void removeOpen(Inode inode, stateid4 stateid) {
     public Map<Inode, Collection<NFS4Client>> getOpenFiles() {
         return files.entrySet().stream()
                 .collect(Collectors.toMap(
-                        e -> Inode.forFile(e.getKey().getOpaque()),
+                        e -> Inode.forFile(e.getKey().asBytes()),
                         e -> e.getValue().stream().map(OpenState::getClient).collect(Collectors.toSet())));
     }
 
@@ -578,7 +578,7 @@ public Map<Inode, Collection<NFS4Client>> getOpenFiles() {
     public Map<Inode, Collection<NFS4Client>> getDelegations() {
         return delegations.entrySet().stream()
                 .collect(Collectors.toMap(
-                        e -> Inode.forFile(e.getKey().getOpaque()),
+                        e -> Inode.forFile(e.getKey().asBytes()),
                         e -> e.getValue().stream().map(DelegationState::client).collect(Collectors.toSet())));
     }
 }