core: Remove Stat.hasIno again

as per reviewer request (#153)

Signed-off-by: Christian Kohlschütter <[email protected]>

Author: kohlschuetter

core/src/main/java/org/dcache/nfs/v4/OperationGETATTR.java

@@ -255,7 +255,7 @@ static Optional<? extends XdrAble> fattr2xdr(int fattr, VirtualFileSystem fs, In
             case nfs4_prot.FATTR4_CHOWN_RESTRICTED:
                 return Optional.empty();
             case nfs4_prot.FATTR4_FILEID:
-                if (stat.hasIno()) {
+                if (stat.isDefined(StatAttribute.INO)) {
                     return Optional.of(new fattr4_fileid(stat.getIno()));
                 } else {
                     return Optional.empty();
@@ -354,7 +354,7 @@ static Optional<? extends XdrAble> fattr2xdr(int fattr, VirtualFileSystem fs, In
                  * TODO!!!:
                  */
 
-                if (!stat.hasIno()) {
+                if (!stat.isDefined(StatAttribute.INO)) {
                     return Optional.empty();
                 }
                 long mofi = stat.getIno();

core/src/main/java/org/dcache/nfs/vfs/Stat.java

@@ -153,15 +153,6 @@ public void setDev(int dev) {
         _dev = dev;
     }
 
-    /**
-     * Checks if an inode number has been set (even if 0).
-     *
-     * @return {@code true} if set.
-     */
-    public boolean hasIno() {
-        return isDefined(StatAttribute.INO);
-    }
-
     /**
      * Returns file inode number.
      */

core/src/test/java/org/dcache/nfs/vfs/StatTest.java

@@ -9,6 +9,7 @@
 import java.text.SimpleDateFormat;
 import java.util.Calendar;
 
+import org.dcache.nfs.vfs.Stat.StatAttribute;
 import org.junit.Assert;
 import org.junit.Test;
 
@@ -168,9 +169,9 @@ public void testNotDefinedGetBtime() {
     @Test
     public void testGetIno() {
         Stat stat = new Stat();
-        assertFalse(stat.hasIno());
+        assertFalse(stat.isDefined(StatAttribute.INO));
         stat.setIno(1);
-        assertTrue(stat.hasIno());
+        assertTrue(stat.isDefined(StatAttribute.INO));
         assertEquals(1, stat.getIno());
 
     }