basic-server: Allow for the creation of files from the outside

list() would currently fail when retrieving files in a directory that
weren't previously mapped to an Inode.

Check if the Path exists, and only throw a NoEntException if it doesn't.
In all other cases create and map a new Inode to the path.

Also handle an edge-case where a path was briefly visible but deleted
right away during list().

Related: #149
Signed-off-by: Christian Kohlschütter <[email protected]>

Author: kohlschuetter

basic-server/src/main/java/org/dcache/nfs4j/server/LocalFileSystem.java

@@ -97,7 +97,11 @@ private Path resolveInode(Inode inodeNumber) throws NoEntException {
     private Inode resolvePath(Path path) throws NoEntException {
         Inode inodeNumber = pathToInode.get(path);
         if (inodeNumber == null) {
-            throw new NoEntException("path " + path);
+            if (!Files.exists(path)) {
+                throw new NoEntException("path " + path);
+            }
+            inodeNumber = newInode();
+            map(inodeNumber, path);
         }
         return inodeNumber;
     }
@@ -281,7 +285,13 @@ public DirectoryStream list(Inode inode, byte[] bytes, long l) throws IOExceptio
             for (Path p : ds) {
                 cookie++;
                 if (cookie > l) {
-                    Inode ino = resolvePath(p);
+                    Inode ino;
+                    try {
+                        ino = resolvePath(p);
+                    } catch (NoEntException e) {
+                        // File was briefly available, but deleted before we could allocate an inode
+                        continue;
+                    }
                     list.add(new DirectoryEntry(p.getFileName().toString(), ino, statPath(p, ino), cookie));
                 }
             }