core: Opaque: Remove position offset from ByteBuffer constructor

Removing the relative offset (which in our case is always 0) will reduce
the chance that somebody thinks it's an absolute offset from the
beginning of the ByteBuffer...

Related: #149
Signed-off-by: Christian Kohlschütter <[email protected]>

Author: kohlschuetter

core/src/main/java/org/dcache/nfs/util/Opaque.java

@@ -39,17 +39,15 @@ public static Opaque forBytes(byte[] bytes) {
     }
 
     /**
-     * Returns an {@link Opaque} instance based on a copy of the {@code length} bytes from the given {@link ByteBuffer}
-     * starting from the current {@link ByteBuffer#position()} plus the given {@code offset}.
+     * Returns an {@link Opaque} instance based on a copy of the {@code length} bytes from the given {@link ByteBuffer}.
      * 
      * @param buf The buffer.
-     * @param offset The offset (relative to the current position).
      * @param length The number of bytes.
      * @return The {@link Opaque} instance.
      */
-    public static Opaque forBytes(ByteBuffer buf, int offset, int length) {
+    public static Opaque forBytes(ByteBuffer buf, int length) {
         byte[] bytes = new byte[length];
-        buf.get(bytes, offset, length);
+        buf.get(bytes);
 
         return new OpaqueImpl(bytes);
     }

core/src/main/java/org/dcache/nfs/vfs/Inode.java

@@ -109,7 +109,7 @@ public Inode(byte[] bytes) {
         exportIdx = b.getInt();
         type = (int) b.get();
         int olen = (int) b.get();
-        this.opaqueKey = Opaque.forBytes(b, 0, olen);
+        this.opaqueKey = Opaque.forBytes(b, olen);
 
         this.nfsHandle = bytes.clone();
     }