Skip to content

Commit 283675b

Browse files
te6-inclaude
andauthored
fix(rootage): add missing strokeWidth and rename stroke to strokeColor in chip-tab (#1256)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 3b19a4a commit 283675b

File tree

7 files changed

+27
-9
lines changed

7 files changed

+27
-9
lines changed

docs/public/rootage/components/chip-tab.json

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,11 @@
3232
"color": {
3333
"type": "color"
3434
},
35-
"stroke": {
35+
"strokeColor": {
3636
"type": "color"
37+
},
38+
"strokeWidth": {
39+
"type": "dimension"
3740
}
3841
}
3942
},
@@ -293,9 +296,16 @@
293296
"type": "color",
294297
"value": "$color.bg.transparent"
295298
},
296-
"stroke": {
299+
"strokeColor": {
297300
"type": "color",
298301
"value": "$color.stroke.neutral-muted"
302+
},
303+
"strokeWidth": {
304+
"type": "dimension",
305+
"value": {
306+
"value": 1,
307+
"unit": "px"
308+
}
299309
}
300310
},
301311
"label": {

packages/css/vars/component/chip-tab.d.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ export declare const vars: {
7979
"enabled": {
8080
"root": {
8181
"color": "var(--seed-color-bg-transparent)",
82-
"stroke": "var(--seed-color-stroke-neutral-muted)"
82+
"strokeColor": "var(--seed-color-stroke-neutral-muted)",
83+
"strokeWidth": "1px"
8384
},
8485
"label": {
8586
"color": "var(--seed-color-fg-neutral)"

packages/css/vars/component/chip-tab.mjs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ export const vars = {
7979
"enabled": {
8080
"root": {
8181
"color": "var(--seed-color-bg-transparent)",
82-
"stroke": "var(--seed-color-stroke-neutral-muted)"
82+
"strokeColor": "var(--seed-color-stroke-neutral-muted)",
83+
"strokeWidth": "1px"
8384
},
8485
"label": {
8586
"color": "var(--seed-color-fg-neutral)"

packages/qvism-preset/src/recipes/chip-tabs.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,8 @@ const chipTabs = defineSlotRecipe({
128128
neutralOutline: {
129129
trigger: {
130130
backgroundColor: triggerVars.variantNeutralOutline.enabled.root.color,
131-
border: `1px solid ${triggerVars.variantNeutralOutline.enabled.root.stroke}`,
131+
// TODO: replace 1px with triggerVars.variantNeutralOutline.enabled.root.strokeWidth
132+
border: `1px solid ${triggerVars.variantNeutralOutline.enabled.root.strokeColor}`,
132133

133134
color: triggerVars.variantNeutralOutline.enabled.label.color,
134135

packages/qvism-preset/src/vars/component/chip-tab.d.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ export declare const vars: {
7979
"enabled": {
8080
"root": {
8181
"color": "var(--seed-color-bg-transparent)",
82-
"stroke": "var(--seed-color-stroke-neutral-muted)"
82+
"strokeColor": "var(--seed-color-stroke-neutral-muted)",
83+
"strokeWidth": "1px"
8384
},
8485
"label": {
8586
"color": "var(--seed-color-fg-neutral)"

packages/qvism-preset/src/vars/component/chip-tab.mjs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ export const vars = {
7979
"enabled": {
8080
"root": {
8181
"color": "var(--seed-color-bg-transparent)",
82-
"stroke": "var(--seed-color-stroke-neutral-muted)"
82+
"strokeColor": "var(--seed-color-stroke-neutral-muted)",
83+
"strokeWidth": "1px"
8384
},
8485
"label": {
8586
"color": "var(--seed-color-fg-neutral)"

packages/rootage/components/chip-tab.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,10 @@ data:
2222
type: dimension
2323
color:
2424
type: color
25-
stroke:
25+
strokeColor:
2626
type: color
27+
strokeWidth:
28+
type: dimension
2729
label:
2830
properties:
2931
fontSize:
@@ -85,7 +87,8 @@ data:
8587
enabled:
8688
root:
8789
color: $color.bg.transparent
88-
stroke: $color.stroke.neutral-muted
90+
strokeColor: $color.stroke.neutral-muted
91+
strokeWidth: 1px
8992
label:
9093
color: $color.fg.neutral
9194
enabled,pressed:

0 commit comments

Comments
 (0)