Skip to content

Commit 3afcada

Browse files
committed
feat(bottom-sheet): add paddingX property for improved layout consistency
1 parent 8e55bea commit 3afcada

File tree

10 files changed

+21
-38
lines changed

10 files changed

+21
-38
lines changed

docs/public/rootage/components/bottom-sheet.json

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,10 @@
300300
"fontWeight": {
301301
"type": "number",
302302
"value": "$font-weight.regular"
303+
},
304+
"paddingX": {
305+
"type": "dimension",
306+
"value": "$dimension.spacing-x.global-gutter"
303307
}
304308
},
305309
"closeButton": {
@@ -383,12 +387,6 @@
383387
"type": "dimension",
384388
"value": "$dimension.spacing-x.global-gutter"
385389
}
386-
},
387-
"description": {
388-
"paddingX": {
389-
"type": "dimension",
390-
"value": "$dimension.spacing-x.global-gutter"
391-
}
392390
}
393391
}
394392
}

packages/css/all.css

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2733,6 +2733,8 @@
27332733
font-size: var(--seed-font-size-t5);
27342734
line-height: var(--seed-line-height-t5);
27352735
font-weight: var(--seed-font-weight-regular);
2736+
padding-left: var(--seed-dimension-spacing-x-global-gutter);
2737+
padding-right: var(--seed-dimension-spacing-x-global-gutter);
27362738
white-space: pre-wrap;
27372739
margin: 0;
27382740
}
@@ -2815,11 +2817,6 @@
28152817
padding-right: 60px;
28162818
}
28172819

2818-
.seed-bottom-sheet__description--headerAlign_center {
2819-
padding-left: var(--seed-dimension-spacing-x-global-gutter);
2820-
padding-right: var(--seed-dimension-spacing-x-global-gutter);
2821-
}
2822-
28232820
.seed-bottom-sheet__backdrop--skipAnimation_false:is([data-state="open"], [data-open])[data-snap-points="false"]:not([data-animation-done="true"]) {
28242821
animation-name: fade-in;
28252822
animation-duration: var(--seed-duration-d6);

packages/css/all.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/css/recipes/bottom-sheet.css

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@
8181
font-size: var(--seed-font-size-t5);
8282
line-height: var(--seed-line-height-t5);
8383
font-weight: var(--seed-font-weight-regular);
84+
padding-left: var(--seed-dimension-spacing-x-global-gutter);
85+
padding-right: var(--seed-dimension-spacing-x-global-gutter);
8486
margin: 0;
8587
white-space: pre-wrap;
8688
}
@@ -155,10 +157,6 @@
155157
padding-left: 60px;
156158
padding-right: 60px;
157159
}
158-
.seed-bottom-sheet__description--headerAlign_center {
159-
padding-left: var(--seed-dimension-spacing-x-global-gutter);
160-
padding-right: var(--seed-dimension-spacing-x-global-gutter);
161-
}
162160
.seed-bottom-sheet__backdrop--skipAnimation_false:is([data-state="open"], [data-open])[data-snap-points='false']:not([data-animation-done='true']) {
163161
animation-name: fade-in;
164162
animation-duration: var(--seed-duration-d6);

packages/css/vars/component/bottom-sheet.d.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ export declare const vars: {
4242
"color": "var(--seed-color-fg-neutral-muted)",
4343
"fontSize": "var(--seed-font-size-t5)",
4444
"lineHeight": "var(--seed-line-height-t5)",
45-
"fontWeight": "var(--seed-font-weight-regular)"
45+
"fontWeight": "var(--seed-font-weight-regular)",
46+
"paddingX": "var(--seed-dimension-spacing-x-global-gutter)"
4647
},
4748
"closeButton": {
4849
"fromTop": "var(--seed-dimension-x6)",
@@ -70,9 +71,6 @@ export declare const vars: {
7071
"title": {
7172
"paddingLeft": "var(--seed-dimension-spacing-x-global-gutter)",
7273
"paddingRight": "var(--seed-dimension-spacing-x-global-gutter)"
73-
},
74-
"description": {
75-
"paddingX": "var(--seed-dimension-spacing-x-global-gutter)"
7674
}
7775
}
7876
},

packages/css/vars/component/bottom-sheet.mjs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ export const vars = {
4242
"color": "var(--seed-color-fg-neutral-muted)",
4343
"fontSize": "var(--seed-font-size-t5)",
4444
"lineHeight": "var(--seed-line-height-t5)",
45-
"fontWeight": "var(--seed-font-weight-regular)"
45+
"fontWeight": "var(--seed-font-weight-regular)",
46+
"paddingX": "var(--seed-dimension-spacing-x-global-gutter)"
4647
},
4748
"closeButton": {
4849
"fromTop": "var(--seed-dimension-x6)",
@@ -70,9 +71,6 @@ export const vars = {
7071
"title": {
7172
"paddingLeft": "var(--seed-dimension-spacing-x-global-gutter)",
7273
"paddingRight": "var(--seed-dimension-spacing-x-global-gutter)"
73-
},
74-
"description": {
75-
"paddingX": "var(--seed-dimension-spacing-x-global-gutter)"
7674
}
7775
}
7876
},

packages/qvism-preset/src/recipes/bottom-sheet.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,9 @@ const bottomSheet = defineSlotRecipe({
119119
lineHeight: vars.base.enabled.description.lineHeight,
120120
fontWeight: vars.base.enabled.description.fontWeight,
121121

122+
paddingLeft: vars.base.enabled.description.paddingX,
123+
paddingRight: vars.base.enabled.description.paddingX,
124+
122125
margin: 0,
123126
whiteSpace: "pre-wrap",
124127
},
@@ -207,10 +210,6 @@ const bottomSheet = defineSlotRecipe({
207210
paddingRight: vars.headerAlignmentCenterCloseButtonTrue.enabled.title.paddingRight,
208211
},
209212
},
210-
description: {
211-
paddingLeft: vars.headerAlignmentCenter.enabled.description.paddingX,
212-
paddingRight: vars.headerAlignmentCenter.enabled.description.paddingX,
213-
},
214213
},
215214
},
216215
skipAnimation: {

packages/qvism-preset/src/vars/component/bottom-sheet.d.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ export declare const vars: {
4242
"color": "var(--seed-color-fg-neutral-muted)",
4343
"fontSize": "var(--seed-font-size-t5)",
4444
"lineHeight": "var(--seed-line-height-t5)",
45-
"fontWeight": "var(--seed-font-weight-regular)"
45+
"fontWeight": "var(--seed-font-weight-regular)",
46+
"paddingX": "var(--seed-dimension-spacing-x-global-gutter)"
4647
},
4748
"closeButton": {
4849
"fromTop": "var(--seed-dimension-x6)",
@@ -70,9 +71,6 @@ export declare const vars: {
7071
"title": {
7172
"paddingLeft": "var(--seed-dimension-spacing-x-global-gutter)",
7273
"paddingRight": "var(--seed-dimension-spacing-x-global-gutter)"
73-
},
74-
"description": {
75-
"paddingX": "var(--seed-dimension-spacing-x-global-gutter)"
7674
}
7775
}
7876
},

packages/qvism-preset/src/vars/component/bottom-sheet.mjs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ export const vars = {
4242
"color": "var(--seed-color-fg-neutral-muted)",
4343
"fontSize": "var(--seed-font-size-t5)",
4444
"lineHeight": "var(--seed-line-height-t5)",
45-
"fontWeight": "var(--seed-font-weight-regular)"
45+
"fontWeight": "var(--seed-font-weight-regular)",
46+
"paddingX": "var(--seed-dimension-spacing-x-global-gutter)"
4647
},
4748
"closeButton": {
4849
"fromTop": "var(--seed-dimension-x6)",
@@ -70,9 +71,6 @@ export const vars = {
7071
"title": {
7172
"paddingLeft": "var(--seed-dimension-spacing-x-global-gutter)",
7273
"paddingRight": "var(--seed-dimension-spacing-x-global-gutter)"
73-
},
74-
"description": {
75-
"paddingX": "var(--seed-dimension-spacing-x-global-gutter)"
7674
}
7775
}
7876
},

packages/rootage/components/bottom-sheet.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ data:
130130
fontSize: $font-size.t5
131131
lineHeight: $line-height.t5
132132
fontWeight: $font-weight.regular
133+
paddingX: $dimension.spacing-x.global-gutter
133134
closeButton:
134135
fromTop: $dimension.x6
135136
fromRight: $dimension.x4
@@ -147,8 +148,6 @@ data:
147148
title:
148149
paddingLeft: $dimension.spacing-x.global-gutter
149150
paddingRight: $dimension.spacing-x.global-gutter
150-
description:
151-
paddingX: $dimension.spacing-x.global-gutter
152151
headerAlignment=center,closeButton=true:
153152
enabled:
154153
title:

0 commit comments

Comments
 (0)