feat(config, react): Remove first class data loader cache (#661)

Co-authored-by: anakin_karrot <anakin@daangn.com>

Author: ENvironmentSet

.changeset/real-cats-rest.md

@@ -0,0 +1,6 @@
+---
+"@stackflow/react": major
+"@stackflow/config": major
+---
+
+Remove data loader cache

config/src/ActivityLoader.ts

@@ -1,19 +1,12 @@
 import type { ActivityLoaderArgs } from "./ActivityLoaderArgs";
 import type { RegisteredActivityName } from "./RegisteredActivityName";
 
-export type ActivityLoader<ActivityName extends RegisteredActivityName> = {
-  (args: ActivityLoaderArgs<ActivityName>): any;
-  loaderCacheMaxAge?: number;
-};
+export type ActivityLoader<ActivityName extends RegisteredActivityName> = (
+  args: ActivityLoaderArgs<ActivityName>,
+) => any;
 
 export function loader<ActivityName extends RegisteredActivityName>(
   loaderFn: (args: ActivityLoaderArgs<ActivityName>) => any,
-  options?: {
-    loaderCacheMaxAge?: number;
-  },
 ): ActivityLoader<ActivityName> {
-  return Object.assign(
-    (args: ActivityLoaderArgs<ActivityName>) => loaderFn(args),
-    options,
-  );
+  return (args: ActivityLoaderArgs<ActivityName>) => loaderFn(args);
 }

integrations/react/src/future/stackflow.tsx

@@ -50,8 +50,6 @@ export type StackflowOutput = {
   stepActions: StepActions<ActivityBaseParams>;
 };
 
-const DEFAULT_LOADER_CACHE_MAX_AGE = 1000 * 30;
-
 export function stackflow<
   T extends ActivityDefinition<RegisteredActivityName>,
   R extends {
@@ -60,17 +58,7 @@ export function stackflow<
     >;
   },
 >(input: StackflowInput<T, R>): StackflowOutput {
-  const loaderDataCacheMap = new Map<string, { params: {}; data: unknown }[]>();
   const loadData = (activityName: string, activityParams: {}) => {
-    const cache = loaderDataCacheMap.get(activityName);
-    const cacheEntry = cache?.find((entry) =>
-      isEqual(entry.params, activityParams),
-    );
-
-    if (cacheEntry) {
-      return cacheEntry.data;
-    }
-
     const activityConfig = input.config.activities.find(
       (activity) => activity.name === activityName,
     );
@@ -83,40 +71,6 @@ export function stackflow<
       params: activityParams,
       config: input.config,
     });
-    const newCacheEntry = {
-      params: activityParams,
-      data: loaderData,
-    };
-
-    if (cache) {
-      cache.push(newCacheEntry);
-    } else {
-      loaderDataCacheMap.set(activityName, [newCacheEntry]);
-    }
-
-    const clearCache = () => {
-      const cache = loaderDataCacheMap.get(activityName);
-
-      if (!cache) return;
-
-      loaderDataCacheMap.set(
-        activityName,
-        cache.filter((entry) => entry !== newCacheEntry),
-      );
-    };
-    const clearCacheAfterMaxAge = () => {
-      setTimeout(
-        clearCache,
-        activityConfig.loader?.loaderCacheMaxAge ??
-          DEFAULT_LOADER_CACHE_MAX_AGE,
-      );
-    };
-
-    Promise.resolve(loaderData).then(clearCacheAfterMaxAge, (error) => {
-      clearCache();
-
-      throw error;
-    });
 
     return loaderData;
   };