removed run_in_executor

Author: dabeaz

CHANGES

@@ -10,6 +10,10 @@ may have moved code there.  Many features of Curio were simply
 higher-level modules implemented on top of an existing core and can be
 added back to your code without much effort. -- Dave
 
+04/10/2024 Removed run_in_executor().  If you want to wait on work
+           submitted to a traditional executor (from concurrent.futures),
+	   use curio.traps._future_wait().
+	   
 04/10/2024 Removed subprocess module.  Use the Python built-in instead.
            Old code found in examples/curio_subprocess.py
 

curio/workers.py

@@ -4,7 +4,7 @@
 # running functions in threads, processes, and executors from the
 # concurrent.futures module.
 
-__all__ = ['run_in_executor', 'run_in_thread', 'run_in_process', 'block_in_thread']
+__all__ = ['run_in_thread', 'run_in_process', 'block_in_thread']
 
 # -- Standard Library
 
@@ -52,23 +52,6 @@ def rebuild_exc(exc, tb):
     exc.__cause__ = RemoteTraceback(tb)
     return exc
 
-async def run_in_executor(exc, callable, *args):
-    '''
-    Run callable(*args) in an executor such as
-    ThreadPoolExecutor or ProcessPoolExecutor from the
-    concurrent.futures module.  Be aware that on cancellation, any
-    worker thread or process that was handling the request will
-    continue to run to completion as a kind of zombie-- possibly
-    rendering the executor unusable for subsequent work.
-
-    This function is provided for compatibility with
-    concurrent.futures, but is not the recommend approach for running
-    blocking or cpu-bound work in curio. Use the run_in_thread() or
-    run_in_process() methods instead.
-    '''
-    future = exc.submit(callable, *args)
-    await _future_wait(future)
-    return future.result()
 
 MAX_WORKER_THREADS = 64
 

tests/test_workers.py

@@ -75,14 +75,6 @@ async def main():
         'sleep done',
     ]
 
-def test_executor(kernel):
-    from concurrent.futures import ThreadPoolExecutor
-    pool = ThreadPoolExecutor()
-    async def main():
-        r = await run_in_executor(pool, fib, 1)
-        assert r == 1
-    kernel.run(main())
-
 @pytest.mark.parametrize('runner', [run_in_thread, run_in_process ])
 def test_worker_cancel(kernel, runner):
     results = []