refactor: code cleanup

Author: serapieTuyishime

public/locales/bg/common.json

@@ -206,7 +206,7 @@
   "course.scoreboard.button": "Load more",
   "learning-module.material.open.lesson": "Open Lesson",
   "learning-module.material.open.article": "Open Article",
-  "learning-module.course.other.appearances": "Cambiar се появява в",
+  "learning-module.course.other.appearances": "Също се появява в:",
   "partnering.card.text": "To arrange a meeting, just drop us a line.",
   "communities.navigation.all": "All communities",
   "testimonials.community.title": "Join our community",

public/locales/en/common.json

@@ -210,7 +210,7 @@
   "course.scoreboard.button": "Load more",
   "learning-module.material.open.lesson": "Open Lesson",
   "learning-module.material.open.article": "Open Article",
-  "learning-module.course.other.appearances": "Also appears in",
+  "learning-module.course.other.appearances": "Also appears in:",
   "partnering.card.text": "To arrange a meeting, just drop us a line.",
   "communities.navigation.all": "All communities",
   "testimonials.community.title": "Join our community",

public/locales/es/common.json

@@ -208,7 +208,7 @@
   "course.scoreboard.button": "Cargar más",
   "learning-module.material.open.lesson": "Abrir lección",
   "learning-module.material.open.article": "Abrir artículo",
-  "learning-module.course.other.appearances": "También aparece en",
+  "learning-module.course.other.appearances": "También aparece en:",
   "partnering.card.text": "Para concertar un encuentro, diríjase a nosotros.",
   "communities.navigation.all": "Todas las comunidades",
   "testimonials.community.title": "Únase a nuestra comunidad",

public/locales/hr/common.json

@@ -206,7 +206,7 @@
   "course.scoreboard.button": "Load more",
   "learning-module.material.open.lesson": "Open Lesson",
   "learning-module.material.open.article": "Otvori članak",
-  "learning-module.course.other.appearances": "Također se pojavljuje u",
+  "learning-module.course.other.appearances": "Također se pojavljuje u:",
   "partnering.card.text": "To arrange a meeting, just drop us a line.",
   "communities.navigation.all": "All communities",
   "testimonials.community.title": "Join our community",

src/components/cards/LearningModule.tsx

@@ -1,4 +1,4 @@
-import { useEffect, useState } from "react";
+import { Fragment, useEffect, useState } from "react";
 import ArrowButton from "@/components/ui/button/Arrow";
 import Link from "next/link";
 import { useTranslation } from "next-i18next";
@@ -28,9 +28,9 @@ export function LearningModuleCard({ data }: { data: LearningModule }): JSX.Elem
     if (!challenge?.level) return
     if (challenge.level === 0 || challenge.level === 1) return setLevel("course.challenge.level-0");
     return setLevel("course.challenge.level-2");
-  }, [challenge.level]);
+  }, [challenge?.level]);
 
-  const courses = data?.courses.map(course => course.name)
+  const courses = data?.courses.map(course => ({ name: course.name, slug: course.slug }))
 
   return (
     <div className="flex flex-col content-start w-full p-8 rounded-3xl group text-gray-700 border-solid border border-gray-200 gap-8">
@@ -50,10 +50,25 @@ export function LearningModuleCard({ data }: { data: LearningModule }): JSX.Elem
         <div className="text-sm font-normal text-gray-700 max-w-xxs">{data.description}</div>
       </div>
 
-      {courses.length ? <p className="font-medium text-gray text-tertiary text-sm">{t('learning-module.course.other.appearances')}: {courses.map((course, index) => <Link href={`/communities/${community.slug}/challenges/${challenge?.id}/learning-modules/${data.id}`} key={`other-appearance-counse-${index}`} className="underline ml-1">{course}{index !== courses.length - 1 && ","} </Link>)} </p> : <></>}
+      {courses.length ?
+        <p className="font-medium text-gray text-tertiary text-sm">
+          {t('learning-module.course.other.appearances')}
+          {courses.map((course, index) =>
+            <Fragment key={`related-course-${index}`}>
+              <Link
+                key={`other-appearance-course-${index}`}
+                href={`/communities/${community.slug}/courses/${course?.slug}`}
+                className="hover:underline ml-1">{course.name}
+              </Link>
+              {index !== courses.length - 1 && ","}
+            </Fragment>
+          )}
+        </p>
+        :
+        <></>}
 
       <div className="w-full mb-0 justify-self-end">
-        <Link href={"#"}>
+        <Link href={`/communities/${community.slug}/challenges/${challenge?.id}/learning-modules/${data.id}`}>
           <ArrowButton communityStyles={true} variant="outline-primary">
             Start now
           </ArrowButton>

src/components/sections/challenges/Learning.tsx

@@ -1,7 +1,7 @@
-import React from "react";
 import Accordion from "@/components/ui/accordion/Accordion";
 import Section from "@/components/sections/communities/_partials/Section";
-import LearningCard from "@/components/cards/challenge/_partials/Learning"; import { LearningModuleCard } from "@/components/cards/LearningModule";
+import LearningCard from "@/components/cards/challenge/_partials/Learning";
+import { LearningModuleCard } from "@/components/cards/LearningModule";
 import { Course, LearningModule } from "@/types/course";
 import { Community } from "@/types/community";
 import { useTranslation } from "next-i18next";
@@ -37,7 +37,6 @@ export default function Learning({ courses, learningModules, community }: { cour
                 <LearningModuleCard
                   key={`related-learning-card-${learning.id}`}
                   data={learning}
-                // path={`/communities/${community.slug}/challenges/${challenge?.id}/learning-modules/${learning.id}`}
                 />
               ))}
             </div>

src/components/ui/Duration.tsx

@@ -10,6 +10,7 @@ export const DurationCard = ({ value, type = "gray" }: { value: number, type?: s
             if (!value) {
                 return 0;
             }
+            if (Number(value) !== value) return value
             return DateManager.humanize(value, router.locale as string);
         };
     }, [router.locale]);