fix: metadata rendering type bug

musayann · musayann · commit 6944c578e920 · 2024-06-20T16:45:56.000+02:00
diff --git a/src/components/ui/MetaData.tsx b/src/components/ui/MetaData.tsx
@@ -1,5 +1,5 @@
 import { getMetadataDescription } from "@/utilities/Metadata";
-import { ReactElement } from "react";
+import { ReactElement, useMemo } from "react";
 
 /**
  * Meta tags component
@@ -8,13 +8,13 @@ import { ReactElement } from "react";
  * @export
  * @returns {ReactElement}
  */
-export default function MetaData({ description, testId = "meta-id" }: { description: string; testId?: string }): ReactElement {
-  const metas = getMetadataDescription(description);
+export default function MetaData({ description, testId = "meta-id" }: { description?: string; testId?: string }): ReactElement {
+  const metas = useMemo(() => getMetadataDescription(description), [description]);
   return (
-    <div data-testid={testId}>
+    <>
       {metas.map((meta, index) => (
-        <meta key={`meta-${index}`} content={meta.content} name={meta.name} />
+        <meta data-testid={testId} key={`meta-${index}`} content={meta.content} name={meta.name} />
       ))}
-    </div>
+    </>
   );
 }
diff --git a/src/pages/communities/[slug]/challenges/[challenge_id]/submissions/index.tsx b/src/pages/communities/[slug]/challenges/[challenge_id]/submissions/index.tsx
@@ -3,7 +3,7 @@ import SubmissionPopup from "@/components/popups/submission";
 import Header from "@/components/sections/communities/_partials/Header";
 import Wrapper from "@/components/sections/courses/Wrapper";
 import SubmissionList from "@/components/sections/submissions/List";
-// import MetaData from "@/components/ui/MetaData";
+import MetaData from "@/components/ui/MetaData";
 import useSubmissionNavigation from "@/hooks/useSubmissionNavigation";
 import { wrapper } from "@/store";
 import { fetchAllSubmission, fetchChallenge } from "@/store/services/communities/challenges";
@@ -28,10 +28,6 @@ import { ReactElement, useMemo } from "react";
  */
 export default function Submission(props: { pageProps: { currentCommunity: Community; submissions: SubmissionType[]; challenge: Challenge } }) {
   const { challenge } = props.pageProps;
-  // const { selectedSubmission, submissions } = useMultiSelector<unknown, { selectedSubmission: SubmissionType; submissions: SubmissionType[] }>({
-  //   selectedSubmission: (state: IRootState) => state.submissions.current,
-  //   submissions: (state: IRootState) => state.submissions.list,
-  // });
 
   const { submissions, selectedSubmission, handleCloseSubmission, showPopup} = useSubmissionNavigation();
 
@@ -45,7 +41,7 @@ export default function Submission(props: { pageProps: { currentCommunity: Commu
     <>
       <Head>
         <title>{`${t("communities.submission.title")} ${challenge?.name}`}</title>
-        {/* <MetaData description={challenge?.description as string} /> */}
+        <MetaData description={challenge?.description} />
       </Head>
       <Wrapper paths={headerPaths}>
         <div className="flex flex-col py-4 space-y-8 text-gray-700">
diff --git a/src/utilities/Metadata.ts b/src/utilities/Metadata.ts
@@ -32,7 +32,7 @@ export const getMetadataTitle = (...args: string[]): string => {
  * @returns {MetadataDescription[]}
  */
 
-export const getMetadataDescription = (description: string): MetadataDescription[] => {
+export const getMetadataDescription = (description?: string): MetadataDescription[] => {
   if (!description) return [];
   return [
     {

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ export const getMetadataTitle = (...args: string[]): string => {`
`32`	`32`	`* @returns {MetadataDescription[]}`
`33`	`33`	`*/`
`34`	`34`
`35`		`-export const getMetadataDescription = (description: string): MetadataDescription[] => {`
	`35`	`+export const getMetadataDescription = (description?: string): MetadataDescription[] => {`
`36`	`36`	`if (!description) return [];`
`37`	`37`	`return [`
`38`	`38`	`{`