Skip to content

Commit b599a0d

Browse files
authored
Merge pull request #1293 from dacadeorg/fix/challenge-card-spacing
Fix: update challenge card spacing
2 parents 97f0cba + db4e46c commit b599a0d

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/components/cards/challenge/Challenge.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export default function ChallengeCard({ data, community, isCourseEnd }: Challeng
3535
return (
3636
<div className="w-full flex flex-col sm:flex-row md:flex-col lg:flex-row border-solid border border-primary bg-secondary rounded-3xl group text-secondary">
3737
<div className="border-solid border -m-px border-primary bg-primary rounded-3xl sm:p-8 sm:pb-6 p-6 sm:w-2/3 md:w-auto lg:w-2/3">
38-
<div className="flex flex-col mb-1">
38+
<div className="flex flex-col mb-1 justify-between h-full">
3939
<div className="lg:pr-20">
4040
{expiresAt && (
4141
<div className="text-tertiary text-sm font-normal mb-4.5 md:mb-6">
@@ -45,12 +45,13 @@ export default function ChallengeCard({ data, community, isCourseEnd }: Challeng
4545
)}
4646
<div className="text-lg text-primary font-medium leading-4.95 mb-3">{data.name}</div>
4747
<Badges challenge={data} />
48-
<div className="text-base text-secondary -tracking-1">{data.description}</div>
48+
<div className="text-base text-secondary -tracking-1 mt-6">{data.description}</div>
4949
</div>
5050
<div className="divide-y-2 divide-gray-200 divide-dotted flex flex-col mt-8">
5151
{learningMaterialsCount && (
52-
<p className="pb-3 md:pb-4 text-sm font-medium text-tertiary">{`${learningMaterialsCount} Learning ${learningMaterialsCount === 1 ? "material" : "materials"
53-
} included`}</p>
52+
<p className="pb-3 md:pb-4 text-sm font-medium text-tertiary">{`${learningMaterialsCount} Learning ${
53+
learningMaterialsCount === 1 ? "material" : "materials"
54+
} included`}</p>
5455
)}
5556
<div className="lg:flex lg:flex-row flex-col justify-between pt-3 md:pt-4 items-center">
5657
<Link href={link}>

src/components/ui/Tag.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ interface TagProps extends HTMLProps<HTMLDivElement> {
3333
*/
3434
export default function Tag({ rounded = true, type = "gray", value, children, testId = "tag", tagValueTestId = "tag-value", className, ...props }: TagProps): ReactElement {
3535
const tagClassNames = classNames(
36-
"text-center px-2 p-0.5 h-5 inline-flex items-center", className,
36+
"text-center px-2 p-0.5 min-h-5 inline-flex items-center",
37+
className,
3738
{
3839
"bg-transparent bg-opacity-25 text-white": type == "transparent",
3940
},

0 commit comments

Comments
 (0)