Merge pull request #53 from peakon/node12

Node 12 compatibility

Author: dachev

appveyor.yml

@@ -16,6 +16,16 @@ environment:
     nodejs_arch: "x86"
   - nodejs_version: "2"
     nodejs_arch: "x64"
+  - nodejs_version: "4"
+    nodejs_arch: "x64"
+  - nodejs_version: "6"
+    nodejs_arch: "x64"
+  - nodejs_version: "8"
+    nodejs_arch: "x64"
+  - nodejs_version: "10"
+    nodejs_arch: "x64"
+  - nodejs_version: "12"
+    nodejs_arch: "x64"
 install:
   - ps: Install-Product node $env:nodejs_version $env:nodejs_arch
   - npm install --msvs_version=2013

src/cld.cc

@@ -11,22 +11,22 @@ namespace NodeCld {
 
   NAN_METHOD(Detect) {
     v8::Local<v8::Object> results = Nan::New<v8::Object>();
-    v8::String::Utf8Value text(info[0]->ToString());
+    v8::String::Utf8Value text(v8::Isolate::GetCurrent(), Nan::To<v8::String>(info[0]).ToLocalChecked());
 
     char *bytes      = *text;
     int numBytes     = text.length();
-    bool isPlainText = info[1]->ToBoolean()->Value();
+    bool isPlainText = Nan::To<bool>(info[1]).FromJust();
 
     CLD2::CLDHints hints;
     hints.tld_hint = 0;
     hints.content_language_hint = 0;
     hints.language_hint = CLD2::UNKNOWN_LANGUAGE;
     hints.encoding_hint = CLD2::UNKNOWN_ENCODING;
 
-    v8::String::Utf8Value languageHint(info[2]->ToString());
-    v8::String::Utf8Value encodingHint(info[3]->ToString());
-    v8::String::Utf8Value tldHint(info[4]->ToString());
-    v8::String::Utf8Value httpHint(info[5]->ToString());
+    v8::String::Utf8Value languageHint(v8::Isolate::GetCurrent(), Nan::To<v8::String>(info[2]).ToLocalChecked());
+    v8::String::Utf8Value encodingHint(v8::Isolate::GetCurrent(), Nan::To<v8::String>(info[3]).ToLocalChecked());
+    v8::String::Utf8Value tldHint(v8::Isolate::GetCurrent(), Nan::To<v8::String>(info[4]).ToLocalChecked());
+    v8::String::Utf8Value httpHint(v8::Isolate::GetCurrent(), Nan::To<v8::String>(info[5]).ToLocalChecked());
 
     if (tldHint.length() > 0) {
       hints.tld_hint = *tldHint;
@@ -121,7 +121,7 @@ namespace NodeCld {
     info.GetReturnValue().Set(results);
   }
 
-  extern "C" void init (v8::Handle<v8::Object> target) {
+  extern "C" void init (v8::Local<v8::Object> target) {
     // set detected languages
     v8::Local<v8::Array> detected = Nan::New<v8::Array>();
     vector<NodeCldDetected>* rawDetected = Constants::getInstance().getDetected();