remove noise

Author: dadhi

src/FastExpressionCompiler.ILDecoder/DynamicScopeTokenResolver.cs

@@ -7,8 +7,6 @@ namespace FastExpressionCompiler.ILDecoder;
 
 internal class DynamicScopeTokenResolver : ITokenResolver
 {
-    #region Static stuff
-
     private static readonly PropertyInfo s_indexer;
     private static readonly FieldInfo s_scopeFi;
 
@@ -43,21 +41,16 @@ static DynamicScopeTokenResolver()
         s_genfieldFi2 = s_genFieldInfoType?.GetField("m_context", flags);
     }
 
-    #endregion
-
     private readonly object m_scope;
 
-    private object this[int token] => s_indexer.GetValue(m_scope, new object[] {token});
+    private object this[int token] => s_indexer.GetValue(m_scope, new object[] { token });
 
     public DynamicScopeTokenResolver(DynamicMethod dm)
     {
         m_scope = s_scopeFi.GetValue(dm.GetILGenerator());
     }
 
-    public string AsString(int token)
-    {
-        return this[token] as string;
-    }
+    public string AsString(int token) => this[token] as string;
 
     public FieldInfo AsField(int token)
     {
@@ -114,8 +107,5 @@ public MemberInfo AsMember(int token)
         return null;
     }
 
-    public byte[] AsSignature(int token)
-    {
-        return this[token] as byte[];
-    }
+    public byte[] AsSignature(int token) => this[token] as byte[];
 }

src/FastExpressionCompiler.ILDecoder/ILReader.cs

@@ -35,11 +35,8 @@ public ILReader(MethodBase method)
 
     public ILReader(IILProvider ilProvider, ITokenResolver tokenResolver)
     {
-        if (ilProvider == null)
-            throw new ArgumentNullException(nameof(ilProvider));
-
         _resolver = tokenResolver;
-        _byteArray = ilProvider.GetByteArray();
+        _byteArray = ilProvider?.GetByteArray() ?? throw new ArgumentNullException(nameof(ilProvider));
     }
 
     public IEnumerator<ILInstruction> GetEnumerator()
@@ -184,20 +181,6 @@ private ushort ReadUInt16(ref int position)
         return value;
     }
 
-    private uint ReadUInt32(ref int position)
-    {
-        var value = BitConverter.ToUInt32(_byteArray, position);
-        position += 4;
-        return value;
-    }
-
-    private ulong ReadUInt64(ref int position)
-    {
-        var value = BitConverter.ToUInt64(_byteArray, position);
-        position += 8;
-        return value;
-    }
-
     private int ReadInt32(ref int position)
     {
         var value = BitConverter.ToInt32(_byteArray, position);

src/FastExpressionCompiler.ILDecoder/ILReaderFactory.cs

@@ -294,3 +294,5 @@ public static string TypeToCode(this Type type,
     }
 }
 
+
+

src/FastExpressionCompiler/TestTools.cs

@@ -2,6 +2,7 @@
 #if DEBUG
 #define PRINTIL
 #define PRINTCS
+#define PRINTEXPR
 #endif
 
 using System;
@@ -60,18 +61,20 @@ public static void AssertOpCodes(this MethodInfo method, params OpCode[] expecte
 
     [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode",
         Justification = "The method is used for the testing purposes only.")]
-    [Conditional("DEBUG")]
-    public static void PrintExpression(this Expression expr, bool completeTypeNames = false) =>
+    public static void PrintExpression(this Expression expr, bool completeTypeNames = false)
+    {
+#if PRINTEXPR
         Console.WriteLine(
             expr.ToExpressionString(out var _, out var _, out var _,
             stripNamespace: true,
             printType: completeTypeNames ? null : CodePrinter.PrintTypeStripOuterClasses,
             indentSpaces: 4)
         );
+#endif
+    }
 
     [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode",
         Justification = "The method is used for the testing purposes only.")]
-    [Conditional("DEBUG")]
     public static void PrintCSharp(this Expression expr, bool completeTypeNames = false,
         [CallerMemberName] string caller = "", [CallerFilePath] string filePath = "")
     {
@@ -93,7 +96,6 @@ public static void PrintCSharp(this Expression expr, bool completeTypeNames = fa
 
     [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode",
         Justification = "The method is used for the testing purposes only.")]
-    [Conditional("DEBUG")]
     public static void PrintCSharp(this Expression expr, Func<string, string> transform,
         [CallerMemberName] string caller = "", [CallerFilePath] string filePath = "")
     {
@@ -106,7 +108,6 @@ public static void PrintCSharp(this Expression expr, Func<string, string> transf
 
     [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode",
         Justification = "The method is used for the testing purposes only.")]
-    [Conditional("DEBUG")]
     public static void PrintCSharp(this Expression expr, CodePrinter.ObjectToCode objectToCode,
         [CallerMemberName] string caller = "", [CallerFilePath] string filePath = "")
     {
@@ -119,23 +120,20 @@ public static void PrintCSharp(this Expression expr, CodePrinter.ObjectToCode ob
 
     [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode",
         Justification = "The method is used for the testing purposes only.")]
-    [Conditional("DEBUG")]
     public static void PrintCSharp(this Expression expr, ref string result)
     {
 #if PRINTCS
         Console.WriteLine(result = expr.ToCSharpString());
 #endif
     }
 
-    [Conditional("DEBUG")]
     public static void PrintIL(this Delegate @delegate, [CallerMemberName] string tag = null)
     {
 #if PRINTIL
         @delegate.Method.PrintIL(tag);
 #endif
     }
 
-    [Conditional("DEBUG")]
     public static void PrintIL(this MethodInfo method, string tag = null)
     {
 #if PRINTIL