small polishing and removing wips

Author: dadhi

src/FastExpressionCompiler/FastExpressionCompiler.cs

@@ -4372,7 +4372,7 @@ private static bool TryEmitArithmeticAndOrAssign(
 
                                 // required for calling the method on the value type parameter
                                 var objType = objExpr.Type;
-                                objVarByAddress = objType.IsValueType && !closure.LastEmitIsAddress && // todo: @wip avoid ad-hocking with parameter here
+                                objVarByAddress = !closure.LastEmitIsAddress && objType.IsValueType && // todo: @wip avoid ad-hocking with parameter here
                                     (objExpr.NodeType != ExpressionType.Parameter || !((ParameterExpression)objExpr).IsByRef);
                                 if (objVarByAddress)
                                     objVar = EmitStoreAndLoadLocalVariableAddress(il, objType);
@@ -8425,13 +8425,14 @@ public static ILGenerator RentPooledOrNewILGenerator(DynamicMethod dynMethod, Ty
             // the default ILGenerator size is 64 in .NET 8.0+
             int newStreamSize = 64)
         {
-            if (DynamicMethodHacks.ReuseDynamicILGenerator != null)
+            var reuseILGenerator = DynamicMethodHacks.ReuseDynamicILGenerator;
+            if (reuseILGenerator != null)
             {
                 var pooledIL = _pooledILGenerator;
                 _pooledILGenerator = null;
                 if (pooledIL != null)
                 {
-                    DynamicMethodHacks.ReuseDynamicILGenerator(dynMethod, pooledIL, returnType, paramTypes);
+                    reuseILGenerator(dynMethod, pooledIL, returnType, paramTypes);
                     return pooledIL;
                 }
                 else
@@ -8446,9 +8447,6 @@ public static ILGenerator RentPooledOrNewILGenerator(DynamicMethod dynMethod, Ty
         [MethodImpl((MethodImplOptions)256)]
         public static void FreePooledILGenerator(DynamicMethod dynMethod, ILGenerator il)
         {
-            // todo: @wip #475 might be required to avoid the undefined behavior when the previous DynamicMethod is still linked to the wrong ILGenerator
-            // ILGeneratorField.SetValue(dynMethod, null);
-
             if (DynamicMethodHacks.ReuseDynamicILGenerator != null)
                 _pooledILGenerator = il;
         }

test/FastExpressionCompiler.IssueTests/Issue475_Reuse_DynamicMethod_if_possible.cs

@@ -628,7 +628,7 @@ void TryToReuseTheDynamicMethod_FailedWithInternalClrError_BecauseTheResultDeleg
         // d.StoreDynamicMethod(this);
         // return d;
 
-        // todo: @wip Calling this second time in `-c:Release` will produce `Fatal error. Internal CLR error. (0x80131506) ## :-( Failed with ERROR: -1073741819` (the -c:Debug is working fine)
+        // note: Calling this second time in `-c:Release` will produce `Fatal error. Internal CLR error. (0x80131506) ## :-( Failed with ERROR: -1073741819` (the -c:Debug is working fine)
         // runtimeMethodHandle = GetMethodDescriptorMethod.Invoke(dynMethod, null);
 
         // var func2 = (Func<int, int>)CreateDelegateMethod.Invoke(null, [typeof(Func<int, int>), ExpressionCompiler.EmptyArrayClosure, runtimeMethodHandle]);

test/FastExpressionCompiler.LightExpression.IssueTests/Issue346_Is_it_possible_to_implement_ref_local_variables.cs

@@ -148,7 +148,7 @@ public void Check_assignment_to_by_ref_float_parameter_PostIncrement_Returning()
 
             var f = e.CompileFast(true, CompilerFlags.EnableDelegateDebugInfo);
             f.PrintIL();
-            // todo: @wip the IL codes is the same for the System Compile but the expected values are different
+            // todo: @wip the IL codes is the same for the System.Compile but the expected values are different
             // f.AssertOpCodes(
             // IL_0000: ldarg.1
             // IL_0001: ldarg.1

test/FastExpressionCompiler.UnitTests/AssignTests.cs

@@ -380,7 +380,6 @@ public void Array_multi_dimensional_index_assign_value_type_block()
             // todo: @wip #431 generates different names for the unnamed variables which is not comparable
             Asserts.AreEqual(expr.ToCSharpString(), restoredExpr.ToCSharpString());
 #endif
-
             Asserts.IsNotNull(fs);
             Asserts.AreEqual(5, fs());
         }