exposed enclosedIn

Author: Maksim Volkau

src/FastExpressionCompiler/FastExpressionCompiler.cs

@@ -9943,16 +9943,15 @@ public static string ToCSharpString(this Expression expr) =>
             expr.ToCSharpString(new StringBuilder(1024), stripNamespace: true).Append(';').ToString();
 
         /// <summary>Tries hard to convert the expression into the valid C# code</summary>
-        public static string ToCSharpString(this Expression expr, ObjectToCode notRecognizedToCode) =>
+        public static string ToCSharpString(this Expression expr, ObjectToCode notRecognizedToCode, EnclosedIn enclosedIn = EnclosedIn.AvoidParens) =>
             expr.ToCSharpString(new StringBuilder(1024), stripNamespace: true, notRecognizedToCode: notRecognizedToCode).Append(';').ToString();
 
         /// <summary>Tries hard to convert the expression into the valid C# code</summary>
-        public static StringBuilder ToCSharpString(this Expression e, StringBuilder sb,
+        public static StringBuilder ToCSharpString(this Expression e, StringBuilder sb, EnclosedIn enclosedIn = EnclosedIn.ParensByDefault,
             int lineIndent = 0, bool stripNamespace = false, Func<Type, string, string> printType = null, int indentSpaces = 4, ObjectToCode notRecognizedToCode = null)
         {
             SmallList<NamedWithIndex, Stack4<NamedWithIndex>, NoArrayPool<NamedWithIndex>> named = default;
-            return e.ToCSharpString(sb, EnclosedIn.ParensByDefault, ref named,
-                lineIndent, stripNamespace, printType, indentSpaces, notRecognizedToCode);
+            return e.ToCSharpString(sb, enclosedIn, ref named, lineIndent, stripNamespace, printType, indentSpaces, notRecognizedToCode);
         }
 
         /// <summary>Indicates the expression container</summary>

test/FastExpressionCompiler.IssueTests/Issue487_Fix_ToCSharpString_output_for_boolean_equality_expressions.cs

@@ -0,0 +1,49 @@
+#if NET8_0_OR_GREATER
+
+using System;
+using System.Reflection.Emit;
+using System.Text.Json;
+
+#if LIGHT_EXPRESSION
+using FastExpressionCompiler.LightExpression.ImTools;
+using static FastExpressionCompiler.LightExpression.Expression;
+namespace FastExpressionCompiler.LightExpression.IssueTests;
+#else
+using System.Linq.Expressions;
+using FastExpressionCompiler.ImTools;
+using static System.Linq.Expressions.Expression;
+namespace FastExpressionCompiler.IssueTests;
+#endif
+
+public struct Issue487_Fix_ToCSharpString_output_for_boolean_equality_expressions : ITestX
+{
+    public void Run(TestRun t)
+    {
+        Original_case(t);
+    }
+
+    public class TestClass 
+    {
+        public required bool MyTestBool { get; set; }
+    }
+
+    public void Original_case(TestContext t)
+    {
+        var input = new TestClass() { MyTestBool = true };
+        var parameter = Expression.Parameter(input.GetType(), "x");
+        var property = Expression.Property(parameter, nameof(TestClass.MyTestBool));
+        var expr = Expression.Equal(property, Expression.Constant(true));
+
+        var str = expr.ToString(); // => (x.MyTestBool == True)
+        var cs = expr.ToCSharpString(); // => (x.MyTestBool;
+
+        expr.PrintCSharp();
+
+        // var fs = expr.CompileSys();
+        // fs.PrintIL(format: ILDecoder.ILFormat.AssertOpCodes);
+
+        // var ff = expr.CompileFast(false);
+        // ff.PrintIL(format: ILDecoder.ILFormat.AssertOpCodes);
+    }
+}
+#endif

test/FastExpressionCompiler.TestsRunner/Program.cs

@@ -25,6 +25,13 @@ public static void Main()
             // new Issue441_Fails_to_pass_Constant_as_call_parameter_by_reference().Run();
             // new Issue461_InvalidProgramException_when_null_checking_type_by_ref().Run();
 
+
+            var st = new TestRun();
+#if NET8_0_OR_GREATER
+            st.Run(new Issue487_Fix_ToCSharpString_output_for_boolean_equality_expressions());
+            st.Run(new Issue475_Reuse_DynamicMethod_if_possible());
+#endif
+
             var lt = new LightExpression.TestRun(LightExpression.TestFlags.RethrowException);
 
 #if NET8_0_OR_GREATER
@@ -37,11 +44,6 @@ public static void Main()
             lt.Run(new LightExpression.IssueTests.Issue473_InvalidProgramException_when_using_Expression_Condition_with_converted_decimal_expression());
             lt.Run(new LightExpression.IssueTests.Issue476_System_ExecutionEngineException_with_nullables_on_repeated_calls_to_ConcurrentDictionary());
 
-#if NET8_0_OR_GREATER
-            var st = new TestRun();
-            st.Run(new Issue475_Reuse_DynamicMethod_if_possible());
-#endif
-
             RunAllTests();
         }