wip: subtract #314

Author: dadhi

src/FastExpressionCompiler.LightExpression/Expression.cs

@@ -1206,15 +1206,17 @@ public static BinaryExpression RightShift(Expression left, Expression right) =>
 
         /// <summary>Creates a BinaryExpression that represents an arithmetic subtraction operation that does not have overflow checking.</summary>
         public static BinaryExpression Subtract(Expression left, Expression right) =>
-            new LeftTypedBinaryExpression(ExpressionType.Subtract, left, right);
+            GetArithmeticLeftTypedBinary(ExpressionType.Subtract, left, right);
 
-        public static BinaryExpression Subtract(Expression left, Expression right, MethodInfo method) => GetLeftTypedBinary(ExpressionType.Subtract, left, right, method);
+        public static BinaryExpression Subtract(Expression left, Expression right, MethodInfo method) => 
+            GetArithmeticLeftTypedBinary(ExpressionType.Subtract, left, right, method);
 
         /// <summary>Creates a BinaryExpression that represents an arithmetic subtraction operation that has overflow checking.</summary>
         public static BinaryExpression SubtractChecked(Expression left, Expression right) =>
-            new LeftTypedBinaryExpression(ExpressionType.SubtractChecked, left, right);
+            GetArithmeticLeftTypedBinary(ExpressionType.SubtractChecked, left, right);
 
-        public static BinaryExpression SubtractChecked(Expression left, Expression right, MethodInfo method) => GetLeftTypedBinary(ExpressionType.SubtractChecked, left, right, method);
+        public static BinaryExpression SubtractChecked(Expression left, Expression right, MethodInfo method) => 
+            GetArithmeticLeftTypedBinary(ExpressionType.SubtractChecked, left, right, method);
 
         /// <summary>Creates a BinaryExpression that represents an arithmetic multiplication operation that does not have overflow checking.</summary>
         public static BinaryExpression Multiply(Expression left, Expression right) =>

test/FastExpressionCompiler.TestsRunner/Program.cs

@@ -10,8 +10,8 @@ public class Program
         public static void Main()
         {
             RunAllTests();
-            //new Issue314_LiftToNull_ToExpressionString().Run();
-            //new FastExpressionCompiler.LightExpression.IssueTests.Issue314_LiftToNull_ToExpressionString().Run();
+            // new Issue314_LiftToNull_ToExpressionString().Run();
+            // new FastExpressionCompiler.LightExpression.IssueTests.Issue314_LiftToNull_ToExpressionString().Run();
 
             // new Issue309_InvalidProgramException_with_MakeBinary_liftToNull_true().Run();
             // new FastExpressionCompiler.LightExpression.IssueTests.Issue309_InvalidProgramException_with_MakeBinary_liftToNull_true().Run();