added tests (passing) from the #492 PR by @ayyyabean-alt

Author: Maksim Volkau

test/FastExpressionCompiler.IssueTests/Issue490_Regression_in_compiling_lambdas_with_ref_struct_parameters.cs

@@ -17,6 +17,8 @@ public struct Issue490_Regression_in_compiling_lambdas_with_ref_struct_parameter
 {
     public void Run(TestRun t)
     {
+        Return_true_when_token_is_null();
+        Return_false_when_token_is_not_null();
         Original_case(t);
     }
 
@@ -74,5 +76,79 @@ public void Original_case(TestContext t)
         var b = ff(ref reader);
         t.AreEqual(default, b);
     }
+
+    public delegate bool RefStructReaderDelegate(ref MyJsonReader reader);
+
+    public enum MyJsonTokenType : byte
+    {
+        None = 0,
+        StartObject = 1,
+        Null = 11
+    }
+
+    public ref struct MyJsonReader
+    {
+        public MyJsonTokenType TokenType { get; set; }
+    }
+
+    public void Return_true_when_token_is_null(TestContext t = default)
+    {
+        var readerParam = Parameter(typeof(MyJsonReader).MakeByRefType(), "reader");
+        var tokenType = Property(readerParam, nameof(MyJsonReader.TokenType));
+        var nullToken = Constant(MyJsonTokenType.Null);
+
+        var body = Condition(
+            Equal(tokenType, nullToken),
+            Constant(true),
+            Constant(false));
+
+        var lambda = Lambda<RefStructReaderDelegate>(body, readerParam);
+        lambda.PrintCSharp();
+
+        var fs = lambda.CompileSys();
+        fs.PrintIL();
+
+        var reader = new MyJsonReader();
+        reader.TokenType = MyJsonTokenType.Null;
+
+        var a = fs(ref reader);
+        t.AreEqual(true, a);
+
+        var ff = lambda.CompileFast();
+        ff.PrintIL();
+
+        var b = ff(ref reader);
+        t.AreEqual(true, b);
+    }
+
+    public void Return_false_when_token_is_not_null(TestContext t = default)
+    {
+        var readerParam = Parameter(typeof(MyJsonReader).MakeByRefType(), "reader");
+        var tokenType = Property(readerParam, nameof(MyJsonReader.TokenType));
+        var nullToken = Constant(MyJsonTokenType.Null);
+
+        var body = Condition(
+            Equal(tokenType, nullToken),
+            Constant(true),
+            Constant(false));
+
+        var lambda = Lambda<RefStructReaderDelegate>(body, readerParam);
+        lambda.PrintCSharp();
+
+        var fs = lambda.CompileSys();
+        fs.PrintIL();
+
+        var reader = new MyJsonReader();
+        reader.TokenType = MyJsonTokenType.StartObject;
+
+        var a = fs(ref reader);
+        t.AreEqual(false, a);
+
+        var ff = lambda.CompileFast();
+        ff.PrintIL();
+
+        var b = ff(ref reader);
+        t.AreEqual(false, b);
+    }
 }
 #endif

test/FastExpressionCompiler.TestsRunner/Program.cs

@@ -18,7 +18,7 @@ public static void Main()
             // ILGeneratorTools.DisableILGeneratorPooling = true;
             // LightExpression.ILGeneratorTools.DisableILGeneratorPooling = true;
 
-            new ConditionalOperatorsTests().Run();
+            // new ConditionalOperatorsTests().Run();
             // new ConstantAndConversionTests().Run();
             // new Issue284_Invalid_Program_after_Coalesce().Run(); // test print cs
             // new Issue440_Errors_with_simplified_Switch_cases().Run(); // test print cs
@@ -34,16 +34,6 @@ public static void Main()
             // new Issue441_Fails_to_pass_Constant_as_call_parameter_by_reference().Run();
             // new Issue461_InvalidProgramException_when_null_checking_type_by_ref().Run();
 
-
-            var st = new TestRun(TestFlags.RethrowException);
-
-            st.Run(new Issue480_CLR_detected_an_invalid_program_exception());
-
-#if NET8_0_OR_GREATER
-            st.Run(new Issue487_Fix_ToCSharpString_output_for_boolean_equality_expressions());
-            st.Run(new Issue475_Reuse_DynamicMethod_if_possible());
-#endif
-
             var lt = new LightExpression.TestRun(LightExpression.TestFlags.RethrowException);
 
 #if NET8_0_OR_GREATER
@@ -56,6 +46,15 @@ public static void Main()
             lt.Run(new LightExpression.IssueTests.Issue473_InvalidProgramException_when_using_Expression_Condition_with_converted_decimal_expression());
             lt.Run(new LightExpression.IssueTests.Issue476_System_ExecutionEngineException_with_nullables_on_repeated_calls_to_ConcurrentDictionary());
 
+            var st = new TestRun(TestFlags.RethrowException);
+
+            st.Run(new Issue480_CLR_detected_an_invalid_program_exception());
+
+#if NET8_0_OR_GREATER
+            st.Run(new Issue487_Fix_ToCSharpString_output_for_boolean_equality_expressions());
+            st.Run(new Issue475_Reuse_DynamicMethod_if_possible());
+#endif
+
             RunAllTests();
         }