fixing #305 again

Author: dadhi

src/FastExpressionCompiler/FastExpressionCompiler.cs

@@ -3361,7 +3361,7 @@ private static bool TryEmitArrayIndex(Type type, ILGenerator il, ParentFlags par
                     il.Emit(OpCodes.Ldelem_U2);
                 else if (type == typeof(UInt32))
                     il.Emit(OpCodes.Ldelem_U4);
-                else if ((parent & (ParentFlags.MemberAccess | ParentFlags.Call)) == 0)
+                else if ((parent & (ParentFlags.MemberAccess | ParentFlags.InstanceAccess)) == 0)
                     il.Emit(OpCodes.Ldelem, type);
                 else
                 {

test/FastExpressionCompiler.IssueTests/Issue305_CompileFast_generates_incorrect_code_with_arrays_and_printing.cs

@@ -1,5 +1,7 @@
 using NUnit.Framework;
 using System;
+using System.Linq;
+using System.Collections.Generic;
 using System.Linq.Expressions;
 #if LIGHT_EXPRESSION
 using System.Text;
@@ -19,33 +21,32 @@ public int Run()
             return 1;
         }
 
-        public static void WriteLine(double d) {}
+        private List<double> _items = new List<double>();
+
+        public void WriteLine(double n) => _items.Add(n);
 
         [Test]
         public void Test1()
         {
             var arr = Variable(typeof(double[]), "arr");
 
-            var printDouble = this.GetType().GetMethod(nameof(WriteLine), new[] { typeof(double) });
+            var print = this.GetType().GetMethod(nameof(WriteLine), new[] { typeof(double) });
 
             var expr = Lambda<Func<double>>(
                 Block(new[] { arr },
                     Assign(arr, NewArrayBounds(typeof(double), Constant(1))),
                     Assign(ArrayAccess(arr, Constant(0)), Constant(123.456)),
 
-                    Call(printDouble, ArrayAccess(arr, Constant(0))),
-                    Call(printDouble, ArrayAccess(arr, Constant(0))),
-                    Call(printDouble, ArrayAccess(arr, Constant(0))),
-                    Call(printDouble, ArrayAccess(arr, Constant(0))),
-                    Call(printDouble, ArrayAccess(arr, Constant(0))),
-                    Call(printDouble, ArrayAccess(arr, Constant(0))),
-                    Call(printDouble, ArrayAccess(arr, Constant(0))),
+                    Call(Constant(this), print, ArrayAccess(arr, Constant(0))),
+                    Call(Constant(this), print, ArrayAccess(arr, Constant(0))),
 
                     ArrayAccess(arr, Constant(0))
             ));
 
             expr.PrintCSharp();
 
+            _items.Clear();
+
             var fs = expr.CompileSys();
             fs.PrintIL();
 
@@ -57,6 +58,7 @@ public void Test1()
 
             var res2 = ff();
             Assert.AreEqual(123.456, res2);
+            Assert.AreEqual(4, _items.Count(x => x == 123.456));
         }
     }
 }