cleanup #491 and add tests to net472

Author: Maksim Volkau

src/FastExpressionCompiler/FastExpressionCompiler.cs

@@ -2514,11 +2514,10 @@ private static bool TryEmitNew(Expression expr, IReadOnlyList<PE> paramExprs, IL
                 else
                     return false;
 
-                closure.LastEmitIsAddress = newType.IsValueType && (parent & ParentFlags.InstanceAccess) != 0 && !parent.IgnoresResult();
+                closure.LastEmitIsAddress =
+                    (parent & ParentFlags.InstanceAccess) != 0 & (parent & ParentFlags.IgnoreResult) == 0 && newType.IsValueType;
                 if (closure.LastEmitIsAddress)
-                {
                     EmitStoreAndLoadLocalVariableAddress(il, newType);
-                }
 
                 if (parent.IgnoresResult())
                     il.Demit(OpCodes.Pop);

test/FastExpressionCompiler.TestsRunner.Net472/Program.cs

@@ -133,6 +133,8 @@ void Run(Func<int> run, string name = null)
                 Run(new LightExpression.UnitTests.ConvertOperatorsTests().Run);
                 Run(new DefaultTests().Run);
                 Run(new LightExpression.UnitTests.DefaultTests().Run);
+                Run(new ConstructorCallTests().Run);
+                Run(new LightExpression.UnitTests.ConstructorCallTests().Run);
                 Run(new EqualityOperatorsTests().Run);
                 Run(new LightExpression.UnitTests.EqualityOperatorsTests().Run);
                 Run(new GotoTests().Run);

test/FastExpressionCompiler.UnitTests/ConstructorCallTests.cs

@@ -61,8 +61,8 @@ public void Constructor_conversions_and_boxing()
         ).CompileFast(true);
         Asserts.AreEqual(42, ((TestStruct)fBox()).A);
 
-        var fInterface = Lambda<Func<ITestInterfacce>>(
-            Convert(New(TestStruct.Ctor, Constant(43), Constant("a")), typeof(ITestInterfacce))
+        var fInterface = Lambda<Func<ITestInterface>>(
+            Convert(New(TestStruct.Ctor, Constant(43), Constant("a")), typeof(ITestInterface))
         ).CompileFast(true);
         Asserts.AreEqual(43, fInterface().PropertyA);
 
@@ -377,9 +377,9 @@ public void Constructor_nested_in_block_member_access()
         Asserts.AreEqual(42, fastCompiled());
     }
 
-    public interface ITestInterfacce { int PropertyA { get; } }
+    public interface ITestInterface { int PropertyA { get; } }
 
-    public struct TestStruct : ITestInterfacce
+    public struct TestStruct : ITestInterface
     {
         public static readonly ConstructorInfo Ctor = typeof(TestStruct).GetConstructors()[0];
         public int A;
@@ -406,7 +406,7 @@ public TestStruct(int a, string b)
         public static implicit operator int(TestStruct s) => s.A;
     }
 
-    public class TestClass : ITestInterfacce
+    public class TestClass : ITestInterface
     {
         public static readonly ConstructorInfo Ctor = typeof(TestClass).GetConstructors()[0];
         public int A;