Skip to content

Commit ddcd8cb

Browse files
authored
Merge pull request #132 from dadoonet/dependabot/maven/co.elastic.clients-elasticsearch-java-8.16.1
Bump co.elastic.clients:elasticsearch-java from 8.16.0 to 8.16.1
2 parents 68df285 + e7df5b3 commit ddcd8cb

File tree

3 files changed

+6
-14
lines changed

3 files changed

+6
-14
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ I believe it could be beneficial for many, so I've made the code available here.
1111

1212
You're welcome to contribute your own examples if you'd like.
1313

14-
This repository is tested against Elasticsearch 8.16.0.
14+
This repository is tested against Elasticsearch 8.16.1.
1515

1616
We automatically start a Docker image using the [Elasticsearch module for TestContainers](https://www.testcontainers.org/modules/elasticsearch/).
1717

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
<properties>
1212
<!-- Main dependencies -->
13-
<elasticsearch.version>8.16.0</elasticsearch.version>
13+
<elasticsearch.version>8.16.1</elasticsearch.version>
1414
<jackson.version>2.18.1</jackson.version>
1515
<log4j.version>2.24.2</log4j.version>
1616
<slf4j.version>2.0.16</slf4j.version>

src/test/java/fr/pilato/test/elasticsearch/hlclient/EsClientIT.java

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -938,26 +938,18 @@ void esql() throws IOException, SQLException {
938938
}
939939

940940
// Using the JDBC ResultSet ES|QL API
941-
// And this is now failing because of https://github.com/elastic/elasticsearch-java/pull/903
942941
try (ResultSet resultSet = client.esql().query(ResultSetEsqlAdapter.INSTANCE, query)) {
943-
fail("https://github.com/elastic/elasticsearch-java/pull/903 have been fixed. Update the code.");
944942
assertTrue(resultSet.next());
945943
assertEquals("David", resultSet.getString(1));
946944
} catch (JsonpMappingException e) {
947945
// This is expected as we have this issue https://github.com/elastic/elasticsearch-java/pull/903
948946
}
949947

950948
// Using the Object ES|QL API
951-
// And this is now failing because of https://github.com/elastic/elasticsearch-java/pull/903
952-
try {
953-
Iterable<Person> persons = client.esql().query(ObjectsEsqlAdapter.of(Person.class), query);
954-
fail("https://github.com/elastic/elasticsearch-java/pull/903 have been fixed. Update the code.");
955-
for (Person person : persons) {
956-
assertNull(person.getId());
957-
assertNotNull(person.getName());
958-
}
959-
} catch (JsonpMappingException e) {
960-
// This is expected as we have this issue https://github.com/elastic/elasticsearch-java/pull/903
949+
Iterable<Person> persons = client.esql().query(ObjectsEsqlAdapter.of(Person.class), query);
950+
for (Person person : persons) {
951+
assertNull(person.getId());
952+
assertNotNull(person.getName());
961953
}
962954
}
963955

0 commit comments

Comments
 (0)