Merge pull request #29 from xdevor/master

daftspunk · web-flow · commit 44c6bdc7c7a4 · 2023-03-10T12:56:56.000+11:00
fix(Rewrite): return type of `writeArrayToPhp()` should be `string`
diff --git a/src/DataWriter/Rewrite.php b/src/DataWriter/Rewrite.php
@@ -132,7 +132,7 @@ protected function writeValueToPhp($value): string
         return $replaceValue;
     }
 
-    protected function writeArrayToPhp(array $array): array
+    protected function writeArrayToPhp(array $array): string
     {
         $result = [];
 
@@ -143,8 +143,6 @@ protected function writeArrayToPhp(array $array): array
         }
 
         return '['.implode(', ', $result).']';
-
-        return $result;
     }
 
     protected function buildStringExpression(string $targetKey, array $arrayItems = [], string $quoteChar = "'"): string

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ protected function writeValueToPhp($value): string`
`132`	`132`	`return $replaceValue;`
`133`	`133`	`}`
`134`	`134`
`135`		`- protected function writeArrayToPhp(array $array): array`
	`135`	`+ protected function writeArrayToPhp(array $array): string`
`136`	`136`	`{`
`137`	`137`	`$result = [];`
`138`	`138`
`@@ -143,8 +143,6 @@ protected function writeArrayToPhp(array $array): array`
`143`	`143`	`}`
`144`	`144`
`145`	`145`	`return '['.implode(', ', $result).']';`
`146`		`-`
`147`		`- return $result;`
`148`	`146`	`}`
`149`	`147`
`150`	`148`	`protected function buildStringExpression(string $targetKey, array $arrayItems = [], string $quoteChar = "'"): string`