Commit 7134686
Fix concurrent server process resource contention bugs (and add a test to produce them) (#257)
* add stdio test to trigger contention bugs
Signed-off-by: Connor Braa <[email protected]>
* clean up and reorg
Signed-off-by: Connor Braa <[email protected]>
* modernize
Signed-off-by: Connor Braa <[email protected]>
* more crush config to gitignore
Signed-off-by: Connor Braa <[email protected]>
* stop expecting failure
Signed-off-by: Connor Braa <[email protected]>
* unify tests into 1 big one that will actually fail
Signed-off-by: Connor Braa <[email protected]>
* gr
Signed-off-by: Connor Braa <[email protected]>
* add fslocking to fix various concurrency bugs
Signed-off-by: Connor Braa <[email protected]>
* cleanup and increase lock granularity
Squashed commit of the following:
commit c07d03c4a905ae3716e99ee1ec49bd3af2516a86
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 14:05:17 2025 -0700
Updating call to match new signature
commit 40a89c70b79327f2374cc127cb57bb8a9165eb09
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 14:05:05 2025 -0700
Updating call to match new signature
commit 5a14e6ec8e96e06c2b44612cf53c18fa127ad36d
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 14:04:52 2025 -0700
Updating call to match new signature
commit 79c0fcadc7335333d798d5d2ce8f960f3e08c768
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 14:04:39 2025 -0700
Fixing the unparam issue by removing unused return value
commit d147e125488f160d43e8d616213fffd0bdd3c9d8
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 14:04:07 2025 -0700
Running go fmt to fix formatting issues
commit ef2c0d414b47c14f1e113e85c1f556d167fe0ac3
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 14:02:02 2025 -0700
Fixing the remaining lock usage in Update method
commit 685d0fc718e05ab9d387aac817886ab144baa257
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 14:01:09 2025 -0700
Using git notes lock for state save operations
commit b3b0ffb01e8f277294e6db22cd6e379dbf4c8ab1
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 14:00:59 2025 -0700
Using git notes lock for git notes operations
commit fcb8d4134bd8947aeb9da342fc07117b8ef8e47a
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 14:00:49 2025 -0700
Using worktree-specific lock for worktree initialization
commit 706a9872042cab580bf90b296eddc4e95e8ab416
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 14:00:37 2025 -0700
Using git notes lock for propagation operations
commit 7e5eb037a04e7bb93c5da28a8d74ad2f5b539664
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 14:00:21 2025 -0700
Using repository-level lock for setup operations
commit f683d7a69f7db21eebfc1b2056db682ad1389645
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 14:00:08 2025 -0700
Updating repository initialization to use lock manager
commit 7efe09e3048f10c2d388c8937f29d25c247d1b01
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 13:59:59 2025 -0700
Updating repository struct to use the new lock manager
commit 63057d9c366d39e40ac2289a1f403f8879405afe
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 13:59:43 2025 -0700
Implementing granular locking with different lock types to reduce contention
commit 414f772ec067d5ab4b645bd0871974bc9f22dc0e
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 13:59:00 2025 -0700
Renaming lock.go to fslock.go as requested
commit 1a9b093403b207dc704e6ee67528fd58fa50ee12
Author: Connor Braa <[email protected]>
Date: Wed Jul 30 13:57:37 2025 -0700
Create environment maximum-swift: Optimize filesystem locking granularity
Signed-off-by: Connor Braa <[email protected]>
* range int
Signed-off-by: Connor Braa <[email protected]>
* cleanup fslock delay calc
Signed-off-by: Connor Braa <[email protected]>
* switch to gofrs/flock for fslock impl: it should work on windows and is considerably more performant
Signed-off-by: Connor Braa <[email protected]>
* cleanup and remove extraneous locking
Signed-off-by: Connor Braa <[email protected]>
* remove extraneous custom lock impl
Signed-off-by: Connor Braa <[email protected]>
* clean up llm slop comments
Signed-off-by: Connor Braa <[email protected]>
* comment hash algo
Co-authored-by: Dagger Assistant <[email protected]>
Signed-off-by: Connor Braa <[email protected]>
* bounds check cmd/container-use/stdio_test.go
Co-authored-by: Dagger Assistant <[email protected]>
Signed-off-by: Connor Braa <[email protected]>
* raise push err in repository/git.go
Co-authored-by: Dagger Assistant <[email protected]>
Signed-off-by: Connor Braa <[email protected]>
* utilize flock.go err helper in loadState
Signed-off-by: Connor Braa <[email protected]>
* log mkdirall errors and chain methods a lil
Signed-off-by: Connor Braa <[email protected]>
---------
Signed-off-by: Connor Braa <[email protected]>
Signed-off-by: Connor Braa <[email protected]>
Co-authored-by: Dagger Assistant <[email protected]>1 parent b1c5a98 commit 7134686
File tree
8 files changed
+663
-56
lines changed- cmd/container-use
- repository
8 files changed
+663
-56
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
0 commit comments