Skip to content

Commit e103c27

Browse files
authored
Fix utils/run action deployment targeting (#216)
Summary: Instead of specifying the deployment via the URL, use the --deployment argument. Test Plan: Use this action when pointed at a branch deployment, it now launches a run in that branch deployment.
1 parent fbc06f8 commit e103c27

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/run.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ fi
1111

1212
RUN_ID=$(
1313
dagster-cloud job launch \
14-
--url "${DAGSTER_CLOUD_URL}/${INPUT_DEPLOYMENT}" \
14+
--url "${DAGSTER_CLOUD_URL}" \
15+
--deployment "${INPUT_DEPLOYMENT}" \
1516
--api-token "$DAGSTER_CLOUD_API_TOKEN" \
1617
--location "${INPUT_LOCATION_NAME}" \
1718
--repository "${INPUT_REPOSITORY_NAME}" \

tests/test_run.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import json
2-
31
def test_run(tmp_path, exec_context, action_docker_image_id):
42
output_file = tmp_path / "output.txt"
53
output_file.touch()
@@ -22,8 +20,9 @@ def test_run(tmp_path, exec_context, action_docker_image_id):
2220
exec_context.stub_command(
2321
"dagster-cloud",
2422
{
25-
"job launch --url http://dagster.cloud/test/prod "
26-
"--api-token api-token "
23+
"job launch --url http://dagster.cloud/test "
24+
"--deployment prod "
25+
"--api-token api-token "
2726
"--location some-location "
2827
"--repository some-repository "
2928
"--job some-job "

0 commit comments

Comments
 (0)