Add wait and interval params (#235)

* add a --wait flag

* use release branch

* update script to accept add-wait-param as rc name

* use add-wait-param package

* use linux/amd64

* Update release.py

* Fix run ID extraction when using --wait flag

- Add debug output to troubleshoot command execution
- Handle different output formats from dagster-cloud CLI when --wait is used
- Extract run ID from status messages like 'Run <id> is in progress'
- Fix GITHUB_OUTPUT format issue

* work with multiple lines in stdout

* Add comprehensive tests for wait parameter functionality

- Test run script without wait flag (default behavior)
- Test run script with wait flag enabled (multi-line output)
- Test various truthy values for wait parameter
- Test backwards compatibility when INPUT_WAIT is not set
- Maintain original test for backwards compatibility
- Handle extraction of run ID from both single line and multi-line outputs

* Fix regex patterns for run ID extraction to handle test data

- Make run ID regex more flexible to handle both UUIDs and test strings
- Change from strict 36-char UUID pattern to more permissive alphanumeric pattern
- Allows tests to pass with mock data like 'some-run' while still working with real UUIDs

* clean up debugging and remove tests

* add interval flag to github action if wait is enabled

* add pex

* use dev not rc add-wait-param in actions

* add default interval wait time

Author: cnolanminich

actions/launch_job/action.yml

@@ -23,6 +23,13 @@ inputs:
   job_name:
     required: true
     description: "The name of the job to launch."
+  wait:
+    required: false
+    default: "false"
+    description: "Whether to wait for the job to complete before exiting. When true, the action will wait for the run to finish and fail if the run fails."
+  interval:
+    required: false
+    description: "Interval in seconds between status checks when waiting for job completion. Can only be used when wait is true. Default is 30 seconds"
 runs:
   using: "composite"
   steps:
@@ -53,5 +60,7 @@ runs:
         location_name: ${{ inputs.location_name }}
         repository_name: ${{ inputs.repository_name }}
         job_name: ${{ inputs.job_name }}
+        wait: ${{ inputs.wait }}
+        interval: ${{ inputs.interval }}
       env:
         DAGSTER_CLOUD_API_TOKEN: ${{ inputs.dagster_cloud_api_token }}

actions/utils/run/action.yml

@@ -27,6 +27,13 @@ inputs:
     required: false
     description: "A JSON dict of config to apply to the run, input as a string."
     default: "{}"
+  wait:
+    required: false
+    default: "false"
+    description: "Whether to wait for the job to complete before exiting. When true, the action will wait for the run to finish and fail if the run fails."
+  interval:
+    required: false
+    description: "Interval in seconds between status checks when waiting for job completion. Can only be used when wait is true."
   dagster_cloud_url:
     required: false
     description: "Alternative to providing organization ID. The URL of your Dagster Cloud organization."

generated/gha/dagster-cloud.pex

@@ -66,6 +66,7 @@ def build_docker_action(version_tag: str, publish_docker_action: bool = True):
                 ".",
                 "-f",
                 "src/Dockerfile",
+                "--platform=linux/amd64",
                 "-t",
                 image_name,
             ],

scripts/release.py

@@ -9,7 +9,28 @@ if [ -z $DAGSTER_CLOUD_URL ]; then
     fi
 fi
 
-RUN_ID=$(
+# Check for wait flag - handle various true values
+wait_flag=""
+interval_flag=""
+case "$(echo "${INPUT_WAIT}" | tr '[:upper:]' '[:lower:]')" in
+    "true"|"1"|"yes"|"on")
+        wait_flag="--wait"
+        # Only add interval flag if wait is enabled and interval is provided
+        if [ -n "${INPUT_INTERVAL}" ]; then
+            interval_flag="--interval ${INPUT_INTERVAL}"
+        fi
+        ;;
+    *)
+        # Validate that interval is not used without wait
+        if [ -n "${INPUT_INTERVAL}" ]; then
+            echo "ERROR: interval parameter can only be used when wait is true"
+            exit 1
+        fi
+        ;;
+esac
+
+# Run the command and capture all output
+COMMAND_OUTPUT=$(
     dagster-cloud job launch \
     --url "${DAGSTER_CLOUD_URL}" \
     --deployment "${INPUT_DEPLOYMENT}" \
@@ -18,11 +39,26 @@ RUN_ID=$(
     --repository "${INPUT_REPOSITORY_NAME}" \
     --job "${INPUT_JOB_NAME}" \
     --tags "${INPUT_TAGS_JSON}" \
-    --config-json "${INPUT_CONFIG_JSON}"
+    --config-json "${INPUT_CONFIG_JSON}" \
+    ${wait_flag} ${interval_flag} 2>&1
 )
 
-if [ -z $RUN_ID ]; then
-    echo "Failed to launch run"
+# Extract run ID from the output
+# Look for patterns like "Run <run-id> is in progress" or "Run <run-id> finished"
+RUN_ID=""
+if [[ "$COMMAND_OUTPUT" =~ Run\ ([a-f0-9-]+) ]]; then
+    RUN_ID="${BASH_REMATCH[1]}"
+else
+    # Try to get the first line if it looks like a run ID (for non-wait mode)
+    FIRST_LINE=$(echo "$COMMAND_OUTPUT" | head -n1 | tr -d '\n\r')
+    if [[ "$FIRST_LINE" =~ ^[a-zA-Z0-9-]+$ ]]; then
+        RUN_ID="$FIRST_LINE"
+    fi
+fi
+
+if [ -z "$RUN_ID" ]; then
+    echo "Failed to launch run or extract run ID"
+    echo "Command output was: $COMMAND_OUTPUT"
     exit 1
 else
     echo "Successfully launched run: ${RUN_ID}"