Add code quality tests from Aqua and ExplicitImports

Author: dahong67

test/Project.toml

@@ -1,8 +1,10 @@
 [deps]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 BSON = "fbb218c0-5317-5bc6-957e-2ee96dd4b1f0"
 CacheVariables = "9a355d7c-ffe9-11e8-019f-21dae27d1722"
 DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
 Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
+ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
 JLD2 = "033835bb-8acc-5ee8-8aae-3f567f8a3819"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 TestItemRunner = "f8b46487-2199-4994-9208-9a1283c18c0a"

test/code-quality/aqua.jl

@@ -0,0 +1,41 @@
+# Aqua
+
+@testitem "Method ambiguities" begin
+    using Aqua: test_ambiguities
+    test_ambiguities(CacheVariables)
+end
+
+@testitem "Unbound type parameters" begin
+    using Aqua: test_unbound_args
+    test_unbound_args(CacheVariables)
+end
+
+@testitem "Undefined exports" begin
+    using Aqua: test_undefined_exports
+    test_undefined_exports(CacheVariables)
+end
+
+@testitem "Stale dependencies" begin
+    using Aqua: test_stale_deps
+    test_stale_deps(CacheVariables)
+end
+
+@testitem "Compat entries" begin
+    using Aqua: test_deps_compat
+    test_deps_compat(CacheVariables)
+end
+
+@testitem "Type piracy" begin
+    using Aqua: test_piracies
+    test_piracies(CacheVariables)
+end
+
+@testitem "Persistent tasks" begin
+    using Aqua: test_persistent_tasks
+    test_persistent_tasks(CacheVariables)
+end
+
+@testitem "Undocumented names" begin
+    using Aqua: test_undocumented_names
+    test_undocumented_names(CacheVariables)
+end

test/code-quality/explicitimports.jl

@@ -0,0 +1,43 @@
+# ExplicitImports
+
+@testitem "Implicit imports" begin
+    using ExplicitImports
+    @test check_no_implicit_imports(CacheVariables) === nothing
+end
+
+@testitem "Stale imports" begin
+    using ExplicitImports
+    @test check_no_stale_explicit_imports(CacheVariables) === nothing
+end
+
+@testitem "Non-owner imports" begin
+    using ExplicitImports
+    @test check_all_explicit_imports_via_owners(CacheVariables) === nothing
+end
+
+@testitem "Non-public imports" begin
+    using ExplicitImports
+    if VERSION >= v"1.11-"  # public only declared on Julia 1.11+
+        @test check_all_explicit_imports_are_public(CacheVariables) === nothing
+    end
+end
+
+@testitem "Non-owner qualified accesses" begin
+    using ExplicitImports
+    @test check_all_qualified_accesses_via_owners(CacheVariables) === nothing
+end
+
+@testitem "Non-public qualified accesses" begin
+    using ExplicitImports
+    if VERSION >= v"1.11-"  # public only declared on Julia 1.11+
+        ignore = (
+            :load,         # from BSON
+        )
+        @test check_all_qualified_accesses_are_public(CacheVariables; ignore) === nothing
+    end
+end
+
+@testitem "Self-qualified accesses" begin
+    using ExplicitImports
+    @test check_no_self_qualified_accesses(CacheVariables) === nothing
+end