Merge branch 'dail8859:master' into master

Author: matthewyang204

.github/workflows/build.yml

@@ -104,28 +104,28 @@ jobs:
           make appimage
 
       - name: Upload Windows zip Package
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         if: runner.os == 'Windows'
         with:
           name: NotepadNext-Windows-Qt${{ matrix.qt_version }}-Zip
           path: ${{ github.workspace }}/build/package/
 
       - name: Upload Windows Installer
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         if: runner.os == 'Windows'
         with:
           name: NotepadNext-Windows-Qt${{ matrix.qt_version }}-Installer
           path: ${{ github.workspace }}/installer/NotepadNext*.exe
 
       - name: Upload macOS dmg
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         if: runner.os == 'macOS'
         with:
           name: NotepadNext-macOS-Qt${{ matrix.qt_version }}
           path: ${{ github.workspace }}/build/NotepadNext/NotepadNext*.dmg
 
       - name: Upload Linux AppImage
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         if: runner.os == 'Linux'
         with:
           name: NotepadNext-Linux-Qt${{ matrix.qt_version }}-AppImage
@@ -150,7 +150,7 @@ jobs:
           gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --generate-notes --draft
 
       - name: Download all artifacts
-        uses: actions/download-artifact@v5
+        uses: actions/download-artifact@v6
 
       - name: Upload Windows Installer
         run: |

src/NotepadNext/NotepadNextApplication.cpp

@@ -440,6 +440,19 @@ void NotepadNextApplication::saveSettings()
     getSettings()->setValue("App/RecentFilesList", recentFilesListManager->fileList());
 }
 
+void NotepadNextApplication::saveSession()
+{
+    // Iterate all the opened editors and add them to the recent file list
+    for (const auto &editor : window->editors()) {
+        if (editor->isFile()) {
+            recentFilesListManager->addFile(editor->getFilePath());
+        }
+    }
+    saveSettings();
+
+    getSessionManager()->saveSession(window);
+}
+
 MainWindow *NotepadNextApplication::createNewWindow()
 {
     Q_ASSERT(window == Q_NULLPTR);
@@ -451,16 +464,14 @@ MainWindow *NotepadNextApplication::createNewWindow()
         LuaExtension::Instance().setEditor(editor);
     });
 
-    // Since these editors don't actually get "closed" go ahead and add them to the recent file list
-    connect(window, &MainWindow::aboutToClose, this, [=]() {
-        for (const auto &editor : window->editors()) {
-            if (editor->isFile()) {
-                recentFilesListManager->addFile(editor->getFilePath());
-            }
-        }
+    // TODO: this shouldn't be dependent on a MainWindow closing, but this works for now
+    // since the assumption is MainWindow::aboutToClose() infers the application is shutting
+    // down but the editors are still active.
+    connect(window, &MainWindow::aboutToClose, this, &NotepadNextApplication::saveSession);
 
-        getSessionManager()->saveSession(window);
-    });
+    // Timer to autosave the session
+    connect(&autoSaveTimer, &QTimer::timeout, this, &NotepadNextApplication::saveSession);
+    autoSaveTimer.start(60 * 1000);
 
     return window;
 }

src/NotepadNext/NotepadNextApplication.h

@@ -26,6 +26,7 @@
 
 #include <QCommandLineParser>
 #include <QPointer>
+#include <QTimer>
 
 
 class MainWindow;
@@ -75,6 +76,7 @@ class NotepadNextApplication : public SingleApplication
 private slots:
     void saveSettings();
     void receiveInfoFromSecondaryInstance(quint32 instanceId, QByteArray message);
+    void saveSession();
 
 private:
     void openFiles(const QStringList &files);
@@ -95,6 +97,8 @@ private slots:
     MainWindow *createNewWindow();
 
     QCommandLineParser parser;
+
+    QTimer autoSaveTimer; //save automatically the session
 };
 
 #endif // NOTEPADNEXTAPPLICATION_H

src/NotepadNext/SessionManager.cpp

@@ -316,10 +316,10 @@ ScintillaNext *SessionManager::loadUnsavedFileDetails(QSettings &settings)
         editor->setFileInfo(filePath);
         editor->setTemporary(true);
 
-        loadEditorViewDetails(editor, settings);
-
         app->getEditorManager()->manageEditor(editor);
 
+        loadEditorViewDetails(editor, settings);
+
         return editor;
     }
     else {