diff --git a/src/NotepadNext/decorators/HighlightedScrollBar.cpp b/src/NotepadNext/decorators/HighlightedScrollBar.cpp index 779196859..625984484 100644 --- a/src/NotepadNext/decorators/HighlightedScrollBar.cpp +++ b/src/NotepadNext/decorators/HighlightedScrollBar.cpp @@ -32,7 +32,7 @@ const QColor CURSOR_CARET_COLOR = QColor(0, 0, 0, 100); HighlightedScrollBarDecorator::HighlightedScrollBarDecorator(ScintillaNext *editor) : EditorDecorator(editor), scrollBar(new HighlightedScrollBar(editor, Qt::Vertical, editor)) { - connect(scrollBar, &QScrollBar::valueChanged, editor, &ScintillaEdit::scrollVertical); + connect(scrollBar, &QScrollBar::valueChanged, editor, &ScintillaEditBase::scrollVertical); editor->setVerticalScrollBar(scrollBar); } diff --git a/src/lexilla/README b/src/lexilla/README index d2a1d566d..8459f0387 100644 --- a/src/lexilla/README +++ b/src/lexilla/README @@ -27,12 +27,12 @@ directory conventionally called "lexilla". To use GCC, run lexilla/src/makefile: make -To use Clang, run lexilla/test/makefile: +To use Clang, run lexilla/src/makefile: make CLANG=1 On macOS, CLANG is set automatically so this can just be make -To use MSVC, run lexilla/test/lexilla.mak: +To use MSVC, run lexilla/src/lexilla.mak: nmake -f lexilla.mak To build a debugging version of the library, add DEBUG=1 to the command: diff --git a/src/lexilla/access/LexillaAccess.cxx b/src/lexilla/access/LexillaAccess.cxx index 0d77a8bab..4c0c9f240 100644 --- a/src/lexilla/access/LexillaAccess.cxx +++ b/src/lexilla/access/LexillaAccess.cxx @@ -30,12 +30,12 @@ namespace { #if defined(_WIN32) -typedef FARPROC Function; -typedef HMODULE Module; +using Function = FARPROC; +using Module = HMODULE; constexpr const char *pathSeparator = "\\"; #else -typedef void *Function; -typedef void *Module; +using Function = void *; +using Module = void *; constexpr const char *pathSeparator = "/"; #endif @@ -164,9 +164,10 @@ bool Lexilla::Load(std::string_view sharedLibraryPaths) { if (fnLexerCount && fnLexerName) { const int nLexers = fnLexerCount(); for (int i = 0; i < nLexers; i++) { - char name[100] = ""; + constexpr size_t lengthName = 200; + char name[lengthName]{}; fnLexerName(i, name, sizeof(name)); - lexers.push_back(name); + lexers.emplace_back(name); } } CreateLexerFn fnCL = FunctionPointer( @@ -268,7 +269,7 @@ std::string Lexilla::NameFromID(int identifier) { } } } - return std::string(); + return {}; } std::vector Lexilla::LibraryProperties() { diff --git a/src/lexilla/cppcheck.suppress b/src/lexilla/cppcheck.suppress index 7ad8796a3..e4f56dba6 100644 --- a/src/lexilla/cppcheck.suppress +++ b/src/lexilla/cppcheck.suppress @@ -70,12 +70,14 @@ variableScope:lexilla/lexers/LexCmake.cxx knownConditionTrueFalse:lexilla/lexers/LexCmake.cxx constParameterReference:lexilla/lexers/LexCmake.cxx constParameterReference:lexilla/lexers/LexCOBOL.cxx +constVariablePointer:lexilla/lexers/LexCOBOL.cxx constParameterReference:lexilla/lexers/LexCoffeeScript.cxx constParameterPointer:lexilla/lexers/LexCoffeeScript.cxx knownConditionTrueFalse:lexilla/lexers/LexCoffeeScript.cxx constVariableReference:lexilla/lexers/LexConf.cxx constParameterReference:lexilla/lexers/LexCPP.cxx variableScope:lexilla/lexers/LexCSS.cxx +constVariablePointer:lexilla/lexers/LexCSS.cxx knownConditionTrueFalse:lexilla/lexers/LexDataflex.cxx constParameterReference:lexilla/lexers/LexDataflex.cxx variableScope:lexilla/lexers/LexDataflex.cxx @@ -118,6 +120,7 @@ unreadVariable:lexilla/lexers/LexMatlab.cxx variableScope:lexilla/lexers/LexMatlab.cxx variableScope:lexilla/lexers/LexMetapost.cxx constParameterReference:lexilla/lexers/LexModula.cxx +duplicateBreak:lexilla/lexers/LexModula.cxx variableScope:lexilla/lexers/LexModula.cxx constParameterReference:lexilla/lexers/LexMPT.cxx variableScope:lexilla/lexers/LexMSSQL.cxx @@ -140,6 +143,7 @@ constVariableReference:lexilla/lexers/LexPerl.cxx knownConditionTrueFalse:lexilla/lexers/LexPerl.cxx constParameterReference:lexilla/lexers/LexPLM.cxx constParameterReference:lexilla/lexers/LexPO.cxx +constVariablePointer:lexilla/lexers/LexPOV.cxx constParameterReference:lexilla/lexers/LexPython.cxx shadowVariable:lexilla/lexers/LexPowerPro.cxx knownConditionTrueFalse:lexilla/lexers/LexPowerPro.cxx @@ -167,7 +171,6 @@ constParameterPointer:lexilla/lexers/LexTCMD.cxx invalidscanf:lexilla/lexers/LexTCMD.cxx constParameterReference:lexilla/lexers/LexTeX.cxx variableScope:lexilla/lexers/LexTeX.cxx -constVariableReference:lexilla/lexers/LexTroff.cxx knownConditionTrueFalse:lexilla/lexers/LexVB.cxx constParameterReference:lexilla/lexers/LexVerilog.cxx variableScope:lexilla/lexers/LexVerilog.cxx @@ -188,7 +191,6 @@ constVariableReference:lexilla/lexers/LexX12.cxx constParameterPointer:lexilla/lexers/LexX12.cxx uselessCallsSubstr:lexilla/lexers/LexX12.cxx constParameterReference:lexilla/lexers/LexYAML.cxx -constParameterPointer:lexilla/lexers/LexYAML.cxx knownConditionTrueFalse:lexilla/lexers/LexYAML.cxx // These are due to Accessor::IndentAmount not declaring the callback as taking a const. diff --git a/src/lexilla/doc/Lexilla.html b/src/lexilla/doc/Lexilla.html index f8d4f15da..473a17267 100644 --- a/src/lexilla/doc/Lexilla.html +++ b/src/lexilla/doc/Lexilla.html @@ -9,7 +9,7 @@ - +