Align rejection classification default and guard semantics

Author: davidercruz

__tests__/workers/opportunity/parseOpportunityFeedback.ts

@@ -348,8 +348,8 @@ describe('parseOpportunityFeedback worker', () => {
       where: { opportunityId: testOpportunityId, userId: '1' },
     });
 
-    // Rejection classification should be null (error was handled gracefully)
-    expect(updatedMatch?.rejectionClassification).toBeNull();
+    // Rejection classification should remain empty JSON (error was handled gracefully)
+    expect(updatedMatch?.rejectionClassification).toEqual({});
     // But per-item feedback classification should still be stored
     expect(updatedMatch?.feedback?.[0]?.classification).toBeDefined();
   });

src/migration/1770812936388-AddRejectionClassificationToOpportunityMatch.ts

@@ -10,6 +10,10 @@ export class AddRejectionClassificationToOpportunityMatch1770812936388
       `ALTER TABLE "opportunity_match"
        ADD COLUMN IF NOT EXISTS "rejectionClassification" jsonb`,
     );
+    await queryRunner.query(
+      `ALTER TABLE "opportunity_match"
+       ALTER COLUMN "rejectionClassification" SET DEFAULT '{}'::jsonb`,
+    );
   }
 
   public async down(queryRunner: QueryRunner): Promise<void> {

src/workers/opportunity/parseOpportunityFeedback.ts

@@ -93,7 +93,12 @@ const parseOpportunityFeedback = async ({
     'Successfully parsed opportunity feedback',
   );
 
-  if (match.rejectionClassification) {
+  const hasRejectionClassification =
+    !!match.rejectionClassification &&
+    Array.isArray(match.rejectionClassification.reasons) &&
+    typeof match.rejectionClassification.summary === 'string';
+
+  if (hasRejectionClassification) {
     logger.debug(
       { opportunityId, userId },
       'Rejection feedback already classified',