fix: remove file suffix from user CV blob (#2977)

Author: omBratteng

__tests__/users.ts

@@ -115,11 +115,7 @@ import { identifyUserPersonalizedDigest } from '../src/cio';
 import type { GQLUser } from '../src/schema/users';
 import { cancelSubscription } from '../src/common/paddle';
 import { isPlusMember, SubscriptionCycles } from '../src/paddle';
-import {
-  acceptedResumeExtensions,
-  CoresRole,
-  StreakRestoreCoresPrice,
-} from '../src/types';
+import { CoresRole, StreakRestoreCoresPrice } from '../src/types';
 import {
   UserTransaction,
   UserTransactionProcessor,
@@ -4393,13 +4389,10 @@ describe('mutation deleteUser', () => {
       await client.mutate(MUTATION);
 
       // Verify we requested delete action for every extension supported
-      acceptedResumeExtensions.forEach((ext, index) => {
-        expect(deleteFileFromBucket).toHaveBeenNthCalledWith(
-          index + 1,
-          expect.any(Bucket),
-          `${loggedUser}.${ext}`,
-        );
-      });
+      expect(deleteFileFromBucket).toHaveBeenCalledWith(
+        expect.any(Bucket),
+        loggedUser,
+      );
     });
 
     it('should handle case when user has no resume', async () => {
@@ -4410,13 +4403,10 @@ describe('mutation deleteUser', () => {
       await client.mutate(MUTATION);
 
       // Verify the function was called but no error was thrown
-      acceptedResumeExtensions.forEach((ext, index) => {
-        expect(deleteFileFromBucket).toHaveBeenNthCalledWith(
-          index + 1,
-          expect.any(Bucket),
-          `${loggedUser}.${ext}`,
-        );
-      });
+      expect(deleteFileFromBucket).toHaveBeenCalledWith(
+        expect.any(Bucket),
+        loggedUser,
+      );
 
       // User should still be deleted
       const userOne = await con.getRepository(User).findOneBy({ id: '1' });
@@ -6785,13 +6775,13 @@ describe('add claimable items to user', () => {
 });
 
 describe('mutation uploadResume', () => {
-  const MUTATION = `
-        mutation UploadResume($resume: Upload!) {
-          uploadResume(resume: $resume) {
-            _
-          }
-        }
-      `;
+  const MUTATION = /* GraphQL */ `
+    mutation UploadResume($resume: Upload!) {
+      uploadResume(resume: $resume) {
+        _
+      }
+    }
+  `;
 
   beforeEach(async () => {
     jest.clearAllMocks();
@@ -6832,7 +6822,7 @@ describe('mutation uploadResume', () => {
 
     // Mock the upload function to return a URL
     uploadResumeFromBuffer.mockResolvedValue(
-      `https://storage.cloud.google.com/${RESUMES_BUCKET_NAME}/1.pdf`,
+      `https://storage.cloud.google.com/${RESUMES_BUCKET_NAME}/1`,
     );
 
     // Execute the mutation with a file upload
@@ -6857,7 +6847,7 @@ describe('mutation uploadResume', () => {
 
     // Verify the mocks were called correctly
     expect(uploadResumeFromBuffer).toHaveBeenCalledWith(
-      `${loggedUser}.pdf`,
+      loggedUser,
       expect.any(Object),
     );
   });
@@ -6873,7 +6863,7 @@ describe('mutation uploadResume', () => {
 
     // Mock the upload function to return a URL
     uploadResumeFromBuffer.mockResolvedValue(
-      `https://storage.cloud.google.com/${RESUMES_BUCKET_NAME}/1.docx`,
+      `https://storage.cloud.google.com/${RESUMES_BUCKET_NAME}/1`,
     );
 
     // Execute the mutation with a file upload
@@ -6898,7 +6888,7 @@ describe('mutation uploadResume', () => {
 
     // Verify the mocks were called correctly
     expect(uploadResumeFromBuffer).toHaveBeenCalledWith(
-      `${loggedUser}.docx`,
+      loggedUser,
       expect.any(Object),
     );
   });

src/common/googleCloud.ts

@@ -99,12 +99,7 @@ export const deleteResumeByUserId = async (
     const storage = new Storage();
     const bucket = storage.bucket(bucketName);
 
-    await Promise.all(
-      // delete all possible accepted {id}.{ext} files uploaded by the user
-      acceptedResumeExtensions.map((ext) =>
-        deleteFileFromBucket(bucket, `${userId}.${ext}`),
-      ),
-    );
+    await deleteFileFromBucket(bucket, userId);
 
     logger.info(
       {

src/schema/users.ts

@@ -2528,7 +2528,7 @@ export const resolvers: IResolvers<unknown, BaseContext> = traceResolvers<
       }
 
       // Actual upload using buffer as a stream
-      const filename = `${ctx.userId}.${extension}`;
+      const filename = ctx.userId;
       await uploadResumeFromBuffer(filename, buffer);
 
       return { _: true };