feat: add user job preferences support (#2953)

Author: ilasw

__tests__/users.ts

@@ -142,6 +142,12 @@ import * as googleCloud from '../src/common/googleCloud';
 import { RESUMES_BUCKET_NAME } from '../src/common/googleCloud';
 import { fileTypeFromBuffer } from './setup';
 import { Bucket } from '@google-cloud/storage';
+import { UserWorkExperience } from '../src/entity/user/experiences/UserWorkExperience';
+import { ExperienceStatus } from '../src/entity/user/experiences/types';
+import {
+  UserJobPreferences,
+  WorkLocationType,
+} from '../src/entity/user/UserJobPreferences';
 
 jest.mock('../src/common/geo', () => ({
   ...(jest.requireActual('../src/common/geo') as Record<string, unknown>),
@@ -6991,3 +6997,301 @@ describe('mutation uploadResume', () => {
     expect(body.errors[0].message).toEqual('File type not supported');
   });
 });
+
+describe('user job preferences', () => {
+  const QUERY = `
+    query UserJobPreferences {
+      userJobPreferences {
+        openToOpportunities
+        preferredRoles
+        preferredLocationType
+        openToRelocation
+        currentTotalComp {
+          currency
+          amount
+        }
+      }
+    }
+  `;
+
+  beforeEach(async () => {
+    // Set up a user with job preferences
+    await con.getRepository(UserJobPreferences).save({
+      userId: '1',
+      openToOpportunities: true,
+      preferredRoles: ['Software Engineer', 'Frontend Developer'],
+      preferredLocationType: 'remote',
+      openToRelocation: false,
+      currentTotalComp: {
+        currency: 'USD',
+        amount: 10,
+      },
+    });
+
+    await saveFixtures(con, UserJobPreferences, [
+      {
+        userId: '1',
+        openToOpportunities: true,
+        preferredRoles: ['Software Engineer', 'Frontend Developer'],
+        preferredLocationType: WorkLocationType.Remote,
+        openToRelocation: false,
+        currentTotalComp: {
+          currency: 'USD',
+          amount: 10,
+        },
+      },
+      {
+        userId: '2',
+        openToOpportunities: true,
+        preferredRoles: [],
+        preferredLocationType: WorkLocationType.Remote,
+        openToRelocation: false,
+        currentTotalComp: {
+          currency: 'USD',
+          amount: 10,
+        },
+      },
+    ]);
+
+    // Set up a user with a complete profile
+    await con.getRepository(User).update('1', {
+      flags: {
+        country: 'US',
+      },
+    });
+
+    // Add work experience to make sure profile is complete
+    await saveFixtures(con, UserWorkExperience, [
+      {
+        userId: '1',
+        title: 'Software Engineer',
+        status: ExperienceStatus.Published,
+        description: '',
+        startDate: new Date(),
+      },
+      {
+        userId: '1',
+        title: 'Senior Software Engineer',
+        status: ExperienceStatus.Published,
+        description: '',
+        startDate: new Date(),
+      },
+      {
+        userId: '1',
+        title: 'Software Developer',
+        status: ExperienceStatus.Published,
+        description: '',
+        startDate: new Date(),
+      },
+      {
+        userId: '1',
+        title: 'Frontend Developer',
+        status: ExperienceStatus.Published,
+        description: '',
+        startDate: new Date(),
+      },
+      {
+        userId: '1',
+        title: 'Draft Job Title',
+        status: ExperienceStatus.Draft,
+        description: '',
+        startDate: new Date(),
+      },
+    ]);
+  });
+
+  describe('query userJobPreferences', () => {
+    it('should throw error on query as guest', async () => {
+      return testQueryErrorCode(client, { query: QUERY }, 'UNAUTHENTICATED');
+    });
+
+    it('should return user job preferences', async () => {
+      loggedUser = '1';
+      const res = await client.query(QUERY);
+      expect(res.errors).toBeFalsy();
+      expect(res.data.userJobPreferences).toMatchObject({
+        openToOpportunities: true,
+        preferredRoles: ['Software Engineer', 'Frontend Developer'],
+        preferredLocationType: 'remote',
+        openToRelocation: false,
+        currentTotalComp: {
+          currency: 'USD',
+          amount: 10,
+        },
+      });
+    });
+
+    it('should force openToOpportunities to false if profile is not complete', async () => {
+      loggedUser = '2'; // User without job preferences
+      const res = await client.query(QUERY);
+      expect(res.errors).toBeFalsy();
+      expect(res.data.userJobPreferences).toMatchObject({
+        // fetched as false even if is true on preferences since have no experiences
+        openToOpportunities: false,
+        preferredRoles: [],
+        preferredLocationType: WorkLocationType.Remote,
+        openToRelocation: false,
+        currentTotalComp: {},
+      });
+    });
+  });
+
+  describe('mutation updateUserJobPreferences', () => {
+    const MUTATION = `
+    mutation UpdateUserJobPreferences(
+      $openToOpportunities: Boolean!
+      $preferredRoles: [String!]!
+      $preferredLocationType: String
+      $openToRelocation: Boolean!
+      $currentTotalComp: UserTotalCompensationInput!
+    ) {
+      updateUserJobPreferences(
+        openToOpportunities: $openToOpportunities
+        preferredRoles: $preferredRoles
+        preferredLocationType: $preferredLocationType
+        openToRelocation: $openToRelocation
+        currentTotalComp: $currentTotalComp
+      ) {
+        openToOpportunities
+        preferredRoles
+        preferredLocationType
+        openToRelocation
+        currentTotalComp {
+          currency
+          amount
+        }
+      }
+    }
+  `;
+
+    it('should throw error on mutation as guest', async () => {
+      return testMutationErrorCode(
+        client,
+        {
+          mutation: MUTATION,
+          variables: {
+            openToOpportunities: true,
+            preferredRoles: ['Software Engineer'],
+            preferredLocationType: 'remote',
+            openToRelocation: false,
+            currentTotalComp: {},
+          },
+        },
+        'UNAUTHENTICATED',
+      );
+    });
+
+    it('should update user job preferences', async () => {
+      loggedUser = '1';
+      const variables = {
+        openToOpportunities: false,
+        preferredRoles: ['Product Manager', 'Project Manager'],
+        preferredLocationType: WorkLocationType.Remote,
+        openToRelocation: true,
+        currentTotalComp: {
+          currency: 'EUR',
+          amount: 10,
+        },
+      };
+
+      const res = await client.mutate(MUTATION, { variables });
+      expect(res.errors).toBeFalsy();
+      expect(res.data.updateUserJobPreferences).toMatchObject({
+        openToOpportunities: false,
+        preferredRoles: ['Product Manager', 'Project Manager'],
+        preferredLocationType: WorkLocationType.Remote,
+        openToRelocation: true,
+        currentTotalComp: {
+          currency: 'EUR',
+          amount: 10,
+        },
+      });
+
+      // Verify database state
+      const updatedPrefs = await con
+        .getRepository('UserJobPreferences')
+        .findOne({
+          where: { userId: '1' },
+        });
+      expect(updatedPrefs).toMatchObject({
+        openToOpportunities: false,
+        preferredRoles: ['Product Manager', 'Project Manager'],
+        preferredLocationType: WorkLocationType.Remote,
+        openToRelocation: true,
+        currentTotalComp: {
+          currency: 'EUR',
+          amount: 10,
+        },
+      });
+    });
+
+    it('should throw error on invalid job preferences', async () => {
+      loggedUser = '1';
+
+      // Test with too many preferred roles
+      const variables = {
+        openToOpportunities: true,
+        preferredRoles: [
+          'Role 1',
+          'Role 2',
+          'Role 3',
+          'Role 4',
+          'Role 5',
+          'Role 6',
+        ],
+        preferredLocationType: 'remote',
+        openToRelocation: false,
+        currentTotalComp: {},
+      };
+
+      return testMutationErrorCode(
+        client,
+        { mutation: MUTATION, variables },
+        'GRAPHQL_VALIDATION_FAILED',
+        'Invalid job preferences data. Please check your input.',
+      );
+    });
+
+    it('should not update user job preferences of other user', async () => {
+      // Create job preferences for user 2
+      await con.getRepository('UserJobPreferences').save({
+        userId: '2',
+        openToOpportunities: false,
+        preferredRoles: ['Designer'],
+        preferredLocationType: 'on_site',
+        openToRelocation: true,
+        currentTotalComp: {
+          currency: 'GBP',
+          amount: 20,
+        },
+      });
+
+      // Log in as user 1
+      loggedUser = '1';
+
+      // Try to update user 2's preferences by setting userId
+      const variables = {
+        userId: '2', // This should be ignored
+        openToOpportunities: true,
+        preferredRoles: ['Hacker'],
+        preferredLocationType: 'remote',
+        openToRelocation: false,
+        currentTotalComp: {},
+      };
+
+      const res = await client.mutate(MUTATION, { variables });
+      expect(res.errors).toBeFalsy();
+
+      // Verify that user 1's preferences were updated, not user 2's
+      const user1Prefs = await con.getRepository('UserJobPreferences').findOne({
+        where: { userId: '1' },
+      });
+      expect(user1Prefs?.preferredRoles).toContain('Hacker');
+
+      const user2Prefs = await con.getRepository('UserJobPreferences').findOne({
+        where: { userId: '2' },
+      });
+      expect(user2Prefs?.preferredRoles).toEqual(['Designer']);
+    });
+  });
+});

src/common/users.ts

@@ -21,6 +21,12 @@ import { queryReadReplica } from './queryReadReplica';
 import { logger } from '../logger';
 import type { GQLKeyword } from '../schema/keywords';
 import type { GQLUser } from '../schema/users';
+import {
+  ExperienceStatus,
+  UserExperienceType,
+} from '../entity/user/experiences/types';
+import { z } from 'zod';
+import { WorkLocationType } from '../entity/user/UserJobPreferences';
 
 export interface User {
   id: string;
@@ -636,3 +642,69 @@ export const bskySocialUrlMatch =
   /^(?:(?:https:\/\/)?(?:www\.)?bsky\.app\/profile\/)?(?<value>[\w.-]+)(?:\/.*)?$/;
 
 export const portfolioLimit = 500;
+
+const MIN_WORK_EXPERIENCE = 1; // Minimum number of work experiences required for profile completion
+export const isProfileCompleteById = async (
+  con: DataSource,
+  userId: User['id'],
+) => {
+  try {
+    const [user, experiencesCount] = await queryReadReplica(
+      con,
+      ({ queryRunner }) =>
+        Promise.all([
+          queryRunner.manager
+            .getRepository('User')
+            .findOneByOrFail({ id: userId }),
+          queryRunner.manager.getRepository('UserExperience').count({
+            where: {
+              userId,
+              type: In([UserExperienceType.Work, UserExperienceType.Education]),
+              status: ExperienceStatus.Published,
+            },
+          }),
+        ]),
+    );
+
+    const hasCountry =
+      typeof user.flags.country === 'string' && user.flags.country.length >= 2;
+    const hasEnoughExperiences = experiencesCount >= MIN_WORK_EXPERIENCE;
+
+    return hasCountry && hasEnoughExperiences;
+  } catch {
+    return false;
+  }
+};
+
+const jobPreferenceUpdateValidation = z.object({
+  openToOpportunities: z.boolean().optional().default(false),
+  preferredRoles: z
+    .array(
+      z
+        .string()
+        .min(3, 'Preferred roles must be at least 3 characters long')
+        .max(50, 'Preferred roles must be at most 50 characters long'),
+    )
+    .max(5, 'Preferred roles can have a maximum of 5 items')
+    .optional()
+    .default([]),
+  preferredLocationType: z.nativeEnum(WorkLocationType).optional(),
+  openToRelocation: z.boolean().optional().default(false),
+  currentTotalComp: z
+    .object({
+      currency: z.string().length(3),
+      amount: z.number().int().positive(),
+    })
+    .partial()
+    .default({}),
+});
+export const checkJobPreferenceParamsValidity = (params: unknown) => {
+  const result = jobPreferenceUpdateValidation.safeParse(params);
+  if (!result.success) {
+    logger.error(
+      { error: result.error, params },
+      'Invalid job preference update parameters',
+    );
+  }
+  return result;
+};