Merge branch 'main' into MI-949

Author: AmarTrebinjac

__tests__/__snapshots__/submissions.ts.snap

@@ -3100,14 +3100,19 @@ describe('query boostEstimatedReachDaily', () => {
         impressions: 100,
         clicks: 5,
         users: 50,
+        min_impressions: 45,
+        max_impressions: 55,
       });
 
       const res = await client.query(QUERY, {
         variables: { ...params, budget: 2000, duration: 5 }, // Valid budget
       });
 
       expect(res.errors).toBeFalsy();
-      expect(res.data.boostEstimatedReachDaily).toBeDefined();
+      expect(res.data.boostEstimatedReachDaily).toEqual({
+        min: 45,
+        max: 55,
+      });
 
       // Verify the HTTP call was made with correct budget conversion
       expect(mockFetchParse).toHaveBeenCalledWith(
@@ -3157,14 +3162,19 @@ describe('query boostEstimatedReachDaily', () => {
         impressions: 200,
         clicks: 10,
         users: 75,
+        min_impressions: 68,
+        max_impressions: 82,
       });
 
       const res = await client.query(QUERY, {
         variables: { ...params, budget: 3000, duration: 15 }, // Valid duration
       });
 
       expect(res.errors).toBeFalsy();
-      expect(res.data.boostEstimatedReachDaily).toBeDefined();
+      expect(res.data.boostEstimatedReachDaily).toEqual({
+        min: 68,
+        max: 82,
+      });
 
       // Verify the HTTP call includes both parameters correctly
       expect(mockFetchParse).toHaveBeenCalledWith(
@@ -3195,6 +3205,8 @@ describe('query boostEstimatedReachDaily', () => {
       impressions: 500,
       clicks: 40,
       users: 180,
+      min_impressions: 166,
+      max_impressions: 194,
     });
 
     const res = await client.query(QUERY, {
@@ -3203,8 +3215,8 @@ describe('query boostEstimatedReachDaily', () => {
 
     expect(res.errors).toBeFalsy();
     expect(res.data.boostEstimatedReachDaily).toEqual({
-      max: 194, // 180 + Math.floor(180 * 0.08) = 180 + 14 = 194
-      min: 166, // 180 - Math.floor(180 * 0.08) = 180 - 14 = 166
+      min: 166,
+      max: 194,
     });
 
     // Verify the HTTP call was made correctly with both parameters
@@ -3235,6 +3247,8 @@ describe('query boostEstimatedReachDaily', () => {
       impressions: 50,
       clicks: 3,
       users: 25,
+      min_impressions: 23,
+      max_impressions: 27,
     });
 
     const res = await client.query(QUERY, {
@@ -3243,8 +3257,8 @@ describe('query boostEstimatedReachDaily', () => {
 
     expect(res.errors).toBeFalsy();
     expect(res.data.boostEstimatedReachDaily).toEqual({
-      max: 27, // 25 + Math.floor(25 * 0.08) = 25 + 2 = 27
-      min: 23, // 25 - Math.floor(25 * 0.08) = 25 - 2 = 23
+      min: 23,
+      max: 27,
     });
 
     // Verify the HTTP call was made with minimum budget
@@ -3275,6 +3289,8 @@ describe('query boostEstimatedReachDaily', () => {
       impressions: 50000,
       clicks: 2500,
       users: 15000,
+      min_impressions: 13800,
+      max_impressions: 16200,
     });
 
     const res = await client.query(QUERY, {
@@ -3283,8 +3299,8 @@ describe('query boostEstimatedReachDaily', () => {
 
     expect(res.errors).toBeFalsy();
     expect(res.data.boostEstimatedReachDaily).toEqual({
-      max: 16200, // 15000 + Math.floor(15000 * 0.08) = 15000 + 1200 = 16200
-      min: 13800, // 15000 - Math.floor(15000 * 0.08) = 15000 - 1200 = 13800
+      min: 13800,
+      max: 16200,
     });
 
     // Verify the HTTP call was made with maximum budget
@@ -3315,6 +3331,8 @@ describe('query boostEstimatedReachDaily', () => {
       impressions: 80,
       clicks: 5,
       users: 35,
+      min_impressions: 33,
+      max_impressions: 37,
     });
 
     const res = await client.query(QUERY, {
@@ -3323,8 +3341,8 @@ describe('query boostEstimatedReachDaily', () => {
 
     expect(res.errors).toBeFalsy();
     expect(res.data.boostEstimatedReachDaily).toEqual({
-      max: 37, // 35 + Math.floor(35 * 0.08) = 35 + 2 = 37
-      min: 33, // 35 - Math.floor(35 * 0.08) = 35 - 2 = 33
+      min: 33,
+      max: 37,
     });
 
     // Verify the HTTP call was made with minimum duration
@@ -3355,6 +3373,8 @@ describe('query boostEstimatedReachDaily', () => {
       impressions: 1200,
       clicks: 60,
       users: 450,
+      min_impressions: 414,
+      max_impressions: 486,
     });
 
     const res = await client.query(QUERY, {
@@ -3363,8 +3383,8 @@ describe('query boostEstimatedReachDaily', () => {
 
     expect(res.errors).toBeFalsy();
     expect(res.data.boostEstimatedReachDaily).toEqual({
-      max: 486, // 450 + Math.floor(450 * 0.08) = 450 + 36 = 486
-      min: 414, // 450 - Math.floor(450 * 0.08) = 450 - 36 = 414
+      min: 414,
+      max: 486,
     });
 
     // Verify the HTTP call was made with maximum duration
@@ -3404,6 +3424,8 @@ describe('query boostEstimatedReachDaily', () => {
       impressions: 150,
       clicks: 10,
       users: 65,
+      min_impressions: 60,
+      max_impressions: 70,
     });
 
     const res = await client.query(QUERY, {
@@ -3412,8 +3434,8 @@ describe('query boostEstimatedReachDaily', () => {
 
     expect(res.errors).toBeFalsy();
     expect(res.data.boostEstimatedReachDaily).toEqual({
-      max: 70, // 65 + Math.floor(65 * 0.08) = 65 + 5 = 70
-      min: 60, // 65 - Math.floor(65 * 0.08) = 65 - 5 = 60
+      min: 60,
+      max: 70,
     });
 
     // Verify the HTTP call was made with correct parameters
@@ -3434,4 +3456,48 @@ describe('query boostEstimatedReachDaily', () => {
       },
     );
   });
+
+  it('should fall back to getAdjustedReach when min and max impressions are equal', async () => {
+    loggedUser = '1';
+
+    // Mock the HTTP response where min and max impressions are the same
+    const mockFetchParse = fetchParse as jest.Mock;
+    mockFetchParse.mockResolvedValue({
+      impressions: 200,
+      clicks: 15,
+      users: 100,
+      min_impressions: 75, // Same value
+      max_impressions: 75, // Same value
+    });
+
+    const res = await client.query(QUERY, {
+      variables: { ...params, budget: 4000, duration: 10 }, // 4000 cores = 40 USD, 10 days
+    });
+
+    expect(res.errors).toBeFalsy();
+    // When min_impressions === max_impressions, it should use getAdjustedReach(maxImpressions)
+    // getAdjustedReach applies ±8% calculation: 75 ± Math.floor(75 * 0.08) = 75 ± 6
+    expect(res.data.boostEstimatedReachDaily).toEqual({
+      min: 69, // 75 - Math.floor(75 * 0.08) = 75 - 6 = 69
+      max: 81, // 75 + Math.floor(75 * 0.08) = 75 + 6 = 81
+    });
+
+    // Verify the HTTP call was made with correct parameters
+    expect(mockFetchParse).toHaveBeenCalledWith(
+      `${process.env.SKADI_API_ORIGIN}/promote/post/reach`,
+      {
+        method: 'POST',
+        headers: {
+          'Content-Type': 'application/json',
+        },
+        body: JSON.stringify({
+          post_id: 'p1',
+          user_id: '1',
+          duration: 10 * ONE_DAY_IN_SECONDS,
+          budget: 40, // Converted from cores to USD (4000 cores = 40 USD)
+        }),
+        agent: expect.any(Function),
+      },
+    );
+  });
 });