one bug fix, but still in progress

Author: strasserle

src/app/routes/browse/form/form.component.ts

@@ -7,6 +7,7 @@ import {
   inject,
   input,
   linkedSignal,
+  OnInit,
   signal,
   viewChild,
 } from '@angular/core';
@@ -56,7 +57,7 @@ import { MatCardModule } from '@angular/material/card';
   templateUrl: './form.component.html',
   styleUrl: './form.component.scss',
 })
-export class FormComponent {
+export class FormComponent implements OnInit {
   versionsService = inject(VersionsService);
   browseService = input.required<BrowseService>();
   version = this.versionsService.versionReadOnly();
@@ -83,7 +84,7 @@ export class FormComponent {
       Validators.min(0),
       Validators.max(100),
     ]),
-    minDegree: new FormControl<number>(1, [
+    minDegree: new FormControl<number>(0, [
       Validators.min(0),
       Validators.max(100),
     ]),
@@ -114,6 +115,17 @@ export class FormComponent {
 
   protected readonly capitalize = _.capitalize;
 
+  ngOnInit() {
+    // if specific defaults are set (eg spongeffects) 
+    this.formGroup.patchValue({
+      minDegree: this.defaultMinDegree(),
+      minBetweenness: this.defaultMinBetweenness() ?? 0.05,
+      minEigen: this.defaultMinEigen() ?? 0.1,
+      maxPValue: this.defaultMaxPValue() ?? 0.05,
+      minMscor: this.defaultMinMscor() ?? 0.1,
+    });
+  }
+
   constructor(private cdr: ChangeDetectorRef) {
     const formSignal = signal(this.formGroup.value);
     this.formGroup.valueChanges.subscribe((val) => {
@@ -153,24 +165,6 @@ export class FormComponent {
       this.infoService.renderMscorEquation(this.mscorEquation$()!);
     });
   }
-ngOnInit() {
-  // Always set the form control values from the inputs
-  if (this.defaultMinBetweenness() !== undefined) {
-    this.formGroup.get('minBetweenness')?.setValue(this.defaultMinBetweenness() ?? null);
-  }
-  if (this.defaultMinDegree() !== undefined) {
-    this.formGroup.get('minDegree')?.setValue(this.defaultMinDegree() ?? null);
-  }
-  if (this.defaultMinEigen() !== undefined) {
-    this.formGroup.get('minEigen')?.setValue(this.defaultMinEigen() ?? null);
-  }
-  if (this.defaultMaxPValue() !== undefined) {
-    this.formGroup.get('maxPValue')?.setValue(this.defaultMaxPValue() ?? null);
-  }
-  if (this.defaultMinMscor() !== undefined) {
-    this.formGroup.get('minMscor')?.setValue(this.defaultMinMscor() ?? null);
-  }
-}
 
   getKeys(enumType: any): string[] {
     return Object.keys(enumType);

src/app/routes/spongeffects/explore/explore.component.html

@@ -5,12 +5,12 @@
       <hr style="margin: 266.5px 0 20px 0; width: 100%;" />
       <app-form 
         [browseService]="browseService" 
-        [fixedDataset]="exploreService.selectedDiseaseObject$()">
+        [fixedDataset]="exploreService.selectedDiseaseObject$()"
         [defaultMinBetweenness]="0"
         [defaultMinDegree]="1"
         [defaultMinEigen]="0"
-        [defaultMaxPValue]="1"
-        [defaultMinMscor]="0"
+        [defaultMaxPValue]="0.2"
+        [defaultMinMscor]="0.1"
       >
       </app-form>    
     }