Skip to content

Commit 604908d

Browse files
Merge pull request #156 from daisybio/consolidation_fix
Consolidation fix
2 parents 151b124 + ea62b2d commit 604908d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

drevalpy/experiment.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ def drug_response_experiment(
282282
models=models,
283283
n_cv_splits=n_cv_splits,
284284
results_path=result_path,
285-
cross_study_datasets=cross_study_datasets,
285+
cross_study_datasets=[cs.dataset_name for cs in cross_study_datasets],
286286
randomization_mode=randomization_mode,
287287
n_trials_robustness=n_trials_robustness,
288288
out_path=result_path,
@@ -295,7 +295,7 @@ def consolidate_single_drug_model_predictions(
295295
models: list[type[DRPModel]],
296296
n_cv_splits: int,
297297
results_path: str,
298-
cross_study_datasets: list[DrugResponseDataset],
298+
cross_study_datasets: list[str],
299299
randomization_mode: list[str] | None = None,
300300
n_trials_robustness: int = 0,
301301
out_path: str = "",
@@ -357,10 +357,10 @@ def consolidate_single_drug_model_predictions(
357357
# Cross study predictions
358358
for cross_study_dataset in cross_study_datasets:
359359
cross_study_prediction_path = os.path.join(single_drug_prediction_path, "cross_study")
360-
f = f"cross_study_{cross_study_dataset.dataset_name}_split_{split}.csv"
361-
if cross_study_dataset.dataset_name not in predictions["cross_study"]:
362-
predictions["cross_study"][cross_study_dataset.dataset_name] = []
363-
predictions["cross_study"][cross_study_dataset.dataset_name].append(
360+
f = f"cross_study_{cross_study_dataset}_split_{split}.csv"
361+
if cross_study_dataset not in predictions["cross_study"]:
362+
predictions["cross_study"][cross_study_dataset] = []
363+
predictions["cross_study"][cross_study_dataset].append(
364364
pd.read_csv(
365365
os.path.join(cross_study_prediction_path, f),
366366
index_col=0,

0 commit comments

Comments
 (0)