Merge pull request #116 from dalek-cryptography/clippy-fixes

Bump nightly, apply some clippy fixes

Author: hdevalence

rust-toolchain

@@ -1 +1 @@
-nightly-2018-07-08
+nightly-2018-07-16

src/inner_product_proof.rs

@@ -109,12 +109,12 @@ impl InnerProductProof {
             H = H_L;
         }
 
-        return InnerProductProof {
+        InnerProductProof {
             L_vec: L_vec,
             R_vec: R_vec,
             a: a[0],
             b: b[0],
-        };
+        }
     }
 
     /// Computes three vectors of verification scalars \\([u\_{i}^{2}]\\), \\([u\_{i}^{-2}]\\) and \\([s\_{i}]\\) for combined multiscalar multiplication

src/range_proof/mod.rs

@@ -341,7 +341,7 @@ impl<'de> Deserialize<'de> for RangeProof {
             where
                 E: serde::de::Error,
             {
-                RangeProof::from_bytes(v).map_err(|e| serde::de::Error::custom(e))
+                RangeProof::from_bytes(v).map_err(serde::de::Error::custom)
             }
         }
 

src/range_proof/party.rs

@@ -33,7 +33,7 @@ impl Party {
             .commit(Scalar::from_u64(v), v_blinding);
 
         Ok(PartyAwaitingPosition {
-            generators: generators,
+            generators,
             n,
             v,
             v_blinding,
@@ -149,7 +149,7 @@ impl<'a> PartyAwaitingValueChallenge<'a> {
             r_poly.0[i] = exp_y * (a_R_i + vc.z) + zz * offset_z * exp_2;
             r_poly.1[i] = exp_y * self.s_R[i];
 
-            exp_y = exp_y * vc.y; // y^i -> y^(i+1)
+            exp_y *= vc.y; // y^i -> y^(i+1)
             exp_2 = exp_2 + exp_2; // 2^i -> 2^(i+1)
         }