test: add tests for new model selection

Author: damassi

CLAUDE.md

@@ -8,6 +8,7 @@
 - Run commands should be prefixed with `uv`: `uv run ...`
 - Use `asyncio` features, if such is needed
 - Prefer early returns
+- Private methods always go below public methods
 - Absolutely no useless comments! Every class and method does not need to be documented (unless it is legitimetly complex or "lib-ish")
 - Imports belong at the top of files, not inside functions (unless needed to avoid circular imports)
 

src/agent_chat_cli/components/chat_history.py

@@ -13,8 +13,8 @@
 
 class ChatHistory(Container):
     def add_message(self, message: Message) -> None:
-        widget = self._create_message(message)
-        self.mount(widget)
+        message_item = self._create_message(message)
+        self.mount(message_item)
 
     def _create_message(
         self, message: Message

src/agent_chat_cli/components/model_selection_menu.py

@@ -10,9 +10,9 @@
     from agent_chat_cli.core.actions import Actions
 
 MODELS = [
-    {"id": "opus", "label": "Opus"},
     {"id": "sonnet", "label": "Sonnet"},
     {"id": "haiku", "label": "Haiku"},
+    {"id": "opus", "label": "Opus"},
 ]
 
 

src/agent_chat_cli/core/styles.tcss

@@ -108,34 +108,17 @@ TextArea .text-area--cursor {
     padding-left: 2;
 }
 
-SlashCommandMenu {
+SlashCommandMenu, ModelSelectionMenu {
     height: auto;
     max-height: 10;
     display: none;
 }
 
-SlashCommandMenu.visible {
+SlashCommandMenu.visible, ModelSelectionMenu.visible {
     display: block;
 }
 
-SlashCommandMenu OptionList {
-    height: auto;
-    max-height: 10;
-    border: solid $primary;
-    background: transparent;
-}
-
-ModelSelectionMenu {
-    height: auto;
-    max-height: 10;
-    display: none;
-}
-
-ModelSelectionMenu.visible {
-    display: block;
-}
-
-ModelSelectionMenu OptionList {
+SlashCommandMenu OptionList, ModelSelectionMenu OptionList {
     height: auto;
     max-height: 10;
     border: solid $primary;

tests/components/test_model_selection_menu.py

@@ -0,0 +1,97 @@
+import pytest
+from unittest.mock import AsyncMock, MagicMock
+
+from textual.app import App, ComposeResult
+from textual.widgets import OptionList
+
+from agent_chat_cli.components.model_selection_menu import ModelSelectionMenu
+
+
+class ModelSelectionMenuApp(App):
+    def __init__(self):
+        super().__init__()
+        self.mock_actions = MagicMock()
+        self.mock_actions.change_model = AsyncMock()
+
+    def compose(self) -> ComposeResult:
+        yield ModelSelectionMenu(actions=self.mock_actions)
+
+
+class TestModelSelectionMenuVisibility:
+    @pytest.fixture
+    def app(self):
+        return ModelSelectionMenuApp()
+
+    async def test_hidden_by_default(self, app):
+        async with app.run_test():
+            menu = app.query_one(ModelSelectionMenu)
+
+            assert menu.is_visible is False
+
+    async def test_show_makes_visible(self, app):
+        async with app.run_test():
+            menu = app.query_one(ModelSelectionMenu)
+            menu.show()
+
+            assert menu.is_visible is True
+
+    async def test_hide_makes_invisible(self, app):
+        async with app.run_test():
+            menu = app.query_one(ModelSelectionMenu)
+            menu.show()
+            menu.hide()
+
+            assert menu.is_visible is False
+
+    async def test_show_highlights_first_option(self, app):
+        async with app.run_test():
+            menu = app.query_one(ModelSelectionMenu)
+            menu.show()
+
+            option_list = menu.query_one(OptionList)
+            assert option_list.highlighted == 0
+
+
+class TestModelSelectionMenuSelection:
+    @pytest.fixture
+    def app(self):
+        return ModelSelectionMenuApp()
+
+    async def test_sonnet_command_calls_change_model(self, app):
+        async with app.run_test() as pilot:
+            menu = app.query_one(ModelSelectionMenu)
+            menu.show()
+
+            await pilot.press("enter")
+
+            app.mock_actions.change_model.assert_called_once_with("sonnet")
+
+    async def test_haiku_command_calls_change_model(self, app):
+        async with app.run_test() as pilot:
+            menu = app.query_one(ModelSelectionMenu)
+            menu.show()
+
+            await pilot.press("down")
+            await pilot.press("enter")
+
+            app.mock_actions.change_model.assert_called_once_with("haiku")
+
+    async def test_opus_command_calls_change_model(self, app):
+        async with app.run_test() as pilot:
+            menu = app.query_one(ModelSelectionMenu)
+            menu.show()
+
+            await pilot.press("down")
+            await pilot.press("down")
+            await pilot.press("enter")
+
+            app.mock_actions.change_model.assert_called_once_with("opus")
+
+    async def test_selection_hides_menu(self, app):
+        async with app.run_test() as pilot:
+            menu = app.query_one(ModelSelectionMenu)
+            menu.show()
+
+            await pilot.press("enter")
+
+            assert menu.is_visible is False

tests/components/test_slash_command_menu.py

@@ -15,6 +15,7 @@ def __init__(self):
         self.mock_actions.clear = AsyncMock()
         self.mock_actions.new = AsyncMock()
         self.mock_actions.save = AsyncMock()
+        self.mock_actions.show_model_menu = MagicMock()
 
     def compose(self) -> ComposeResult:
         yield SlashCommandMenu(actions=self.mock_actions)
@@ -79,6 +80,17 @@ async def test_clear_command_calls_clear(self, app):
 
             app.mock_actions.clear.assert_called_once()
 
+    async def test_model_command_calls_show_model_menu(self, app):
+        async with app.run_test() as pilot:
+            menu = app.query_one(SlashCommandMenu)
+            menu.show()
+
+            await pilot.press("down")
+            await pilot.press("down")
+            await pilot.press("enter")
+
+            app.mock_actions.show_model_menu.assert_called_once()
+
     async def test_exit_command_calls_quit(self, app):
         async with app.run_test() as pilot:
             menu = app.query_one(SlashCommandMenu)
@@ -87,6 +99,7 @@ async def test_exit_command_calls_quit(self, app):
             await pilot.press("down")
             await pilot.press("down")
             await pilot.press("down")
+            await pilot.press("down")
             await pilot.press("enter")
 
             app.mock_actions.quit.assert_called_once()