PR comments done

Author: pwilleme

projects/angular-auth-oidc-client/src/lib/config/openid-configuration.ts

@@ -177,7 +177,7 @@ export interface OpenIdConfiguration {
   allowUnsafeReuseRefreshToken?: boolean;
   /** Disable validation for id_token expiry time */
   disableIdTokenValidation?: boolean;
-  /** Disabled PKCE support.
+  /** Disables PKCE support.
    * Authorize request will be sent without code challenge.
    */
   disablePkce?: boolean;

projects/angular-auth-oidc-client/src/lib/utils/url/url.service.ts

@@ -486,9 +486,14 @@ export class UrlService {
   }
 
   private getCodeChallenge(config: OpenIdConfiguration): Observable<string> {
-    if (config.disablePkce) return of(null);
+
+    if (config.disablePkce) {
+      return of(null);
+    }
+
     // code_challenge with "S256"
     const codeVerifier = this.flowsDataService.createCodeVerifier(config);
+
     return this.jwtWindowCryptoService.generateCodeChallenge(codeVerifier);
   }