fix: also fix CI-generated installer and deduplicate .iss config

The CI workflow in rust.yml generated its own .iss file inline with the
same {pf} bug, so the previous commit only fixed local builds. This
removes the inline generation and has CI pass /DBuildArch to the shared
scripts/windows-installer.iss via Inno Setup preprocessor defines.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: alltheseas

.github/workflows/rust.yml

@@ -231,37 +231,10 @@ jobs:
           Write-Output "Building for target: $target"
           cargo build --release --target=$target
 
-      # Generate ISS Script
-      - name: Generate Inno Setup Script
-        shell: pwsh
-        run: |
-          $arch = "${{ matrix.arch }}"
-          $issContent = @"
-          [Setup]
-          AppName=Damus Notedeck
-          AppVersion=0.1
-          DefaultDirName={pf}\Notedeck
-          DefaultGroupName=Damus Notedeck
-          OutputDir=..\packages\$arch
-          OutputBaseFilename=DamusNotedeckInstaller
-          Compression=lzma
-          SolidCompression=yes
-
-          [Files]
-          Source: "..\target\$arch-pc-windows-msvc\release\notedeck.exe"; DestDir: "{app}"; Flags: ignoreversion
-
-          [Icons]
-          Name: "{group}\Damus Notedeck"; Filename: "{app}\notedeck.exe"
-
-          [Run]
-          Filename: "{app}\notedeck.exe"; Description: "Launch Damus Notedeck"; Flags: nowait postinstall skipifsilent
-          "@
-          Set-Content -Path "scripts/windows-installer-$arch.iss" -Value $issContent
-
       # Build Installer
       - name: Run Inno Setup Script
         run: |
-          & "C:\Program Files (x86)\Inno Setup 6\ISCC.exe" "scripts\windows-installer-${{ matrix.arch }}.iss"
+          & "C:\Program Files (x86)\Inno Setup 6\ISCC.exe" /DBuildArch=${{ matrix.arch }} "scripts\windows-installer.iss"
 
       # Move output
       - name: Move Inno Script outputs to architecture-specific folder

scripts/windows-installer.iss

@@ -1,17 +1,29 @@
+#ifndef BuildArch
+  #define BuildArch ""
+#endif
+
+#if BuildArch != ""
+  #define ExeSource "..\target\" + BuildArch + "-pc-windows-msvc\release\notedeck.exe"
+  #define PkgOutputDir "..\packages\" + BuildArch
+#else
+  #define ExeSource "..\target\release\notedeck.exe"
+  #define PkgOutputDir "..\packages"
+#endif
+
 [Setup]
 AppName=Damus Notedeck
 AppVersion=0.1
 DefaultDirName={autopf}\Notedeck
 DefaultGroupName=Damus Notedeck
-OutputDir=..\packages
+OutputDir={#PkgOutputDir}
 OutputBaseFilename=DamusNotedeckInstaller
 Compression=lzma
 SolidCompression=yes
 ArchitecturesAllowed=x64compatible
 ArchitecturesInstallIn64BitMode=x64compatible
 
 [Files]
-Source: "..\target\release\notedeck.exe"; DestDir: "{app}"; Flags: ignoreversion
+Source: "{#ExeSource}"; DestDir: "{app}"; Flags: ignoreversion
 
 [Icons]
 Name: "{group}\Damus Notedeck"; Filename: "{app}\notedeck.exe"