Skip to content

Added isLoading property #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added isLoading property #206

wants to merge 3 commits into from

Conversation

alon-s
Copy link

@alon-s alon-s commented Mar 20, 2019

alon-s added 3 commits March 20, 2019 17:06
@alon-s
added isLoading, to prevent multiple page requests
5846adf 
added isLoading property. this is checked before requesting  a page, and if the component is currently loading, we don't request another page. 
solving: https://github.com/CassetteRocks/react-infinite-scroller/issues/143#
@alon-s
updated README to include isLoading
69bc861
@alon-s
text fix
15f2a00
YIZHUANG
YIZHUANG suggested changes Jul 7, 2019
View reviewed changes
Copy link

@YIZHUANG YIZHUANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this prop should be optional and default to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@YIZHUANG YIZHUANG YIZHUANG requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alon-s @YIZHUANG