screenshot: correctly detect hardware frame

llyyr · dancingmirrors · commit 19205c92e087 · 2025-12-27T10:49:10.000-07:00
This only ever worked by accident and relied on broken behavior that was
fixed by 9b1d47ece11da8625591bb5817bbad622485074b
diff --git a/player/screenshot.c b/player/screenshot.c
@@ -377,7 +377,7 @@ static struct mp_image *screenshot_get(struct MPContext *mpctx, int mode,
     }
 
     // vo_get_current_frame() can return a hardware frame, which we have to download first.
-    if (image && image->fmt.flags & MP_IMGFLAG_HWACCEL) {
+    if (image && IMGFMT_IS_HWACCEL(image->imgfmt)) {
         struct mp_image *nimage = mp_image_hw_download(image, NULL);
         talloc_free(image);
         if (!nimage)

Original file line number	Diff line number	Diff line change
`@@ -377,7 +377,7 @@ static struct mp_image screenshot_get(struct MPContext mpctx, int mode,`
`377`	`377`	`}`
`378`	`378`
`379`	`379`	`// vo_get_current_frame() can return a hardware frame, which we have to download first.`
`380`		`- if (image && image->fmt.flags & MP_IMGFLAG_HWACCEL) {`
	`380`	`+ if (image && IMGFMT_IS_HWACCEL(image->imgfmt)) {`
`381`	`381`	`struct mp_image *nimage = mp_image_hw_download(image, NULL);`
`382`	`382`	`talloc_free(image);`
`383`	`383`	`if (!nimage)`