version_validation_errors -> validation_errors

Author: jjnesbitt

dandiapi/api/tests/test_version.py

@@ -490,7 +490,7 @@ def test_version_rest_info(api_client, version):
         'metadata': version.metadata,
         'size': version.size,
         'status': version.status,
-        'version_validation_errors': [],
+        'validation_errors': [],
         'contact_person': version.metadata['contributor'][0]['name'],
     }
 
@@ -640,7 +640,7 @@ def test_version_rest_update(api_client):
         'metadata': saved_metadata,
         'size': draft_version.size,
         'status': 'Pending',
-        'version_validation_errors': [],
+        'validation_errors': [],
         'contact_person': 'Vargas, Getúlio',
     }
 

dandiapi/api/views/serializers.py

@@ -373,15 +373,11 @@ class VersionDetailSerializer(VersionSerializer):
     class Meta(VersionSerializer.Meta):
         fields = [
             *VersionSerializer.Meta.fields,
-            'version_validation_errors',
+            'validation_errors',
             'metadata',
             'contact_person',
         ]
 
-    # TODO: Rename back to just validation_errors
-    # rename this field in the serializer to differentiate from asset_validation_errors
-    version_validation_errors = serializers.JSONField(source='validation_errors')
-
     def get_contact_person(self, obj):
         return extract_contact_person(obj)
 

web/src/types/index.ts

@@ -47,7 +47,7 @@ export interface Version {
   dandiset: Dandiset,
   metadata?: DandisetMetadata,
   asset_validation_errors?: ValidationError[],
-  version_validation_errors: ValidationError[],
+  validation_errors: ValidationError[],
   contact_person?: string,
 }
 

web/src/views/DandisetLandingView/DandisetPublish.vue

@@ -372,7 +372,7 @@ const publishButtonDisabled = computed(() => {
   }
 
   return Boolean(
-    dandiset.version_validation_errors.length
+    dandiset.validation_errors.length
     || dandiset.asset_validation_errors.length
     || dandiset.dandiset.embargo_status !== 'OPEN'
     || publishDisabledMessage.value

web/src/views/DandisetLandingView/DandisetValidationErrors.vue

@@ -27,15 +27,15 @@
       <ValidationErrorDialog
         :selected-tab="selectedTab"
         :asset-validation-errors="dandiset.asset_validation_errors"
-        :version-validation-errors="dandiset.version_validation_errors"
+        :version-validation-errors="dandiset.validation_errors"
         :owner="isOwner"
         @open-meditor="openMeditor"
       />
     </v-dialog>
 
     <!-- Version Validation Errors Button -->
     <v-alert
-      v-if="dandiset.version_validation_errors.length"
+      v-if="dandiset.validation_errors.length"
       class="my-1"
       density="compact"
       icon="mdi-playlist-remove"
@@ -44,7 +44,7 @@
       @click="openErrorDialog('metadata')"
     >
       <v-alert-content class="text-body-2">
-        This Dandiset has {{ dandiset.version_validation_errors.length }} metadata validation error(s).
+        This Dandiset has {{ dandiset.validation_errors.length }} metadata validation error(s).
       </v-alert-content>
     </v-alert>